From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 2/3] bus/pci: expose sysfs parsing API Date: Wed, 14 Mar 2018 11:19:31 +0000 Message-ID: References: <20180309230809.63361-1-xiao.w.wang@intel.com> <20180309230809.63361-3-xiao.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: zhihong.wang@intel.com, maxime.coquelin@redhat.com, yliu@fridaylinux.org, cunming.liang@intel.com, rosen.xu@intel.com, junjie.j.chen@intel.com, dan.daly@intel.com To: Xiao Wang , dev@dpdk.org Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B6DA55F2A for ; Wed, 14 Mar 2018 12:19:35 +0100 (CET) In-Reply-To: <20180309230809.63361-3-xiao.w.wang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-Mar-18 11:08 PM, Xiao Wang wrote: > Some existing sysfs parsing functions are helpful for the later vDPA > driver, this patch make them global and expose them to shared lib. > > Signed-off-by: Xiao Wang > --- > drivers/bus/pci/linux/pci.c | 9 ++++----- > drivers/bus/pci/linux/pci_init.h | 8 ++++++++ > drivers/bus/pci/rte_bus_pci_version.map | 8 ++++++++ > 3 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c > index abde64119..81e5e5650 100644 > --- a/drivers/bus/pci/linux/pci.c > +++ b/drivers/bus/pci/linux/pci.c > @@ -32,7 +32,7 @@ > > extern struct rte_pci_bus rte_pci_bus; > > -static int > +int > pci_get_kernel_driver_by_path(const char *filename, char *dri_name) Here and in other places - shouldn't this too be prefixed with rte_? -- Thanks, Anatoly