On 10.08.2016 21:22, Colin Lord wrote: > On 08/10/2016 03:04 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord wrote: >>> Modularizes the nfs block driver so that it gets dynamically loaded. >>> >>> Signed-off-by: Colin Lord >>> Reviewed-by: Stefan Hajnoczi >>> --- >>> block/Makefile.objs | 1 + >>> configure | 4 ++-- >>> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> I'm not quite sure what this achieves. From what I can see, the NFS >> block driver is still linked hard into qemu and it is unconditionally >> registered at qemu startup. >> > ldd seems to be telling me that libnfs is not linked to the main binary > after this patch. >> (The output from a printf() in nfs_block_init() is visible even when >> just starting qemu-img or qemu-io without any arguments; most notably >> without bdrv_find_protocol() having been invoked at all.) >> >> Max >> > I can't seem to reproduce this. Is it possible you applied this patch > without applying the first 3 before it? Or maybe didn't have modules > enabled in the configuration? I'm so stupid. Yep, that's it. Works great now. :D Reviewed-by: Max Reitz > As far as I can tell NFS seems to building > as a module and doesn't seem to be hard linked, so I'm not really sure > what's going on. > > Colin >