From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 23 Mar 2017 15:06:12 +0100 Subject: [U-Boot] [PATCH 7/7] scsi: dts: a3700: add scsi node In-Reply-To: <1490261347-11896-8-git-send-email-make@marvell.com> References: <1490261347-11896-1-git-send-email-make@marvell.com> <1490261347-11896-8-git-send-email-make@marvell.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ken, On 23.03.2017 10:29, make at marvell.com wrote: > From: Ken Ma > > - Add scsi node which acts as a bus for scsi devices, armada3700 has > only 1 scsi interface, so max-id is 1, and the logic unit number is > also 1 for armada3700; > - Since a3700's scsi is sas(serial attached scsi) which is compatible > for sata and sata hard disk is a sas device, so move sata node to be > under scsi node. > > Signed-off-by: Ken Ma > Cc: Simon Glass > Cc: Stefan Roese > Cc: Michal Simek > Reviewed-on: http://vgitil04.il.marvell.com:8080/35303 > Tested-by: iSoC Platform CI > Reviewed-by: Kostya Porotchkin > Reviewed-by: Omri Itach > --- > arch/arm/dts/armada-3720-db.dts | 4 ++++ > arch/arm/dts/armada-37xx.dtsi | 16 ++++++++++++---- > 2 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/armada-3720-db.dts b/arch/arm/dts/armada-3720-db.dts > index 85761af..9fc60f6 100644 > --- a/arch/arm/dts/armada-3720-db.dts > +++ b/arch/arm/dts/armada-3720-db.dts > @@ -89,6 +89,10 @@ > status = "okay"; > }; > > +&scsi { > + status = "okay"; > +}; > + > /* CON3 */ > &sata { > status = "okay"; > diff --git a/arch/arm/dts/armada-37xx.dtsi b/arch/arm/dts/armada-37xx.dtsi > index 062f2a6..de5d3a1 100644 > --- a/arch/arm/dts/armada-37xx.dtsi > +++ b/arch/arm/dts/armada-37xx.dtsi > @@ -149,11 +149,19 @@ > status = "disabled"; > }; > > - sata: sata at e0000 { > - compatible = "marvell,armada-3700-ahci"; > - reg = <0xe0000 0x2000>; > - interrupts = ; > + scsi: scsi { > + compatible = "marvell,mvebu-scsi"; > + #address-cells = <1>; > + #size-cells = <1>; > + max-id = <1>; > + max-lun = <1>; > status = "disabled"; > + sata: sata at e0000 { > + compatible = "marvell,armada-3700-ahci"; > + reg = <0xe0000 0x2000>; > + interrupts = ; > + status = "disabled"; > + }; > }; > > gic: interrupt-controller at 1d00000 { > I see that you introduce a "scsi" DT node and move the SATA controller one "level up". I'm not sure if such a change is acceptable as we try to re-use the DT from Linux. Or thinking more about this, I'm pretty sure that such a change is not acceptable in general. Can't you use the existing DT layout and use the "marvell,armada-3700-ahci" (and other perhaps?) compatible property instead for driver probing? Not sure how to handle the "max-id" and "max-lun" properties though. We definitely can't just add some ad-hoc properties here in U-Boot which have no chance for Linux upstream acceptance. Thanks, Stefan