From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A7DC6FD1C for ; Wed, 22 Mar 2023 16:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbjCVQ1s (ORCPT ); Wed, 22 Mar 2023 12:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230095AbjCVQ1n (ORCPT ); Wed, 22 Mar 2023 12:27:43 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECCB62840 for ; Wed, 22 Mar 2023 09:27:24 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id cn12so29657780edb.4 for ; Wed, 22 Mar 2023 09:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679502443; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ycyENMdFF2CzvQbQDOTRVEeRhFxhD958v+PK2qLS/rA=; b=XnwQ71LENmBJUSgIhcJW0wRK5YRU9HunpXIDvks06eW2P56ged43ro5SCA7tEC7rlc IZC4F8dJ9psSZcS5rrUUXczjpoJ15xmQ61HqpZ8bODxUiVyID4MDnbccpv2qCqffWKm/ strkFgHpWhYSxgONwkyqzk2X+lNXnv6/XN3DKlt+NuNLFotcCNsb5mDCQMbJZZ1XHSfc bg+vocnKIz0ZiaWI7sw+MqJu8PnYYtR25zC0lu+ugu2QlbHI0TcgycLv6Ftmz+iPNDgu qYDiQwAHMJpxNHvNKZl57LjZex1JUt6U9DQpiMvQ9X4Yu0VvX+WPBSP+ehFSbIQhC8dO BNNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679502443; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ycyENMdFF2CzvQbQDOTRVEeRhFxhD958v+PK2qLS/rA=; b=G7h1dyxOXNItUIobtb3j/KDR7zo98vk63pmMu3y/5o5dQtIVuYio5/wmTKtEqD8E9M p3x9vvzGWhvHey2qh2J3PoL/ZCKaPdkfKC3TwwLgcw/vLVC6nVfLyzqcm2Pxa7vXTqIF gVMjQuSSmFMMeMQQCKYU3j8tF5aPtFm6B3OuhDDEAuZTHTtSCHvlm5JYOaNIjmSiDR+f MFLZZT6x3TUi+zcpMhZvED9aP3zknr1aLUBXPVCQrsNvyNjGjR9zAgXTKxNgJIxq7gxD kq+N3eLaq3pe1FlTeu3Y4mRxowuBy++dc9AmNmU5hZdOugFuZAAh+tYIU51fgENu9you r4dA== X-Gm-Message-State: AO0yUKURlhxRxVYUH1epGiEHm5/1BixFXqw2ARgBFbh/DQLYtvz3W0R0 WYJuIsbhb/VRVkl+yJQ40knpx0eu9KROJWf7yg4= X-Google-Smtp-Source: AK7set8LzK5u+Ph6/0aJMK6sntiDB6rs2QcNpTYFEg1/IjOeLFTvgvc2SMYKGCEqfQgGujE9DLjp+g== X-Received: by 2002:a05:6402:219:b0:4fb:9fd4:6ac5 with SMTP id t25-20020a056402021900b004fb9fd46ac5mr7449880edv.14.1679502442936; Wed, 22 Mar 2023 09:27:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:5050:151b:e755:1c6? ([2a02:810d:15c0:828:5050:151b:e755:1c6]) by smtp.gmail.com with ESMTPSA id p23-20020a1709066a9700b008d53ea69227sm7402394ejr.224.2023.03.22.09.27.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 09:27:22 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 17:27:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <1589f33deda07cb9f9e6c3c26bce6e02e53c168e.1679403696.git.quic_schowdhu@quicinc.com> <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/03/2023 14:34, Souradeep Chowdhury wrote: >> >>> + - const: qcom,imem-boot_stats >> >> No underscores in compatibles. Why this is not SoC specific compatible? > > Ack. The boot_stats module is not specific to a device. It is written to > read some values from this imem region which is present for almost all > QCOM SoCs. So SoC specific compatible is not given in this case. Yeah, but the generic rule is that we always want SoC specific compatibles. If this is not specific to a device, then you do not need anything in DT and just instantiate it from some soc-driver... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EEBDC6FD1F for ; Wed, 22 Mar 2023 16:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EwQmIWU1yssaGVXqiUWlachFW4GmxludwfgCCQ0VX7c=; b=eQIXf9A/nEn+Jg U0wqmhudlPMnNI7tTJg7oqFWjQ7+erSSTgNl2R/KTK1Ht4TqbSHGiwCNJvkulAQKSBHiR7jpmXxA+ WpdtlvaYomEVbq6wpUbaVc2/bdPTt8r8famyfZZipjSQyGrT/EzxNdHnwag9V8Bsq0p9Dp/WsXQ2h KRml6WwXRzU1KHpFVwfEZZ0bTIe1Yfk1hEl6wcP4Bj4/Em+0Pk4hTJgWMduAyqG3E/0sDuFSUHQy2 OBQ109saRPzLGLuxnnWWEqvHrm7q8oqfazO8Kpraw4hn3Kl24P/emEJALQ04JPYj2IgDBP+pFCtSx ZGD5Nkc7KudBIROE5PPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pf1J9-00GfZJ-0p; Wed, 22 Mar 2023 16:27:27 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pf1J6-00GfYd-1t for linux-arm-kernel@lists.infradead.org; Wed, 22 Mar 2023 16:27:25 +0000 Received: by mail-ed1-x534.google.com with SMTP id i5so28398971eda.0 for ; Wed, 22 Mar 2023 09:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679502443; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ycyENMdFF2CzvQbQDOTRVEeRhFxhD958v+PK2qLS/rA=; b=XnwQ71LENmBJUSgIhcJW0wRK5YRU9HunpXIDvks06eW2P56ged43ro5SCA7tEC7rlc IZC4F8dJ9psSZcS5rrUUXczjpoJ15xmQ61HqpZ8bODxUiVyID4MDnbccpv2qCqffWKm/ strkFgHpWhYSxgONwkyqzk2X+lNXnv6/XN3DKlt+NuNLFotcCNsb5mDCQMbJZZ1XHSfc bg+vocnKIz0ZiaWI7sw+MqJu8PnYYtR25zC0lu+ugu2QlbHI0TcgycLv6Ftmz+iPNDgu qYDiQwAHMJpxNHvNKZl57LjZex1JUt6U9DQpiMvQ9X4Yu0VvX+WPBSP+ehFSbIQhC8dO BNNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679502443; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ycyENMdFF2CzvQbQDOTRVEeRhFxhD958v+PK2qLS/rA=; b=hP0pwumefvpZE/lo2Ccn3d5iOVCuBKdboIP+Wdaj8GFY5RS+tnYeSznIvnkuH5HirD 9e5dER1JjrEEA5LyxJsylX6tbTlA8jtpiyIdbHzNy0NQZvVgqIM56TgMUlhchDJ/7Xii l+RPNhOgXHHyR8FDt3vFvQzd4O67aFCx0jk0hwLV7um/m1fdSwZuVylO0Ih9sZDajT9U cga6s1RUQO7JjEF2621mlHlEgTZFmhFPnbIr+97gd5r/yzGy/+TOAITEH4ocyCmLYr70 k0Hmv8IzVgANKIF75Nb8rnyzn6iRMuxvIlF3EvBumt7dcBbDV/2ckI5xEih6JvHEyirc K0KQ== X-Gm-Message-State: AO0yUKUdhij6lpOcLGdIQmx8jPvaNqjRmUDM/hk4SnG8Di2SYHWJ0mN+ 9TIi7vYxqdN6r66Pilh6TA6qXw== X-Google-Smtp-Source: AK7set8LzK5u+Ph6/0aJMK6sntiDB6rs2QcNpTYFEg1/IjOeLFTvgvc2SMYKGCEqfQgGujE9DLjp+g== X-Received: by 2002:a05:6402:219:b0:4fb:9fd4:6ac5 with SMTP id t25-20020a056402021900b004fb9fd46ac5mr7449880edv.14.1679502442936; Wed, 22 Mar 2023 09:27:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:5050:151b:e755:1c6? ([2a02:810d:15c0:828:5050:151b:e755:1c6]) by smtp.gmail.com with ESMTPSA id p23-20020a1709066a9700b008d53ea69227sm7402394ejr.224.2023.03.22.09.27.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 09:27:22 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 17:27:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <1589f33deda07cb9f9e6c3c26bce6e02e53c168e.1679403696.git.quic_schowdhu@quicinc.com> <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <260cf3ae-1acd-c4ac-a42d-4ca848ec5664@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230322_092724_624882_D6A656A2 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/03/2023 14:34, Souradeep Chowdhury wrote: >> >>> + - const: qcom,imem-boot_stats >> >> No underscores in compatibles. Why this is not SoC specific compatible? > > Ack. The boot_stats module is not specific to a device. It is written to > read some values from this imem region which is present for almost all > QCOM SoCs. So SoC specific compatible is not given in this case. Yeah, but the generic rule is that we always want SoC specific compatibles. If this is not specific to a device, then you do not need anything in DT and just instantiate it from some soc-driver... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel