From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 4/9] x86/PVH: provide VGA console info to Dom0
Date: Wed, 22 Sep 2021 18:03:57 +0100 [thread overview]
Message-ID: <e1def032-d8dd-f5df-c4f7-a9968083f06c@citrix.com> (raw)
In-Reply-To: <YUtFLB+n2piR+cHe@MacBook-Air-de-Roger.local>
On 22/09/2021 16:01, Roger Pau Monné wrote:
> On Tue, Sep 21, 2021 at 09:18:05AM +0200, Jan Beulich wrote:
>> --- a/xen/include/public/arch-x86/hvm/start_info.h
>> +++ b/xen/include/public/arch-x86/hvm/start_info.h
>> @@ -33,7 +33,7 @@
>> * | magic | Contains the magic value XEN_HVM_START_MAGIC_VALUE
>> * | | ("xEn3" with the 0x80 bit of the "E" set).
>> * 4 +----------------+
>> - * | version | Version of this structure. Current version is 1. New
>> + * | version | Version of this structure. Current version is 2. New
>> * | | versions are guaranteed to be backwards-compatible.
>> * 8 +----------------+
>> * | flags | SIF_xxx flags.
>> @@ -55,7 +55,15 @@
>> * | | if there is no memory map being provided. Only
>> * | | present in version 1 and newer of the structure.
>> * 52 +----------------+
>> - * | reserved | Version 1 and newer only.
>> + * | vga_info.offset| Offset of struct dom0_vga_console_info from base of
> I'm not sure we are supposed to reference external structures like
> that. We took a lot of care to not depend on other headers, and to
> make this as agnostic as possible (IIRC KVM is also capable of using
> the PVH entry point natively, and hence depends on this header).
Absolutely correct. C is not an acceptable ABI description.
Furthermore, dom0_vga_console_info is a bad ABI to start with, as
demonstrated by the multiple problems we've had extending it in the past.
The MB1/2 framebuffer information would be a rather better example to
follow, but we'll surely need to pass the EDID string too (at least in
the case that there aren't EFI runtime services to use).
~Andrew
next prev parent reply other threads:[~2021-09-22 17:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 7:15 [PATCH v3 0/9] x86/PVH: Dom0 building adjustments Jan Beulich
2021-09-21 7:16 ` [PATCH v3 1/9] x86/PVH: improve Dom0 memory size calculation Jan Beulich
2021-09-22 11:59 ` Roger Pau Monné
2021-09-29 10:53 ` Jan Beulich
2021-09-21 7:17 ` [PATCH v3 2/9] x86/PV: properly set shadow allocation for Dom0 Jan Beulich
2021-09-22 13:01 ` Roger Pau Monné
2021-09-22 13:31 ` Andrew Cooper
2021-09-22 13:50 ` Jan Beulich
2021-09-22 14:25 ` Roger Pau Monné
2021-09-22 14:28 ` Jan Beulich
2021-09-21 7:17 ` [PATCH v3 3/9] x86/PVH: permit more physdevop-s to be used by Dom0 Jan Beulich
2021-09-22 14:22 ` Roger Pau Monné
2021-09-24 12:18 ` Jan Beulich
2021-09-21 7:18 ` [PATCH v3 4/9] x86/PVH: provide VGA console info to Dom0 Jan Beulich
2021-09-22 15:01 ` Roger Pau Monné
2021-09-22 17:03 ` Andrew Cooper [this message]
2021-09-23 9:58 ` Jan Beulich
2021-09-23 9:46 ` Jan Beulich
2021-09-23 13:22 ` Roger Pau Monné
2021-09-21 7:19 ` [PATCH v3 5/9] x86/PVH: actually show Dom0's register state from debug key '0' Jan Beulich
2021-09-22 15:48 ` Roger Pau Monné
2021-09-23 10:21 ` Jan Beulich
2021-09-23 14:27 ` Roger Pau Monné
2021-09-21 7:19 ` [PATCH v3 6/9] x86/HVM: convert hvm_virtual_to_linear_addr() to be remote-capable Jan Beulich
2021-09-23 8:09 ` Roger Pau Monné
2021-09-23 10:34 ` Jan Beulich
2021-09-23 14:28 ` Roger Pau Monné
2021-09-21 7:20 ` [PATCH v3 7/9] x86/PVH: actually show Dom0's stacks from debug key '0' Jan Beulich
2021-09-23 10:31 ` Roger Pau Monné
2021-09-23 10:38 ` Roger Pau Monné
2021-09-23 10:47 ` Jan Beulich
2021-09-23 14:43 ` Roger Pau Monné
2021-09-21 7:20 ` [PATCH v3 8/9] x86/HVM: skip offline vCPU-s when dumping VMCBs/VMCSes Jan Beulich
2021-09-23 8:23 ` Roger Pau Monné
2021-09-23 11:27 ` Jan Beulich
2021-09-23 14:46 ` Roger Pau Monné
2021-09-21 7:21 ` [PATCH v3 9/9] x86/P2M: relax permissions of PVH Dom0's MMIO entries Jan Beulich
2021-09-23 11:10 ` Roger Pau Monné
2021-09-23 11:32 ` Jan Beulich
2021-09-23 11:54 ` Roger Pau Monné
2021-09-23 12:15 ` Jan Beulich
2021-09-23 15:15 ` Roger Pau Monné
2021-09-23 15:22 ` Jan Beulich
2021-09-23 15:32 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1def032-d8dd-f5df-c4f7-a9968083f06c@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.