From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:33411 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756031AbdDFJYE (ORCPT ); Thu, 6 Apr 2017 05:24:04 -0400 Subject: Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper To: Max Gurtovoy , linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org References: <1491140492-25703-1-git-send-email-sagi@grimberg.me> <1491140492-25703-6-git-send-email-sagi@grimberg.me> Cc: netdev@vger.kernel.org, Saeed Mahameed , Or Gerlitz , Christoph Hellwig From: Sagi Grimberg Message-ID: Date: Thu, 6 Apr 2017 12:23:59 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1255; format=flowed Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org > shouldn't you include and like in > commit 8ec2ef2b66ea2f that fixes blk-mq-pci.c ? Not really. We can lose these from blk-mq-pci.c as well. >> +#include >> +#include >> +#include >> +#include >> +#include "blk-mq.h" > > Is this include needed ? You're right, I can just keep: +#include +#include +#include From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper Date: Thu, 6 Apr 2017 12:23:59 +0300 Message-ID: References: <1491140492-25703-1-git-send-email-sagi@grimberg.me> <1491140492-25703-6-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1255; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Max Gurtovoy , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Saeed Mahameed , Or Gerlitz , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org > shouldn't you include and like in > commit 8ec2ef2b66ea2f that fixes blk-mq-pci.c ? Not really. We can lose these from blk-mq-pci.c as well. >> +#include >> +#include >> +#include >> +#include >> +#include "blk-mq.h" > > Is this include needed ? You're right, I can just keep: +#include +#include +#include -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sagi@grimberg.me (Sagi Grimberg) Date: Thu, 6 Apr 2017 12:23:59 +0300 Subject: [PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper In-Reply-To: References: <1491140492-25703-1-git-send-email-sagi@grimberg.me> <1491140492-25703-6-git-send-email-sagi@grimberg.me> Message-ID: > shouldn't you include and like in > commit 8ec2ef2b66ea2f that fixes blk-mq-pci.c ? Not really. We can lose these from blk-mq-pci.c as well. >> +#include >> +#include >> +#include >> +#include >> +#include "blk-mq.h" > > Is this include needed ? You're right, I can just keep: +#include +#include +#include