From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B82C43334 for ; Tue, 7 Jun 2022 10:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240538AbiFGKDZ (ORCPT ); Tue, 7 Jun 2022 06:03:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240607AbiFGKDV (ORCPT ); Tue, 7 Jun 2022 06:03:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AB9F4A7E18 for ; Tue, 7 Jun 2022 03:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654596197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tn8n2EP4nBOl/jeJiKD2hmW0PfLCuCcbPrCveEkgN4I=; b=EvLPldjEC5hfvruGlMG3BHC7V2EOxavvsVJpOAgiGHpbvvu+adiwgOAEHPUA9/m1vN9vGf J7n2xXYTv8pUJk7KkTlc32apWGOA/4pOlut0zuCT3epO0zxQqtk1lLZWWVJX8AikYDHKlb fegO2bnCjonYD7cMTwQtXJBwkqRcavw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-116-ZCY9MiO1Pq6LUwshSdlNhw-1; Tue, 07 Jun 2022 06:03:14 -0400 X-MC-Unique: ZCY9MiO1Pq6LUwshSdlNhw-1 Received: by mail-qv1-f69.google.com with SMTP id kk8-20020a056214508800b004645738eff6so7355197qvb.8 for ; Tue, 07 Jun 2022 03:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=tn8n2EP4nBOl/jeJiKD2hmW0PfLCuCcbPrCveEkgN4I=; b=FZAZS0aQabDl0iCK9bOgj9iiaSHwsNM20RxFP9f8dK7Fv/ovQ3I6IKJEluLUMrKWhs l/FuyilUIueD4jVkKSeT/Bpau31mwdmMTBpvmqUxJhIe6c7SSfb6lhv6uEP9+DLLpxtm Km+wr5qnDJEQbquC5oWJ9cApM0AMObWF3iyz7xOhv+B4QsEJsjemQIzBbes0FF2O8hNv aUEJDCBQHQyhZtmwSqht5dcpkQgHIxT4pqFqSJTkdymG4v6Jwj5XOHvaGz7DBhQitw8o ATjphrPfSJ4owLggVpJedmSruW+s1FJmSQHnvxUhv1ADuOl8js1RyJlL6HAgBIGlggCx s7Hg== X-Gm-Message-State: AOAM531o8M6q2oAuO9qeeqvD2p2V8Z0/uBHLTvvIphmDWdAfaf4aqwCQ R0rjOcXKpIe7qtKNtzW2H+/6OvezBw2naRZhXCzxoEt1KAFNAqbe6W7FqpB2JYuGoLwU1ZNHMM/ veAefQlrUmUDSzfP2o7puTYY2 X-Received: by 2002:a05:6214:5004:b0:464:4b5d:be65 with SMTP id jo4-20020a056214500400b004644b5dbe65mr34443447qvb.73.1654596192512; Tue, 07 Jun 2022 03:03:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPByfw/hUG/Aux5xx0c3Tp0JOYTT5E6Si7SnvDulKoW6LpsUErEdVOqXXLDz37bjMJ8Lh6SA== X-Received: by 2002:a05:6214:5004:b0:464:4b5d:be65 with SMTP id jo4-20020a056214500400b004644b5dbe65mr34443425qvb.73.1654596192116; Tue, 07 Jun 2022 03:03:12 -0700 (PDT) Received: from [10.35.4.238] (bzq-82-81-161-50.red.bezeqint.net. [82.81.161.50]) by smtp.gmail.com with ESMTPSA id az37-20020a05620a172500b006a6ebde4799sm462050qkb.90.2022.06.07.03.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 03:03:11 -0700 (PDT) Message-ID: Subject: Re: [PATCH v6 25/38] KVM: selftests: Move HYPERV_LINUX_OS_ID definition to a common header From: Maxim Levitsky To: Vitaly Kuznetsov , kvm@vger.kernel.org, Paolo Bonzini Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , Yuan Yao , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 07 Jun 2022 13:03:08 +0300 In-Reply-To: <20220606083655.2014609-26-vkuznets@redhat.com> References: <20220606083655.2014609-1-vkuznets@redhat.com> <20220606083655.2014609-26-vkuznets@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-2.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-06-06 at 10:36 +0200, Vitaly Kuznetsov wrote: > HYPERV_LINUX_OS_ID needs to be written to HV_X64_MSR_GUEST_OS_ID by > each Hyper-V specific selftest. > > Signed-off-by: Vitaly Kuznetsov > --- >  tools/testing/selftests/kvm/include/x86_64/hyperv.h  | 3 +++ >  tools/testing/selftests/kvm/x86_64/hyperv_features.c | 5 ++--- >  2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/x86_64/hyperv.h b/tools/testing/selftests/kvm/include/x86_64/hyperv.h > index b66910702c0a..f0a8a93694b2 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/hyperv.h > +++ b/tools/testing/selftests/kvm/include/x86_64/hyperv.h > @@ -185,4 +185,7 @@ >  /* hypercall options */ >  #define HV_HYPERCALL_FAST_BIT          BIT(16) >   > +/* Proper HV_X64_MSR_GUEST_OS_ID value */ > +#define HYPERV_LINUX_OS_ID ((u64)0x8100 << 48) > + >  #endif /* !SELFTEST_KVM_HYPERV_H */ > diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_features.c b/tools/testing/selftests/kvm/x86_64/hyperv_features.c > index 672915ce73d8..98c020356925 100644 > --- a/tools/testing/selftests/kvm/x86_64/hyperv_features.c > +++ b/tools/testing/selftests/kvm/x86_64/hyperv_features.c > @@ -14,7 +14,6 @@ >  #include "hyperv.h" >   >  #define VCPU_ID 0 > -#define LINUX_OS_ID ((u64)0x8100 << 48) >   >  extern unsigned char rdmsr_start; >  extern unsigned char rdmsr_end; > @@ -127,7 +126,7 @@ static void guest_hcall(vm_vaddr_t pgs_gpa, struct hcall_data *hcall) >         int i = 0; >         u64 res, input, output; >   > -       wrmsr(HV_X64_MSR_GUEST_OS_ID, LINUX_OS_ID); > +       wrmsr(HV_X64_MSR_GUEST_OS_ID, HYPERV_LINUX_OS_ID); >         wrmsr(HV_X64_MSR_HYPERCALL, pgs_gpa); >   >         while (hcall->control) { > @@ -230,7 +229,7 @@ static void guest_test_msrs_access(void) >                          */ >                         msr->idx = HV_X64_MSR_GUEST_OS_ID; >                         msr->write = 1; > -                       msr->write_val = LINUX_OS_ID; > +                       msr->write_val = HYPERV_LINUX_OS_ID; >                         msr->available = 1; >                         break; >                 case 3: Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky