All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: consolidate case statements
Date: Thu, 30 Sep 2021 08:27:12 +0200	[thread overview]
Message-ID: <e1ed8f5b-fac5-b578-cda6-6f16c2689990@gmail.com> (raw)
In-Reply-To: <20210929174509.1640343-1-alexander.deucher@amd.com>

Am 29.09.21 um 19:45 schrieb Alex Deucher:
> IP_VERSION(11, 0, 13) does the exact same thing as
> IP_VERSION(11, 0, 12) so squash them together.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index 382cebfc2069..aaf200ec982b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -216,13 +216,6 @@ static int psp_v11_0_init_microcode(struct psp_context *psp)
>   	case IP_VERSION(11, 0, 7):
>   	case IP_VERSION(11, 0, 11):
>   	case IP_VERSION(11, 0, 12):
> -		err = psp_init_sos_microcode(psp, chip_name);
> -		if (err)
> -			return err;
> -		err = psp_init_ta_microcode(psp, chip_name);
> -		if (err)
> -			return err;
> -		break;
>   	case IP_VERSION(11, 0, 13):
>   		err = psp_init_sos_microcode(psp, chip_name);
>   		if (err)


      parent reply	other threads:[~2021-09-30  6:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 17:45 [PATCH] drm/amdgpu: consolidate case statements Alex Deucher
2021-09-29 17:45 ` [PATCH] Documentation/gpu: remove spurious "+" in amdgpu.rst Alex Deucher
2021-09-30  6:27   ` Christian König
2021-09-30  6:27 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1ed8f5b-fac5-b578-cda6-6f16c2689990@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.