From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbcFFRZD (ORCPT ); Mon, 6 Jun 2016 13:25:03 -0400 Received: from ausxipps301.us.dell.com ([143.166.148.223]:44475 "EHLO ausxipps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbcFFRZA convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2016 13:25:00 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=VHmuDDfaFclHPI7vq8bbS192v938QAWoFGtGTqYoulIS8gijWu45JzgH kfkDJ0CIfhpmT80krZcisWJC6hMMJAHF/i459IF9BqmKgFCbiN6EtBSMC dD3K7ArIS90AiPWLRVAWESVU5gxzgl4xZesJqYW37vXNsj7wdn/RGcOWL Y=; X-LoopCount0: from 10.170.28.39 X-IronPort-AV: E=Sophos;i="5.26,428,1459832400"; d="scan'208";a="803146896" From: To: CC: , , , , , Subject: RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Topic: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Index: AQHRv/3ntC5RJsCNs0GplFP1kSdYIZ/cz42AgAAG1ID//61R8IAAbI0A//+/eTA= Date: Mon, 6 Jun 2016 17:24:57 +0000 Message-ID: References: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com> <1465222521-7217-2-git-send-email-mario_limonciello@dell.com> <20160606143947.GA4758@kroah.com> <20160606161222.GA12114@kroah.com> In-Reply-To: <20160606161222.GA12114@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.11.181.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Realtek has this in their Windows driver that all OEM's will be taking. > > Another OEM would just need to burn the right information into the SPI at > > manufacturing and expose it to the DSDT. > > Where it the match up for the Realtek bit to corrispond with this > specific ACPI field? If it's not in the ACPI spec, then vendors _WILL_ > do this in different ways. > > Again, document it, in the code, what is going on here, that's all I'm > asking. I'm not asking you to change the logic at all! I've added additional comments for v4. I strongly believe that even if another vendor does do this differently for their implementation of \\_SB.AMAC this code will be safe to run. All of the output from the field are tested for exactly what the field should look like. That said, I would be highly surprised if Realtek decided to implement with another OEM differently. It would increase their code complexity on Windows as well since this is part of the generic driver.