From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 01/14] sh_eth: fix invalid context bug while calling auto-negotiation by ethtool Date: Fri, 6 Jul 2018 18:39:35 +0300 Message-ID: References: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> <20180704081245.7395-2-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: Vladimir Zapolskiy , "David S . Miller" Return-path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:35370 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932703AbeGFPji (ORCPT ); Fri, 6 Jul 2018 11:39:38 -0400 Received: by mail-wr1-f65.google.com with SMTP id h40-v6so4614151wrh.2 for ; Fri, 06 Jul 2018 08:39:38 -0700 (PDT) In-Reply-To: <20180704081245.7395-2-vladimir_zapolskiy@mentor.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 7/4/2018 11:12 AM, Vladimir Zapolskiy wrote: > Since commit 35b5f6b1a82b ("PHYLIB: Locking fixes for PHY I/O > potentially sleeping") phy_start_aneg() function utilizes a mutex > to serialize changes to phy state, however the helper function is > called in atomic context. > > The bug can be reproduced by running "ethtool -r" command, the bug > is reported if CONFIG_DEBUG_ATOMIC_SLEEP build option is enabled. > > Fixes: dc19e4e5e02f ("sh: sh_eth: Add support ethtool") > Signed-off-by: Vladimir Zapolskiy [...] Reviewed-by: Sergei Shtylyov The patch obviously does what it promises, however I'm still not sure whether it should be placed after the next fix, not before... MBR, Sergei