From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887CDC4338F for ; Wed, 4 Aug 2021 09:30:52 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A665A60EB9 for ; Wed, 4 Aug 2021 09:30:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A665A60EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB60582C38; Wed, 4 Aug 2021 11:30:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="LUomJwOT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D5DEB82C38; Wed, 4 Aug 2021 11:30:44 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 61B8881BEE for ; Wed, 4 Aug 2021 11:30:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1628069431; bh=HGgYsHoZQSc01mRLegexrQqxg6mSm60mIp4Wf4rwl5Y=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=LUomJwOTEvJ36feFxEoBp3EuAuUou9NC0l0pZHO1SaiD4Gg2z+C/y3rzT9Ith87mS 0nxbfybmK2NG5wmCuY6jfiVzaJoMvZFmn1T0yUhbR4Ti5OOWKZsnK6DYg+j4bdS1ER 8s/jtvIRmRna6jezhTAgK6Xj+09lE4lxfsKbGI4I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.55] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MNsw4-1mUuuF221Y-00OFDN; Wed, 04 Aug 2021 11:30:31 +0200 Subject: Re: [PATCH 3/7] xyz-modem: Put xyzModem_stream_close debug diagnostic message into ZM_DEBUG() To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Simon Glass , Michal Simek , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de References: <20210803142844.19455-1-pali@kernel.org> <20210803142844.19455-4-pali@kernel.org> From: Heinrich Schuchardt Message-ID: Date: Wed, 4 Aug 2021 11:30:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803142844.19455-4-pali@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:2IcjzRSQbpbRsNc+EYb31jlSIDrX9ikKvNVuu8QHwrHsOM76Z+I BajoVZB+Ua2A9Q4dgrjrjaCbR3lq0p1XGDLc951OO2uCwpzMvgUGmBugUXYfc0mpdTxubXv AGqZMe7/OyNoiUfQrf8rbYM/0pnl8hVSdViSApCHkNJLD2puK85AaZgEDec4hfSH2RcwYPG VJdeCRqx3chWNvul8uApQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZsoAlJDRnMY=:/LjgSWGZz/CWUgiBEfzt4G G14aogihX2B9HkgDhb1IpiWyIR5jSLNVr+aMKGfNfIb9TbwAh9cj4uISWuZfqcHf7X4MUKRmx HmXSJ58PwEpWMmh6VwAknp1JQr/8O4YNBp9XuVLkrziEVm1zVzon56iCM9NH67/P6KK1O/JCT HzeAQk4sMgUqdrZv4YFLbuOJE/Gxv+qkwzZXGRRF8QCX9HwaKxBHcrykmsVvlbJtGWz/MgoSN eW9LvtMptxhJkc1rsUrq2DOfvv8fIoNgyMZZq9Ae1f1O5MBHi7e/6Rw5tJ7irqRgLbBoIcYMj NuM3PAxPnQ4wn/PMRtHfbQKds3bh+EPUEUXLgleiY4im7X8F875kzzlgGPwMizsEbY0V1Ttrw JsaWuNKtulmJzKWDmC0Kose2DxbpOCfjew5FhL+u2Mqnm6i5SrGDyAFqmgk/FKhXfgotjHOlj /bv15wtRJAQUbXJri/KgMoGr62W4gu9e2ENNnWUtVF8TwBKLqnkVgX54XWgRN1UJEH9cEync5 EyMAK8Rvj2dSQJgHJ+rcyrmPm1kGE1LuwQPjhTcF/QkPxT12Sn4obJuxbme7TWUHc3oFHALQU +bncuBP8sMFDL3nYLaDinpmzeZ+ojS/TyZ6QUNBdYEIe67T8IFqWLl33bjUbBk6j0RZTIZaEd DkbpJYFrOtmWn01R1bIDmxNHButMTknJ+lsSwzSMdBy5MZOA7FO6Jc1Auw2C2RRNkXX581Q7P BQm8b0+HZVy7OioKtk9kUErs9WQpTTskl6gLKVCDl4+lnLadoTNoLP5bSWrsF/OI6MLBfr+H6 64fOE8iYJTgmOeQCudkyZ9igGtSeF1R8oA9CIO0o89EugjVaaw6WkJG8zhlkiNWn0oQAcUnKt PtObFyiVqqGuaHtDMr/5xiPpmqvWu6qLGoXtuOzO0omkbqIqlLpEt7+24NlA+N95ktC4HYR7B kA+DFnIxR3Nkpp/7XxxvGa5upCYDsxoTUc+kYrqiCD9xqgdOzf+bG22afxmNqcX2SCgF2m20R 03+wNuWpsGwUb1AM1YxUThigkfO/6h/ExiAKnYyF8b18AQuGPkbXHR8QXwc8tSB2PHZ+y8DgZ Yq91OIzrBm0YBTZwfERFfcfWW5DTGZ9uxOrCBJyMXACRgNQwhkPa6/quQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 03.08.21 16:28, Pali Roh=C3=A1r wrote: > This is how all other debug / diagnostic messages are handled. This commit message is misleading. What you do is hide an output. > > Signed-off-by: Pali Roh=C3=A1r > --- > common/xyzModem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/xyzModem.c b/common/xyzModem.c > index 631c44e11adf..c200c9ff9177 100644 > --- a/common/xyzModem.c > +++ b/common/xyzModem.c > @@ -608,10 +608,10 @@ xyzModem_stream_read (char *buf, int size, int *er= r) > void > xyzModem_stream_close (int *err) > { > - diag_printf > + ZM_DEBUG (zm_dprintf > ("xyzModem - %s mode, %d(SOH)/%d(STX)/%d(CAN) packets, %d retries\= n", > xyz.crc_mode ? "CRC" : "Cksum", xyz.total_SOH, xyz.total_STX, > - xyz.total_CAN, xyz.total_retries); > + xyz.total_CAN, xyz.total_retries)); > ZM_DEBUG (zm_flush ()); zm_dprintf prints into the debug buffer which seems not to be overflow protected. diag_printf prints to the console. Why do you want to hide this message? Isn't the CRC what the user will want to check? And if many retries occur doesn't this alert the user that the transfer may be corrupted? Best regards Heinrich > } > >