From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D218C433EF for ; Mon, 7 Mar 2022 09:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234018AbiCGJIr (ORCPT ); Mon, 7 Mar 2022 04:08:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233162AbiCGJIp (ORCPT ); Mon, 7 Mar 2022 04:08:45 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA4D6DF55; Mon, 7 Mar 2022 01:07:50 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2631B1F43859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646644069; bh=mKuKc24peBTHJq96oPXVMVEPFG1UMKdTfUdLfSGxtH0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S+nr6l6ud+gdKu5ahDRDne/nb8H6YRD77OPWBF4KsxIFPSWoe0DszZrrWihtjWXaT KIcAbqgmYkYHkpqe6Z6JIVmXD00hmusob2Umsc2496UYcKdboInRXDfzCggoz19RLR yUcKjJLTR5n9L4ijWAvo0cXjEp1LFJ2idl8PREEPXlHFCtEDOHQS3xaoyiRnW2c6Is Tx6TPN7W1wrUrHC8GJH3UPzLbd3U+G4/vlXNJyg0fofeJG/E+3SOzatheWUZxcRDZa SK2WUgGituRC1LNkpgBKcCC0WJyGTNKbC2Oj4PfAu+ykatmh19xUR76VCfEYLa1aZ8 g2zwcLTBmrPYA== Message-ID: Date: Mon, 7 Mar 2022 10:07:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver Content-Language: en-US To: Jiaxin Yu , broonie@kernel.org Cc: lgirdwood@gmail.com, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz, p.zabel@pengutronix.de, geert+renesas@glider.be, trevor.wu@mediatek.com, tzungbi@google.com, aaronyu@google.com, zhangqilong3@huawei.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 05/03/22 05:24, Jiaxin Yu ha scritto: > On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: >> Il 17/02/22 14:41, Jiaxin Yu ha scritto: >>> Mt6366 is a new version of mt6358, and they are same about audio >>> part. >>> So we can reuse the driver of mt6358. >>> >>> Signed-off-by: Jiaxin Yu >> >> Hello Jiaxin, >> I'm sorry but this commit makes very little sense. >> >> If you want to advertise MT6366 support, please write a note and/or >> a new compatible string inside of the mt6358 driver (and dt- >> bindings), >> then, please drop this commit. >> > > Hello angelogioacchino, > > Thank you for your advice. > > If I add a new compatible string inside of the mt6358 driver and dt- > bindings, then the machine driver which want to use mt6366 should > select SND_SOC_MT6358. > > like below: > > config SND_SOC_MT8186_MT6366_DA7219_MAX98357 > tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A > codec" > depends on I2C && GPIOLIB > depends on SND_SOC_MT8186 && MTK_PMIC_WRAP > select SND_SOC_MT6366 ==> SND_SOC_MT6358 > ... > > I just doubt it's enough to make sense. I originally wanted to put this > relationship in the sound/soc/codecs layer. So that this relationship > is not perceived by users(machine driver). > However, if the general practice is like this, I will adopt your > suggestion. Thank you again. > Yes this is acceptable, please do it like that. Thanks, Angelo >> >>> --- >>> sound/soc/codecs/Kconfig | 8 ++++++++ >>> sound/soc/codecs/Makefile | 1 + >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig >>> index 8fa24783ce01..6631094678f5 100644 >>> --- a/sound/soc/codecs/Kconfig >>> +++ b/sound/soc/codecs/Kconfig >>> @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS >>> imply SND_SOC_MT6351 >>> imply SND_SOC_MT6358 >>> imply SND_SOC_MT6359 >>> + imply SND_SOC_MT6366 >>> imply SND_SOC_MT6660 >>> imply SND_SOC_NAU8315 >>> imply SND_SOC_NAU8540 >>> @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET >>> for ASoC codec soc-jack detection mechanism. >>> Select N if you don't have jack on board. >>> >>> +config SND_SOC_MT6366 >>> + tristate "MediaTek MT6366 Codec" >>> + depends on MTK_PMIC_WRAP >>> + help >>> + Enable support for the platform which uses MT6366 as >>> + external codec device. >>> + >>> config SND_SOC_MT6660 >>> tristate "Mediatek MT6660 Speaker Amplifier" >>> depends on I2C >>> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile >>> index 42d00aa4ee46..1279684feaf0 100644 >>> --- a/sound/soc/codecs/Makefile >>> +++ b/sound/soc/codecs/Makefile >>> @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- >>> mt6351.o >>> obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o >>> obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o >>> +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o >>> obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o >>> obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D311C433EF for ; Mon, 7 Mar 2022 09:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RejCeRlapUuis97fk49xVHgbTDV7fMZGPLKCKMiOGXw=; b=1eTabOCPLGT/CB 3mdMi8A6/2gyRMB6COfFoFGYWljq+gj9Tg62bgq1YbESxm0TBlHk9NmsKHk9Um0DgSUYBGAfpPC50 WpR090a8b8vdNilPMZy9Ln4BSJKglfCWNZO+v0hsSgseGWBRnSEMm5nU/jj8PYKnig0/0Q4zKETvL IhMrIN7rfOEMw83zKymNsBv6z4mys+8dCI8SkUuVKTZkkv0fHMIic45OXPW3+4a9+8pWvAKmzjPTP u5OtCbqG9WaWiGWEsYn3lQEizkjglL4DDQcoKp/VjYmlr4BT3c7yogHBlREuTyFgXBajxPMd6fMY+ dMmWy3ifyHvNXwk1w6aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR9LZ-00Gd6F-Py; Mon, 07 Mar 2022 09:08:05 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR9LN-00Gd2P-3q; Mon, 07 Mar 2022 09:07:54 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2631B1F43859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646644069; bh=mKuKc24peBTHJq96oPXVMVEPFG1UMKdTfUdLfSGxtH0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S+nr6l6ud+gdKu5ahDRDne/nb8H6YRD77OPWBF4KsxIFPSWoe0DszZrrWihtjWXaT KIcAbqgmYkYHkpqe6Z6JIVmXD00hmusob2Umsc2496UYcKdboInRXDfzCggoz19RLR yUcKjJLTR5n9L4ijWAvo0cXjEp1LFJ2idl8PREEPXlHFCtEDOHQS3xaoyiRnW2c6Is Tx6TPN7W1wrUrHC8GJH3UPzLbd3U+G4/vlXNJyg0fofeJG/E+3SOzatheWUZxcRDZa SK2WUgGituRC1LNkpgBKcCC0WJyGTNKbC2Oj4PfAu+ykatmh19xUR76VCfEYLa1aZ8 g2zwcLTBmrPYA== Message-ID: Date: Mon, 7 Mar 2022 10:07:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver Content-Language: en-US To: Jiaxin Yu , broonie@kernel.org Cc: lgirdwood@gmail.com, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz, p.zabel@pengutronix.de, geert+renesas@glider.be, trevor.wu@mediatek.com, tzungbi@google.com, aaronyu@google.com, zhangqilong3@huawei.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_010753_353642_79454B64 X-CRM114-Status: GOOD ( 21.33 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 05/03/22 05:24, Jiaxin Yu ha scritto: > On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: >> Il 17/02/22 14:41, Jiaxin Yu ha scritto: >>> Mt6366 is a new version of mt6358, and they are same about audio >>> part. >>> So we can reuse the driver of mt6358. >>> >>> Signed-off-by: Jiaxin Yu >> >> Hello Jiaxin, >> I'm sorry but this commit makes very little sense. >> >> If you want to advertise MT6366 support, please write a note and/or >> a new compatible string inside of the mt6358 driver (and dt- >> bindings), >> then, please drop this commit. >> > > Hello angelogioacchino, > > Thank you for your advice. > > If I add a new compatible string inside of the mt6358 driver and dt- > bindings, then the machine driver which want to use mt6366 should > select SND_SOC_MT6358. > > like below: > > config SND_SOC_MT8186_MT6366_DA7219_MAX98357 > tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A > codec" > depends on I2C && GPIOLIB > depends on SND_SOC_MT8186 && MTK_PMIC_WRAP > select SND_SOC_MT6366 ==> SND_SOC_MT6358 > ... > > I just doubt it's enough to make sense. I originally wanted to put this > relationship in the sound/soc/codecs layer. So that this relationship > is not perceived by users(machine driver). > However, if the general practice is like this, I will adopt your > suggestion. Thank you again. > Yes this is acceptable, please do it like that. Thanks, Angelo >> >>> --- >>> sound/soc/codecs/Kconfig | 8 ++++++++ >>> sound/soc/codecs/Makefile | 1 + >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig >>> index 8fa24783ce01..6631094678f5 100644 >>> --- a/sound/soc/codecs/Kconfig >>> +++ b/sound/soc/codecs/Kconfig >>> @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS >>> imply SND_SOC_MT6351 >>> imply SND_SOC_MT6358 >>> imply SND_SOC_MT6359 >>> + imply SND_SOC_MT6366 >>> imply SND_SOC_MT6660 >>> imply SND_SOC_NAU8315 >>> imply SND_SOC_NAU8540 >>> @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET >>> for ASoC codec soc-jack detection mechanism. >>> Select N if you don't have jack on board. >>> >>> +config SND_SOC_MT6366 >>> + tristate "MediaTek MT6366 Codec" >>> + depends on MTK_PMIC_WRAP >>> + help >>> + Enable support for the platform which uses MT6366 as >>> + external codec device. >>> + >>> config SND_SOC_MT6660 >>> tristate "Mediatek MT6660 Speaker Amplifier" >>> depends on I2C >>> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile >>> index 42d00aa4ee46..1279684feaf0 100644 >>> --- a/sound/soc/codecs/Makefile >>> +++ b/sound/soc/codecs/Makefile >>> @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- >>> mt6351.o >>> obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o >>> obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o >>> +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o >>> obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o >>> obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o >> >> > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EDD4C4332F for ; Mon, 7 Mar 2022 09:08:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B97E816F3; Mon, 7 Mar 2022 10:07:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B97E816F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646644128; bh=mKuKc24peBTHJq96oPXVMVEPFG1UMKdTfUdLfSGxtH0=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VF0tZkNUe0n8MAsyH/cYsoBpohC8XMS8a+X+qk7OxUe7CIlnbCEd0GYNMAA16+kGk GBUgeK1JIO8ipSj/+jTQj5vEZ8+ehWVs0suFtMRnzv6H3Z1jcEwBRVfmyKl1nvOMo8 dOfXlQ8kRuTZvN0r6i8Dj/5knuX52DPK3b+3M4gA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3E634F800D1; Mon, 7 Mar 2022 10:07:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B2344F8013F; Mon, 7 Mar 2022 10:07:56 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8C2D1F800D1 for ; Mon, 7 Mar 2022 10:07:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8C2D1F800D1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="S+nr6l6u" Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2631B1F43859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646644069; bh=mKuKc24peBTHJq96oPXVMVEPFG1UMKdTfUdLfSGxtH0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S+nr6l6ud+gdKu5ahDRDne/nb8H6YRD77OPWBF4KsxIFPSWoe0DszZrrWihtjWXaT KIcAbqgmYkYHkpqe6Z6JIVmXD00hmusob2Umsc2496UYcKdboInRXDfzCggoz19RLR yUcKjJLTR5n9L4ijWAvo0cXjEp1LFJ2idl8PREEPXlHFCtEDOHQS3xaoyiRnW2c6Is Tx6TPN7W1wrUrHC8GJH3UPzLbd3U+G4/vlXNJyg0fofeJG/E+3SOzatheWUZxcRDZa SK2WUgGituRC1LNkpgBKcCC0WJyGTNKbC2Oj4PfAu+ykatmh19xUR76VCfEYLa1aZ8 g2zwcLTBmrPYA== Message-ID: Date: Mon, 7 Mar 2022 10:07:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver Content-Language: en-US To: Jiaxin Yu , broonie@kernel.org References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, geert+renesas@glider.be, linux-kernel@vger.kernel.org, zhangqilong3@huawei.com, tiwai@suse.com, lgirdwood@gmail.com, tzungbi@google.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com, p.zabel@pengutronix.de, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Il 05/03/22 05:24, Jiaxin Yu ha scritto: > On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: >> Il 17/02/22 14:41, Jiaxin Yu ha scritto: >>> Mt6366 is a new version of mt6358, and they are same about audio >>> part. >>> So we can reuse the driver of mt6358. >>> >>> Signed-off-by: Jiaxin Yu >> >> Hello Jiaxin, >> I'm sorry but this commit makes very little sense. >> >> If you want to advertise MT6366 support, please write a note and/or >> a new compatible string inside of the mt6358 driver (and dt- >> bindings), >> then, please drop this commit. >> > > Hello angelogioacchino, > > Thank you for your advice. > > If I add a new compatible string inside of the mt6358 driver and dt- > bindings, then the machine driver which want to use mt6366 should > select SND_SOC_MT6358. > > like below: > > config SND_SOC_MT8186_MT6366_DA7219_MAX98357 > tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A > codec" > depends on I2C && GPIOLIB > depends on SND_SOC_MT8186 && MTK_PMIC_WRAP > select SND_SOC_MT6366 ==> SND_SOC_MT6358 > ... > > I just doubt it's enough to make sense. I originally wanted to put this > relationship in the sound/soc/codecs layer. So that this relationship > is not perceived by users(machine driver). > However, if the general practice is like this, I will adopt your > suggestion. Thank you again. > Yes this is acceptable, please do it like that. Thanks, Angelo >> >>> --- >>> sound/soc/codecs/Kconfig | 8 ++++++++ >>> sound/soc/codecs/Makefile | 1 + >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig >>> index 8fa24783ce01..6631094678f5 100644 >>> --- a/sound/soc/codecs/Kconfig >>> +++ b/sound/soc/codecs/Kconfig >>> @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS >>> imply SND_SOC_MT6351 >>> imply SND_SOC_MT6358 >>> imply SND_SOC_MT6359 >>> + imply SND_SOC_MT6366 >>> imply SND_SOC_MT6660 >>> imply SND_SOC_NAU8315 >>> imply SND_SOC_NAU8540 >>> @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET >>> for ASoC codec soc-jack detection mechanism. >>> Select N if you don't have jack on board. >>> >>> +config SND_SOC_MT6366 >>> + tristate "MediaTek MT6366 Codec" >>> + depends on MTK_PMIC_WRAP >>> + help >>> + Enable support for the platform which uses MT6366 as >>> + external codec device. >>> + >>> config SND_SOC_MT6660 >>> tristate "Mediatek MT6660 Speaker Amplifier" >>> depends on I2C >>> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile >>> index 42d00aa4ee46..1279684feaf0 100644 >>> --- a/sound/soc/codecs/Makefile >>> +++ b/sound/soc/codecs/Makefile >>> @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- >>> mt6351.o >>> obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o >>> obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o >>> +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o >>> obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o >>> obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC94CC433F5 for ; Mon, 7 Mar 2022 09:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=34Qls3D5sXzwcnyLU56Az42G7M7aNCyxrTY6fUXioxQ=; b=42X6qgZotxpyqp CkU6MVMFsUU9HX3OOcav3yD3r2C0x1yMDzLgCepsmGSJATpYoly0uoNMo5orc4MzL+q70i0qHebKz mY5ukiWQN8DKPMiYTabXt2uOa9zCEvvcrl5oNo7q53D8OK8blEx7wYL42wHfvjWg/DfuqqiqiJZ8j NJa5eP9O+Q4n9VpfUFgEMyZGAf8lfW56az5C8ibTNtAIBoQytQmkv4+c+vVW4vllVlikCPzJmdbNX TFe4diwXxJ8+tqoiqhbGECkQVLoUelPviMghJQmYiIRY/rwSH6TWf6xNANa2Te66tEYT3Va/cx27C k0FOPRxzPxjrLjxePMyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR9LR-00Gd4D-B8; Mon, 07 Mar 2022 09:07:57 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR9LN-00Gd2P-3q; Mon, 07 Mar 2022 09:07:54 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2631B1F43859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646644069; bh=mKuKc24peBTHJq96oPXVMVEPFG1UMKdTfUdLfSGxtH0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S+nr6l6ud+gdKu5ahDRDne/nb8H6YRD77OPWBF4KsxIFPSWoe0DszZrrWihtjWXaT KIcAbqgmYkYHkpqe6Z6JIVmXD00hmusob2Umsc2496UYcKdboInRXDfzCggoz19RLR yUcKjJLTR5n9L4ijWAvo0cXjEp1LFJ2idl8PREEPXlHFCtEDOHQS3xaoyiRnW2c6Is Tx6TPN7W1wrUrHC8GJH3UPzLbd3U+G4/vlXNJyg0fofeJG/E+3SOzatheWUZxcRDZa SK2WUgGituRC1LNkpgBKcCC0WJyGTNKbC2Oj4PfAu+ykatmh19xUR76VCfEYLa1aZ8 g2zwcLTBmrPYA== Message-ID: Date: Mon, 7 Mar 2022 10:07:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver Content-Language: en-US To: Jiaxin Yu , broonie@kernel.org Cc: lgirdwood@gmail.com, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz, p.zabel@pengutronix.de, geert+renesas@glider.be, trevor.wu@mediatek.com, tzungbi@google.com, aaronyu@google.com, zhangqilong3@huawei.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_010753_353642_79454B64 X-CRM114-Status: GOOD ( 21.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 05/03/22 05:24, Jiaxin Yu ha scritto: > On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: >> Il 17/02/22 14:41, Jiaxin Yu ha scritto: >>> Mt6366 is a new version of mt6358, and they are same about audio >>> part. >>> So we can reuse the driver of mt6358. >>> >>> Signed-off-by: Jiaxin Yu >> >> Hello Jiaxin, >> I'm sorry but this commit makes very little sense. >> >> If you want to advertise MT6366 support, please write a note and/or >> a new compatible string inside of the mt6358 driver (and dt- >> bindings), >> then, please drop this commit. >> > > Hello angelogioacchino, > > Thank you for your advice. > > If I add a new compatible string inside of the mt6358 driver and dt- > bindings, then the machine driver which want to use mt6366 should > select SND_SOC_MT6358. > > like below: > > config SND_SOC_MT8186_MT6366_DA7219_MAX98357 > tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A > codec" > depends on I2C && GPIOLIB > depends on SND_SOC_MT8186 && MTK_PMIC_WRAP > select SND_SOC_MT6366 ==> SND_SOC_MT6358 > ... > > I just doubt it's enough to make sense. I originally wanted to put this > relationship in the sound/soc/codecs layer. So that this relationship > is not perceived by users(machine driver). > However, if the general practice is like this, I will adopt your > suggestion. Thank you again. > Yes this is acceptable, please do it like that. Thanks, Angelo >> >>> --- >>> sound/soc/codecs/Kconfig | 8 ++++++++ >>> sound/soc/codecs/Makefile | 1 + >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig >>> index 8fa24783ce01..6631094678f5 100644 >>> --- a/sound/soc/codecs/Kconfig >>> +++ b/sound/soc/codecs/Kconfig >>> @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS >>> imply SND_SOC_MT6351 >>> imply SND_SOC_MT6358 >>> imply SND_SOC_MT6359 >>> + imply SND_SOC_MT6366 >>> imply SND_SOC_MT6660 >>> imply SND_SOC_NAU8315 >>> imply SND_SOC_NAU8540 >>> @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET >>> for ASoC codec soc-jack detection mechanism. >>> Select N if you don't have jack on board. >>> >>> +config SND_SOC_MT6366 >>> + tristate "MediaTek MT6366 Codec" >>> + depends on MTK_PMIC_WRAP >>> + help >>> + Enable support for the platform which uses MT6366 as >>> + external codec device. >>> + >>> config SND_SOC_MT6660 >>> tristate "Mediatek MT6660 Speaker Amplifier" >>> depends on I2C >>> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile >>> index 42d00aa4ee46..1279684feaf0 100644 >>> --- a/sound/soc/codecs/Makefile >>> +++ b/sound/soc/codecs/Makefile >>> @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- >>> mt6351.o >>> obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o >>> obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o >>> +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o >>> obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o >>> obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o >>> obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o >> >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel