From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E306BC38A2A for ; Sat, 9 May 2020 01:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA62C20746 for ; Sat, 9 May 2020 01:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728165AbgEIBSU (ORCPT ); Fri, 8 May 2020 21:18:20 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4308 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728051AbgEIBSU (ORCPT ); Fri, 8 May 2020 21:18:20 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9CEAAC5A4080CDBAD7ED; Sat, 9 May 2020 09:18:18 +0800 (CST) Received: from [127.0.0.1] (10.166.213.93) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Sat, 9 May 2020 09:18:07 +0800 Subject: Re: [PATCH -next] arm64: gtdt: Fix section mismatch in next_platform_timer() To: Kefeng Wang , Lorenzo Pieralisi , Sudeep Holla , , CC: Hulk Robot References: <20200508152653.157663-1-wangkefeng.wang@huawei.com> From: Hanjun Guo Message-ID: Date: Sat, 9 May 2020 09:18:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200508152653.157663-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.166.213.93] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2020/5/8 23:26, Kefeng Wang wrote: > Drop the __initdata for acpi_gtdt_desc variable to fix the section mismatch, > > WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc > The function next_platform_timer() references > the variable __initdata acpi_gtdt_desc. > This is often because next_platform_timer lacks a __initdata > annotation or the annotation of acpi_gtdt_desc is wrong. > > Reported-by: Hulk Robot > Signed-off-by: Kefeng Wang > --- > drivers/acpi/arm64/gtdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index 01962c63a711..6a327616a299 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -34,7 +34,7 @@ struct acpi_gtdt_descriptor { > void *platform_timer; > }; > > -static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata; > +static struct acpi_gtdt_descriptor acpi_gtdt_desc; > > static inline void *next_platform_timer(void *platform_timer) I prefer to make this function as no inline, and make it as __init function, becasue acpi_gtdt_desc is not used after gtdt_sbsa_gwdt_init(). Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C35C38A2A for ; Sat, 9 May 2020 01:18:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16E7D24954 for ; Sat, 9 May 2020 01:18:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JLMgaGwj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16E7D24954 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jo64+YY+gFNzAS/phQtvIuHXoUbduTcd7+OnP/n/rTg=; b=JLMgaGwjK8SHaVrZsKvnoixdL 2hCOUnU45TFHxvxGtiLbWayYTYg8uKyAl8Xb7yHmMXdd1fY+/XKALkABvpgmrkvwWWcnksm8+lWU5 BnZqS0hL2fQPOt37O4N5wvWtWptQ16nBW8ak/0b17D2PTMsaxv2F9CihEhOCODyPbR/8l9DNEocje QxAWBCRD4YQh6VGGwoCSvggJ0m1Y2mRiRTgVQvuyDhRXWHOnenjfT13910DI4H/QiLFGU7us18ulh jb9sSHCo6hj/k2BFQMJa9f3xjtXAIFGKdDz23LJKaKSMJaOfDgHBYucIs/3SrYBt7awwweLIcw6ZM xOrhp2wIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXE8W-0005b3-SG; Sat, 09 May 2020 01:18:40 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXE8S-0005aQ-KQ for linux-arm-kernel@lists.infradead.org; Sat, 09 May 2020 01:18:38 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9CEAAC5A4080CDBAD7ED; Sat, 9 May 2020 09:18:18 +0800 (CST) Received: from [127.0.0.1] (10.166.213.93) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Sat, 9 May 2020 09:18:07 +0800 Subject: Re: [PATCH -next] arm64: gtdt: Fix section mismatch in next_platform_timer() To: Kefeng Wang , Lorenzo Pieralisi , Sudeep Holla , , References: <20200508152653.157663-1-wangkefeng.wang@huawei.com> From: Hanjun Guo Message-ID: Date: Sat, 9 May 2020 09:18:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200508152653.157663-1-wangkefeng.wang@huawei.com> Content-Language: en-GB X-Originating-IP: [10.166.213.93] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200508_181836_838912_5510E3F0 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hulk Robot Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/5/8 23:26, Kefeng Wang wrote: > Drop the __initdata for acpi_gtdt_desc variable to fix the section mismatch, > > WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc > The function next_platform_timer() references > the variable __initdata acpi_gtdt_desc. > This is often because next_platform_timer lacks a __initdata > annotation or the annotation of acpi_gtdt_desc is wrong. > > Reported-by: Hulk Robot > Signed-off-by: Kefeng Wang > --- > drivers/acpi/arm64/gtdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index 01962c63a711..6a327616a299 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -34,7 +34,7 @@ struct acpi_gtdt_descriptor { > void *platform_timer; > }; > > -static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata; > +static struct acpi_gtdt_descriptor acpi_gtdt_desc; > > static inline void *next_platform_timer(void *platform_timer) I prefer to make this function as no inline, and make it as __init function, becasue acpi_gtdt_desc is not used after gtdt_sbsa_gwdt_init(). Thanks Hanjun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel