From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F492C77B75 for ; Fri, 5 May 2023 18:08:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232260AbjEESIL (ORCPT ); Fri, 5 May 2023 14:08:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230473AbjEESIK (ORCPT ); Fri, 5 May 2023 14:08:10 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0503160A1 for ; Fri, 5 May 2023 11:08:08 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-50bcb00a4c2so3328912a12.1 for ; Fri, 05 May 2023 11:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683310087; x=1685902087; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=liqV6NqUdeMiUfLaQ9XT4OjLy4lag2MJKfmHrTaiAXA=; b=tHVhUwKAcKu9p76BGLqvnCJr9lQrO9DJLkeKWZHYcLI6aZKekinU9Qkwj8dGGaXIZT cAjyiCuIw1fUAZL84iC39VGfbLIAUgBZ4J6D68Pyjgky/0WMU9DbXww/6eTgHsZSAAb/ RiOY7bg8HybrQJgCIFYn2TAfpxuvXHCJncIxZbWG8pcRe7on99qg21RQrMaJYDTZO4lv axbr2n+6cKuGGKH/VmdePxmnKCSU1zRq1XmKDjLUp4yKmdy9Y/2zrf0XaIcQjG4g5Wr5 SwSi0+NSj0AYEmzV6yLCELjNDWow0KNFkbfayQx6Rz1WCIfteG6IIbT28ZYPDuXmoFjK cedw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683310087; x=1685902087; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=liqV6NqUdeMiUfLaQ9XT4OjLy4lag2MJKfmHrTaiAXA=; b=FZ0I4INh7BGB9GGL6vFYm/dosqnk0AWHpmI2yfoOO7AOTlSdrpqBNgNWjBluSdGSxY GH9FMUqLjPy9qkUp0C/BMRy7wubstbqe4PLR7H29QfcSPD2KiXMQBkIIBNyfb8Lu8i90 Vw2iVNdoE6/7fNOjChV9PXtxLCqYneymbB8Z1QMX6wFu9bwOn3d2+RFP+bcbFDSqXhcK a3i1Xo3Epd9eahhmrfWjCHgNqfmOZdTqx7GC9jPF0tE42mHlZdmcHgtd8rwrNFwUCyA/ 4LdSgswahAYUoVxIWTJbn9IwRhB0R4WxtUTs2mZH7CxTlFz3wz1CUzhaeG2hhvmUiB3F QHIA== X-Gm-Message-State: AC+VfDxfrcjjwCYPDc++GPMj1vlCdfrG3tdNfZi3dmncM++EFxVY6V2K yXlOS98lg/QGVDKUCUezCh/Hq9EZLaeLihrunztdcA== X-Google-Smtp-Source: ACHHUZ70HceySeIRZzJuDfcNllYZ1FTV3pLwKfPt4aGBnGT5bBOo35PmHVWf8gRmXI3gwn1A+aBYOA== X-Received: by 2002:a05:6402:14e:b0:50b:ff3c:d497 with SMTP id s14-20020a056402014e00b0050bff3cd497mr2078703edu.23.1683310087306; Fri, 05 May 2023 11:08:07 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:52e:24ce:bbc1:127d? ([2a02:810d:15c0:828:52e:24ce:bbc1:127d]) by smtp.gmail.com with ESMTPSA id v18-20020aa7dbd2000000b0050bd85ab1cfsm3181803edt.48.2023.05.05.11.08.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 11:08:06 -0700 (PDT) Message-ID: Date: Fri, 5 May 2023 20:08:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: Add Renesas RAA215300 PMIC bindings Content-Language: en-US To: Biju Das , Lee Jones , Rob Herring , Krzysztof Kozlowski Cc: Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Fabrizio Castro References: <20230505172530.357455-1-biju.das.jz@bp.renesas.com> <20230505172530.357455-2-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20230505172530.357455-2-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/05/2023 19:25, Biju Das wrote: > Document Renesas RAA215300 PMIC bindings. > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > Memory, with Built-In Charger and RTC. > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > The internally compensated regulators, built-in Real-Time Clock (RTC), > 32kHz crystal oscillator, and coin cell battery charger provide a > highly integrated, small footprint power solution ideal for > System-On-Module (SOM) applications. A spread spectrum feature > provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > Signed-off-by: Biju Das > --- > RFC->v2: > * Updated reg property > * Added optional reg-names, interrupts and renesas,rtc-enabled > properties. > * Fixed the node name in the example > * Dropped the cross link property renesas,raa215300-rtc. > * Updated the example > --- > .../bindings/mfd/renesas,raa215300.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > new file mode 100644 > index 000000000000..85cb4f0b5711 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/renesas,raa215300.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > + > +maintainers: > + - Biju Das > + > +description: | > + The RAA215300 is a high-performance, low-cost 9-channel PMIC designed for > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, DDR3L, DDR4, > + and LPDDR4 memory power requirements. The internally compensated regulators, > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin cell > + battery charger provide a highly integrated, small footprint power solution > + ideal for System-On-Module (SOM) applications. A spread spectrum feature > + provides an ease-of-use solution for noise-sensitive audio or RF applications. > + > + This device exposes two devices via I2C. One for the integrated RTC IP, and > + one for everything else. > + > + Link to datasheet: > + https://www.renesas.com/in/en/products/power-power-management/multi-channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic-and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-memory-built-charger-and-rtc > + > +properties: > + compatible: > + enum: > + - renesas,raa215300 > + > + reg: > + minItems: 1 > + maxItems: 2 > + > + reg-names: > + items: > + - const: main > + - const: rtc > + > + interrupts: > + maxItems: 1 > + > + renesas,rtc-enabled: > + description: > + To indicate RTC is enabled on the PMIC. "Enabled" by who or what? This looks like some policy, so Devicetree is not a place for it. > + type: boolean > + > +required: > + - compatible > + - reg Best regards, Krzysztof