All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Omar Sandoval <osandov@osandov.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
	Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
	Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH blktests 2/2] block/011: Perform PCI reset while doing IO
Date: Mon, 26 Jun 2017 15:45:11 -0600	[thread overview]
Message-ID: <e23fd8bf-ecaf-2e86-49d5-ce500d47c817@kernel.dk> (raw)
In-Reply-To: <20170626212934.GG6710@vader.dhcp.thefacebook.com>

On 06/26/2017 03:29 PM, Omar Sandoval wrote:
> On Mon, Jun 26, 2017 at 08:25:36AM -0600, Jens Axboe wrote:
>> On 06/26/2017 08:06 AM, Johannes Thumshirn wrote:
>>> On Fri, Jun 23, 2017 at 09:36:14AM -0600, Jens Axboe wrote:
>>>> On 06/23/2017 08:29 AM, Johannes Thumshirn wrote:
>>>>> From: Omar Sandoval <osandov@fb.com>
>>>>>
>>>>> This test-case performs I/O with fio while doing PCI disable/enable
>>>>> cycles.
>>>>>
>>>>> In the results we don't care for I/O errors but for hiccups in dmesg only.
>>>>
>>>> Let's get this in, that would be a very useful test. A few comments -
>>>> not necessarily on this patch in particular, but for future cleanups
>>>> and improvements.
>>>>
>>>>> +	if _test_dev_is_rotational; then
>>>>> +		size="32m"
>>>>> +	else
>>>>> +		size="1g"
>>>>> +	fi
>>>>
>>>> I introduced this idea in one of my previous patches. I wonder if we
>>>> should turn that into a helper. Pass in the dev, get returned a
>>>> suitable fio size, instead of hard coding this in each job that
>>>> needs it.
> 
> What I wanted to have here eventually is a helper that you can run when
> you just want arbitrary I/O. Haven't gotten around to it.

That would be handy. Until that happens, I would not worry about it,
it's not like it's a lot of work to just copy/paste the "do random
reads QD=x with Y jobs" between jobs. It'd be fine as a separate
cleanup at some point.


-- 
Jens Axboe

  reply	other threads:[~2017-06-26 21:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 14:29 [PATCH blktests 1/2] rc: add helpers to handle PCI test devices Johannes Thumshirn
2017-06-23 14:29 ` [PATCH blktests 2/2] block/011: Perform PCI reset while doing IO Johannes Thumshirn
2017-06-23 15:36   ` Jens Axboe
2017-06-26 14:06     ` Johannes Thumshirn
2017-06-26 14:25       ` Jens Axboe
2017-06-26 21:29         ` Omar Sandoval
2017-06-26 21:45           ` Jens Axboe [this message]
2017-06-26 21:27   ` Omar Sandoval
2017-06-27  6:49     ` Johannes Thumshirn
2017-06-26 21:31 ` [PATCH blktests 1/2] rc: add helpers to handle PCI test devices Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e23fd8bf-ecaf-2e86-49d5-ce500d47c817@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.