From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdIKUHc (ORCPT ); Mon, 11 Sep 2017 16:07:32 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:38798 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbdIKUH3 (ORCPT ); Mon, 11 Sep 2017 16:07:29 -0400 X-Google-Smtp-Source: ADKCNb57GQ8H6uI9lWUYDMSL6nEZTC/l0SJag8tpiX9gsd/5CwDWznvufRv+EvrS1nrjIlte2/cV/w== Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' To: Christophe JAILLET , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> From: Jens Axboe Message-ID: Date: Mon, 11 Sep 2017 14:07:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2017 02:04 PM, Christophe JAILLET wrote: > Le 11/09/2017 à 21:52, Jens Axboe a écrit : >> On 09/11/2017 01:43 PM, Christophe JAILLET wrote: >>> If the 'kmalloc' fails, we must go through the existing error handling >>> path. >> Looks good to me, probably wants a >> >> Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") >> >> line as well. >> > Hi, > > do you want me to resend with the Fixes tag? Or will it be added if merged? Shouldn't be necessary to resend. Not sure who will queue it up, mm/ always ends up being somewhat of a no-mans-land :-) -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Mon, 11 Sep 2017 20:07:27 +0000 Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' Message-Id: List-Id: References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> In-Reply-To: <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christophe JAILLET , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/11/2017 02:04 PM, Christophe JAILLET wrote: > Le 11/09/2017 à 21:52, Jens Axboe a écrit : >> On 09/11/2017 01:43 PM, Christophe JAILLET wrote: >>> If the 'kmalloc' fails, we must go through the existing error handling >>> path. >> Looks good to me, probably wants a >> >> Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") >> >> line as well. >> > Hi, > > do you want me to resend with the Fixes tag? Or will it be added if merged? Shouldn't be necessary to resend. Not sure who will queue it up, mm/ always ends up being somewhat of a no-mans-land :-) -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id F043F6B02EA for ; Mon, 11 Sep 2017 16:07:30 -0400 (EDT) Received: by mail-pg0-f70.google.com with SMTP id 11so18150522pge.4 for ; Mon, 11 Sep 2017 13:07:30 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id f9sor3894732pgp.86.2017.09.11.13.07.29 for (Google Transport Security); Mon, 11 Sep 2017 13:07:29 -0700 (PDT) Subject: Re: [PATCH] mm/backing-dev.c: fix an error handling path in 'cgwb_create()' References: <20170911194323.17833-1-christophe.jaillet@wanadoo.fr> <512a90ae-a8bf-7ead-32ba-b4fe36866b20@kernel.dk> <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> From: Jens Axboe Message-ID: Date: Mon, 11 Sep 2017 14:07:27 -0600 MIME-Version: 1.0 In-Reply-To: <1c50dbc9-f765-5b90-1f00-7d87205382d7@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Christophe JAILLET , jack@suse.cz, tj@kernel.org, geliangtang@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/11/2017 02:04 PM, Christophe JAILLET wrote: > Le 11/09/2017 A 21:52, Jens Axboe a A(C)crit : >> On 09/11/2017 01:43 PM, Christophe JAILLET wrote: >>> If the 'kmalloc' fails, we must go through the existing error handling >>> path. >> Looks good to me, probably wants a >> >> Fixes: 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific bdi_writebacks") >> >> line as well. >> > Hi, > > do you want me to resend with the Fixes tag? Or will it be added if merged? Shouldn't be necessary to resend. Not sure who will queue it up, mm/ always ends up being somewhat of a no-mans-land :-) -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org