From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D2B5C67871 for ; Tue, 10 Jan 2023 08:33:04 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4292140691; Tue, 10 Jan 2023 09:33:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6502F40689 for ; Tue, 10 Jan 2023 09:33:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673339581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K3tPcIVImjlAAj5CAPXEeN0310le0TxcJCQVvFxn8Mk=; b=Gwk5019t07GIhU7NrGFObRmkuTKBugKnmtJwJRgnP5ZvEv2dtCilDvUOuX65/I2atheKzH /NwAjilieLFgva0X+EI52N69cGjWeHTXXAolrXk+ihF6wEoLTUpNTtTNVj6GAmbbdSROfX C7wLrIOBduPz0aX20AZCsGtCW0HFYIw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-3UDXbAANNWi7Qy6-sZRjtg-1; Tue, 10 Jan 2023 03:32:56 -0500 X-MC-Unique: 3UDXbAANNWi7Qy6-sZRjtg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 546CA802D1B; Tue, 10 Jan 2023 08:32:56 +0000 (UTC) Received: from [10.39.208.23] (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0159640C2064; Tue, 10 Jan 2023 08:32:54 +0000 (UTC) Message-ID: Date: Tue, 10 Jan 2023 09:32:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 1/3] test/bbdev: explicit check for allocation failure To: Nicolas Chautru , dev@dpdk.org, Thomas Monjalon , David Marchand Cc: hernan.vargas@intel.com, stable@dpdk.org References: <20221214233346.391973-1-nicolas.chautru@intel.com> <20221214233346.391973-2-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20221214233346.391973-2-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas & David, Below patch is a fix for a patch you didn't pulled yet. I will squash it to the faulty commit. Regards, Maxime On 12/15/22 00:33, Nicolas Chautru wrote: > Adding check for error on return of the > rte_bbdev_*_op_alloc_bulk calls in bbdev-test. > > Fixes: f714a18885a6 ("app/testbbdev: add test application for > bbdev") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index a922d69ada..b2096525ea 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -4959,7 +4959,7 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_fft_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5042,7 +5042,7 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5128,7 +5128,7 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", ops_enq); > + TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, > bufs->inputs,