From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: bq24735 charger and ac-detect Date: Thu, 15 Dec 2016 14:07:11 +0000 Message-ID: References: <20161214142502.su4auesnlqmgxspv@earth> <20161214145951.uuoijetzat2bxmbv@earth> <84ede737-9e4c-b0ba-5a37-a96a7e86c3ec@axentia.se> <21e09552-96b9-fb72-60be-7a4b9347b761@nvidia.com> <721122dd-dda8-1830-9224-40b5ed79e463@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <721122dd-dda8-1830-9224-40b5ed79e463-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Rosin , Sebastian Reichel , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 15/12/16 14:04, Jon Hunter wrote: > > On 15/12/16 12:04, Peter Rosin wrote: > > ... > >>> The only other option is to add another >>> property called something like 'ti,ac-detect-override-pol' to specify >>> the polarity you want. >> >> How is that helping? It's no different that just saying active-low for >> boards that do not invert ACOK (which is what I currently do in my dts, >> but I hate doing it since it doesn't match dt docs and is therefore just >> wrong). > > By providing a means for the user to specify the polarity for their > board. Of course the documentation would need to be updated as well. I > think all solutions will be ugly if we need to preserve compatibility. > >>> To be honest, I am not sure how this type of thing is normally handled. >>> So probably best to put together a patch with whatever option you feel >>> best and explain why this is needed and see what the dev-tree folks say. >> >> I suspect that at the end of the day documentation is less important than >> regressions. But if there are more than one implementation of the same >> spec and Linux is not following it, it's kind of harsh to change the spec >> to match Linux. I doubt that there are any other users in this case though, >> but what do I know? >> >> I'll send a patch re-documenting ti,ac-detect-gpios to specify AC absence >> instead of AC presence, let's see what the dt people thinks... > > Fine with me and of course that works for Tegra, but how does that > ultimately help you? How do you tell the driver to use active-high > instead of the default which is not active-low? s/which is not/which is now/ Jon -- nvpublic