From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A96C433F5 for ; Thu, 5 May 2022 07:26:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241182AbiEEH3s (ORCPT ); Thu, 5 May 2022 03:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231535AbiEEH3q (ORCPT ); Thu, 5 May 2022 03:29:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07E841E3C1 for ; Thu, 5 May 2022 00:26:04 -0700 (PDT) Received: from kwepemi500011.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kv4tH12cHzGp6M; Thu, 5 May 2022 15:23:19 +0800 (CST) Received: from kwepemm600015.china.huawei.com (7.193.23.52) by kwepemi500011.china.huawei.com (7.221.188.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 15:26:02 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by kwepemm600015.china.huawei.com (7.193.23.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 15:26:01 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2375.024; Thu, 5 May 2022 08:25:59 +0100 From: Shameerali Kolothum Thodi To: Joao Martins , "Tian, Kevin" CC: Joerg Roedel , Suravee Suthikulpanit , Will Deacon , Robin Murphy , Jean-Philippe Brucker , zhukeqian , David Woodhouse , "Lu Baolu" , Jason Gunthorpe , "Nicolin Chen" , Yishai Hadas , Eric Auger , "Liu, Yi L" , Alex Williamson , Cornelia Huck , "kvm@vger.kernel.org" , "iommu@lists.linux-foundation.org" , jiangkunkun Subject: RE: [PATCH RFC 15/19] iommu/arm-smmu-v3: Add set_dirty_tracking_range() support Thread-Topic: [PATCH RFC 15/19] iommu/arm-smmu-v3: Add set_dirty_tracking_range() support Thread-Index: AQHYW0SOJt+hrtPz+UGjCaMWTRJpLK0GftqAgAArz4CACT+tUA== Date: Thu, 5 May 2022 07:25:59 +0000 Message-ID: References: <20220428210933.3583-1-joao.m.martins@oracle.com> <20220428210933.3583-16-joao.m.martins@oracle.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSm9hbyBNYXJ0aW5zIFtt YWlsdG86am9hby5tLm1hcnRpbnNAb3JhY2xlLmNvbV0NCj4gU2VudDogMjkgQXByaWwgMjAyMiAx MjowNQ0KPiBUbzogVGlhbiwgS2V2aW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KPiBDYzogSm9l cmcgUm9lZGVsIDxqb3JvQDhieXRlcy5vcmc+OyBTdXJhdmVlIFN1dGhpa3VscGFuaXQNCj4gPHN1 cmF2ZWUuc3V0aGlrdWxwYW5pdEBhbWQuY29tPjsgV2lsbCBEZWFjb24gPHdpbGxAa2VybmVsLm9y Zz47IFJvYmluDQo+IE11cnBoeSA8cm9iaW4ubXVycGh5QGFybS5jb20+OyBKZWFuLVBoaWxpcHBl IEJydWNrZXINCj4gPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IHpodWtlcWlhbiA8emh1a2Vx aWFuMUBodWF3ZWkuY29tPjsNCj4gU2hhbWVlcmFsaSBLb2xvdGh1bSBUaG9kaSA8c2hhbWVlcmFs aS5rb2xvdGh1bS50aG9kaUBodWF3ZWkuY29tPjsNCj4gRGF2aWQgV29vZGhvdXNlIDxkd213MkBp bmZyYWRlYWQub3JnPjsgTHUgQmFvbHUNCj4gPGJhb2x1Lmx1QGxpbnV4LmludGVsLmNvbT47IEph c29uIEd1bnRob3JwZSA8amdnQG52aWRpYS5jb20+OyBOaWNvbGluIENoZW4NCj4gPG5pY29saW5j QG52aWRpYS5jb20+OyBZaXNoYWkgSGFkYXMgPHlpc2hhaWhAbnZpZGlhLmNvbT47IEVyaWMgQXVn ZXINCj4gPGVyaWMuYXVnZXJAcmVkaGF0LmNvbT47IExpdSwgWWkgTCA8eWkubC5saXVAaW50ZWwu Y29tPjsgQWxleCBXaWxsaWFtc29uDQo+IDxhbGV4LndpbGxpYW1zb25AcmVkaGF0LmNvbT47IENv cm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPjsNCj4ga3ZtQHZnZXIua2VybmVsLm9yZzsg aW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCBS RkMgMTUvMTldIGlvbW11L2FybS1zbW11LXYzOiBBZGQNCj4gc2V0X2RpcnR5X3RyYWNraW5nX3Jh bmdlKCkgc3VwcG9ydA0KPiANCj4gT24gNC8yOS8yMiAwOToyOCwgVGlhbiwgS2V2aW4gd3JvdGU6 DQo+ID4+IEZyb206IEpvYW8gTWFydGlucyA8am9hby5tLm1hcnRpbnNAb3JhY2xlLmNvbT4NCj4g Pj4gU2VudDogRnJpZGF5LCBBcHJpbCAyOSwgMjAyMiA1OjA5IEFNDQo+ID4+DQo+ID4+IFNpbWls YXIgdG8gLnJlYWRfYW5kX2NsZWFyX2RpcnR5KCkgdXNlIHRoZSBwYWdlIHRhYmxlDQo+ID4+IHdh bGtlciBoZWxwZXIgZnVuY3Rpb25zIGFuZCBzZXQgREJNfFJET05MWSBiaXQsIHRodXMNCj4gPj4g c3dpdGNoaW5nIHRoZSBJT1BURSB0byB3cml0ZWFibGUtY2xlYW4uDQo+ID4NCj4gPiB0aGlzIHNo b3VsZCBub3QgYmUgb25lLW9mZiBpZiB0aGUgb3BlcmF0aW9uIG5lZWRzIHRvIGJlDQo+ID4gYXBw bGllZCB0byBJT1BURS4gU2F5IGEgbWFwIHJlcXVlc3QgY29tZXMgcmlnaHQgYWZ0ZXINCj4gPiBz ZXRfZGlydHlfdHJhY2tpbmcoKSBpcyBjYWxsZWQuIElmIGl0J3MgYWdyZWVkIHRvIHJlbW92ZQ0K PiA+IHRoZSByYW5nZSBvcCB0aGVuIHNtbXUgZHJpdmVyIHNob3VsZCByZWNvcmQgdGhlIHRyYWNr aW5nDQo+ID4gc3RhdHVzIGludGVybmFsbHkgYW5kIHRoZW4gYXBwbHkgdGhlIG1vZGlmaWVyIHRv IGFsbCB0aGUgbmV3DQo+ID4gbWFwcGluZ3MgYXV0b21hdGljYWxseSBiZWZvcmUgZGlydHkgdHJh Y2tpbmcgaXMgZGlzYWJsZWQuDQo+ID4gT3RoZXJ3aXNlIHRoZSBzYW1lIGxvZ2ljIG5lZWRzIHRv IGJlIGtlcHQgaW4gaW9tbXVmZCB0bw0KPiA+IGNhbGwgc2V0X2RpcnR5X3RyYWNraW5nX3Jhbmdl KCkgZXhwbGljaXRseSBmb3IgZXZlcnkgbmV3DQo+ID4gaW9wdF9hcmVhIGNyZWF0ZWQgd2l0aGlu IHRoZSB0cmFja2luZyB3aW5kb3cuDQo+IA0KPiBHYWgsIEkgdG90YWxseSBtaXNzZWQgdGhhdCBi eSBtaXN0YWtlLiBOZXcgbWFwcGluZ3MgYXJlbid0DQo+IGNhcnJ5aW5nIG92ZXIgdGhlICJEQk0g aXMgc2V0Ii4gVGhpcyBuZWVkcyBhIG5ldyBpby1wZ3RhYmxlDQo+IHF1aXJrIGFkZGVkIHBvc3Qg ZGlydHktdHJhY2tpbmcgdG9nZ2xpbmcuDQo+IA0KPiBJIGNhbiBhZGp1c3QsIGJ1dCBJIGFtIGF0 IG9kZHMgb24gaW5jbHVkaW5nIHRoaXMgaW4gYSBmdXR1cmUNCj4gaXRlcmF0aW9uIGdpdmVuIHRo YXQgSSBjYW4ndCByZWFsbHkgdGVzdCBhbnkgb2YgdGhpcyBzdHVmZi4NCj4gTWlnaHQgZHJvcCB0 aGUgZHJpdmVyIHVudGlsIEkgaGF2ZSBoYXJkd2FyZS9lbXVsYXRpb24gSSBjYW4NCj4gdXNlIChv ciBtYXliZSBvdGhlcnMgY2FuIHRha2Ugb3ZlciB0aGlzKS4gSXQgd2FzIGluY2x1ZGVkDQo+IGZv ciByZXZpc2luZyB0aGUgaW9tbXUgY29yZSBvcHMgYW5kIHdoZXRoZXIgaW9tbXVmZCB3YXMNCj4g YWZmZWN0ZWQgYnkgaXQuDQoNClsrS3Vua3VuIEppYW5nXS4gSSB0aGluayBoZSBpcyBub3cgbG9v a2luZyBpbnRvIHRoaXMgYW5kIG1pZ2h0IGhhdmUNCmEgdGVzdCBzZXR1cCB0byB2ZXJpZnkgdGhp cy4NCg0KVGhhbmtzLA0KU2hhbWVlcg0KDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A588C433EF for ; Thu, 5 May 2022 07:26:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0FDDA83F65; Thu, 5 May 2022 07:26:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 76oFJ0lmWA3y; Thu, 5 May 2022 07:26:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id E183B83F67; Thu, 5 May 2022 07:26:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B303EC0039; Thu, 5 May 2022 07:26:11 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id BCB57C002D for ; Thu, 5 May 2022 07:26:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 96A4540112 for ; Thu, 5 May 2022 07:26:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tp4CifqAfNAZ for ; Thu, 5 May 2022 07:26:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by smtp2.osuosl.org (Postfix) with ESMTPS id B63AC400A4 for ; Thu, 5 May 2022 07:26:07 +0000 (UTC) Received: from kwepemi500011.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kv4tH12cHzGp6M; Thu, 5 May 2022 15:23:19 +0800 (CST) Received: from kwepemm600015.china.huawei.com (7.193.23.52) by kwepemi500011.china.huawei.com (7.221.188.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 15:26:02 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by kwepemm600015.china.huawei.com (7.193.23.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 15:26:01 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2375.024; Thu, 5 May 2022 08:25:59 +0100 To: Joao Martins , "Tian, Kevin" Subject: RE: [PATCH RFC 15/19] iommu/arm-smmu-v3: Add set_dirty_tracking_range() support Thread-Topic: [PATCH RFC 15/19] iommu/arm-smmu-v3: Add set_dirty_tracking_range() support Thread-Index: AQHYW0SOJt+hrtPz+UGjCaMWTRJpLK0GftqAgAArz4CACT+tUA== Date: Thu, 5 May 2022 07:25:59 +0000 Message-ID: References: <20220428210933.3583-1-joao.m.martins@oracle.com> <20220428210933.3583-16-joao.m.martins@oracle.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: Jean-Philippe Brucker , Yishai Hadas , Jason Gunthorpe , "kvm@vger.kernel.org" , Will Deacon , Cornelia Huck , "iommu@lists.linux-foundation.org" , Alex Williamson , David Woodhouse , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Shameerali Kolothum Thodi via iommu Reply-To: Shameerali Kolothum Thodi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > -----Original Message----- > From: Joao Martins [mailto:joao.m.martins@oracle.com] > Sent: 29 April 2022 12:05 > To: Tian, Kevin > Cc: Joerg Roedel ; Suravee Suthikulpanit > ; Will Deacon ; Robin > Murphy ; Jean-Philippe Brucker > ; zhukeqian ; > Shameerali Kolothum Thodi ; > David Woodhouse ; Lu Baolu > ; Jason Gunthorpe ; Nicolin Chen > ; Yishai Hadas ; Eric Auger > ; Liu, Yi L ; Alex Williamson > ; Cornelia Huck ; > kvm@vger.kernel.org; iommu@lists.linux-foundation.org > Subject: Re: [PATCH RFC 15/19] iommu/arm-smmu-v3: Add > set_dirty_tracking_range() support > > On 4/29/22 09:28, Tian, Kevin wrote: > >> From: Joao Martins > >> Sent: Friday, April 29, 2022 5:09 AM > >> > >> Similar to .read_and_clear_dirty() use the page table > >> walker helper functions and set DBM|RDONLY bit, thus > >> switching the IOPTE to writeable-clean. > > > > this should not be one-off if the operation needs to be > > applied to IOPTE. Say a map request comes right after > > set_dirty_tracking() is called. If it's agreed to remove > > the range op then smmu driver should record the tracking > > status internally and then apply the modifier to all the new > > mappings automatically before dirty tracking is disabled. > > Otherwise the same logic needs to be kept in iommufd to > > call set_dirty_tracking_range() explicitly for every new > > iopt_area created within the tracking window. > > Gah, I totally missed that by mistake. New mappings aren't > carrying over the "DBM is set". This needs a new io-pgtable > quirk added post dirty-tracking toggling. > > I can adjust, but I am at odds on including this in a future > iteration given that I can't really test any of this stuff. > Might drop the driver until I have hardware/emulation I can > use (or maybe others can take over this). It was included > for revising the iommu core ops and whether iommufd was > affected by it. [+Kunkun Jiang]. I think he is now looking into this and might have a test setup to verify this. Thanks, Shameer _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu