From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFAAC433E1 for ; Mon, 18 May 2020 23:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B75C2081A for ; Mon, 18 May 2020 23:05:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=novek.ru header.i=@novek.ru header.b="qSW0lwsk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728582AbgERXFm (ORCPT ); Mon, 18 May 2020 19:05:42 -0400 Received: from novek.ru ([213.148.174.62]:50826 "EHLO novek.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727067AbgERXFm (ORCPT ); Mon, 18 May 2020 19:05:42 -0400 Received: from [10.0.1.119] (unknown [62.76.204.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by novek.ru (Postfix) with ESMTPSA id C0A6B5020BC; Tue, 19 May 2020 02:05:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 novek.ru C0A6B5020BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=novek.ru; s=mail; t=1589843139; bh=sXrnJoqGvZtS/u8svJdsytuRkL+f1Auteww9XkOUGBw=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From; b=qSW0lwskB2bYRHL66PbrmhLhxfbx99jxp550JRfBQFedoV1K6Cw/EZUiPayii9K8M mBphfVNBmbmxej/txx/3JP4tMGa1QNqlTFCaiHo8xBcHGomIDWW1KgVsf1nBQdmyxJ WjA4TvLJoDUA5FaeVjcUY4xFPtftHSCxic0YV9wg= Subject: Re: [PATCH] net/tls: fix encryption error checking To: Jakub Kicinski References: <20200517014451.954F05026DE@novek.ru> <20200518153005.577dfe99@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Cc: Boris Pismenny , Aviad Yehezkel , Daniel Borkmann , Linux Kernel Network Developers From: Vadim Fedorenko Message-ID: Date: Tue, 19 May 2020 02:05:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 19.05.2020 01:30, Jakub Kicinski wrote: > > tls_push_record can return -EAGAIN because of tcp layer. In that > > case open_rec is already in the tx_record list and should not be > > freed. > > Also the record size can be more than the size requested to write > > in tls_sw_do_sendpage(). That leads to overflow of copied variable > > and wrong return code. > > > > Fixes: d10523d0b3d7 ("net/tls: free the record on encryption error") > > Signed-off-by: Vadim Fedorenko > > Doesn't this return -EAGAIN back to user space? Meaning even tho we > queued the user space will try to send it again? Before patch it was sending negative value back to user space. After patch it sends the amount of data encrypted in last call. It is checked by:  return (copied > 0) ? copied : ret; and returns -EAGAIN only if data is not sent to open record.