From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932816AbdJaU5l (ORCPT ); Tue, 31 Oct 2017 16:57:41 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:45950 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803AbdJaU5j (ORCPT ); Tue, 31 Oct 2017 16:57:39 -0400 Subject: Re: [PATCH v2 04/17] PCI: designware-ep: Pre-allocate memory for MSI in dw_pcie_ep_init To: Kishon Vijay Abraham I , Jingoo Han , Joao Pinto , Bjorn Helgaas CC: , References: <20171030124221.20690-1-niklas.cassel@axis.com> <20171030124221.20690-5-niklas.cassel@axis.com> <9d4c17b7-94ec-fd79-4bd8-8165019f04ce@ti.com> From: Niklas Cassel Message-ID: Date: Tue, 31 Oct 2017 21:57:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <9d4c17b7-94ec-fd79-4bd8-8165019f04ce@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX03.axis.com (10.0.5.17) To XBOX02.axis.com (10.0.5.16) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2017 07:01 AM, Kishon Vijay Abraham I wrote: > Hi Niklas, > > On Monday 30 October 2017 06:12 PM, Niklas Cassel wrote: >> Certain SoCs need to map the MSI address in raise_irq. >> To map an address, you first need to call pci_epc_mem_alloc_addr, >> however, pci_epc_mem_alloc_addr calls ioremap (which can sleep). >> >> Since raise_irq is only called from atomic context, we can't call >> pci_epc_mem_alloc_addr from raise_irq, instead we pre-allocate >> a page in dw_pcie_ep_init, so this page can later be used to map/unmap >> the MSI address in raise_irq. >> >> Signed-off-by: Niklas Cassel >> --- >> V2: >> * No change. >> >> drivers/pci/dwc/pcie-designware-ep.c | 8 ++++++++ >> drivers/pci/dwc/pcie-designware.h | 2 ++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c >> index 3fb34be99715..c291da2a10ba 100644 >> --- a/drivers/pci/dwc/pcie-designware-ep.c >> +++ b/drivers/pci/dwc/pcie-designware-ep.c >> @@ -286,6 +286,8 @@ void dw_pcie_ep_exit(struct dw_pcie_ep *ep) >> { >> struct pci_epc *epc = ep->epc; >> >> + pci_epc_mem_free_addr(epc, ep->msi_mem_phys, ep->msi_mem, PAGE_SIZE); >> + >> pci_epc_mem_exit(epc); >> } >> >> @@ -341,6 +343,12 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep) >> return ret; >> } >> >> + ep->msi_mem = pci_epc_mem_alloc_addr(epc, &ep->msi_mem_phys, PAGE_SIZE); > > ep->page_size instead of PAGE_SIZE? Hello Kishon, Sure thing, will fix in V3. Regards, Niklas