From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D4306D14 for ; Wed, 14 Apr 2021 09:25:07 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id d21so2720715edv.9 for ; Wed, 14 Apr 2021 02:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gHbX9CNZcLaiMHXNZmBKODRDqd/reEdwnJR9AYcgnvs=; b=gINN1R9lI5tCoYH2ZPewi+utvLw1oNr+AYOfDMNtw/hKaSHIjWFrbHQ2mEP/s050tD g448CE9NUc6LD5cIHE915wtYMuh12ELdt/BZzVJtfcbRlcZzDt0CH8Ve04xqPwET4Rh5 BHdMYM5h1f/E2uWaCn6cX9rtXlGY2VM249gpU+JczEOZGYRnqBdk5vjJ2O5+ToJ3ERbh U3FM3+/YLy3sEwiHrE30IVFtoFTTLn4R1GTNSu4oQJjn/xhueIXu1t9NC5c0QjPFa4VI mHQlWeb7xSouf3EcOgTxrw7wUrUZIGalS4Ba2F808A+YtDSZwP171zeWniTOjTgCp8d7 ejDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gHbX9CNZcLaiMHXNZmBKODRDqd/reEdwnJR9AYcgnvs=; b=ag6GbrQbvy31N9cuvHxnbGNcvwN5ykGGWQEaMQxobSB9sJusfm8/BR5wu9fwdkRopB Ploj21lczkNpbxDt5QCoz02zPU+m8ES9RLu5Rsh8/Ll0SuunnnKJrJdiH4CGrQVAzZSS Vux9pAhRxzWf4/R+n4LTP3BD45455btVbZxymodHCjoMKEXBFkeWVPzKUlqc5jUtsJwh uiNXwNtbbuDFIw/EfbcVcbTzmnkXoNWjT9Jm2ichRn5GFBHMtYAv1AERu5q9Q9I/5chE INKYtMYFFOH/L00x2dAYyHKj+NY8YrgBiYPllMlIWVJmd+sQpa6aD84ySHC7UZCy9/VR jJtw== X-Gm-Message-State: AOAM533pV7zpfA+Eg4GUX/ws6vxoUD4+Ismk0qY+0+yS0l0+057DJvT2 XE0dTRBlQJjNqkcoUa1Uihf1MIOXIJuLhQ== X-Google-Smtp-Source: ABdhPJwKI3fyWANihaNxRNJcYcXaOIyeXGZHEp2xOggKD3L098p3onGrqOxzTlf7HKaohGrVesV2FQ== X-Received: by 2002:aa7:c907:: with SMTP id b7mr40534459edt.37.1618392305540; Wed, 14 Apr 2021 02:25:05 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:bfbf:e0a9:a746:c4b9]) by smtp.gmail.com with ESMTPSA id t14sm9473304ejc.121.2021.04.14.02.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 02:25:05 -0700 (PDT) To: Nico Pache , linux-kernel@vger.kernel.org Cc: brendanhiggins@google.com, gregkh@linuxfoundation.org, linux-ext4@vger.kernel.org, netdev@vger.kernel.org, rafael@kernel.org, linux-m68k@lists.linux-m68k.org, geert@linux-m68k.org, tytso@mit.edu, mathew.j.martineau@linux.intel.com, davem@davemloft.net, broonie@kernel.org, davidgow@google.com, skhan@linuxfoundation.org, mptcp@lists.linux.dev References: <0fa191715b236766ad13c5f786d8daf92a9a0cf2.1618388989.git.npache@redhat.com> From: Matthieu Baerts Subject: Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard Message-ID: Date: Wed, 14 Apr 2021 11:25:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <0fa191715b236766ad13c5f786d8daf92a9a0cf2.1618388989.git.npache@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Nico, On 14/04/2021 10:58, Nico Pache wrote: > Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the > KUNIT *_KUNIT_TEST config name format. For MPTCP, we have multiple KUnit tests: crypto and token. That's why we wrote TESTS with a S. I'm fine without S if we need to stick with KUnit' standard. But maybe the standard wants us to split the two tests and create MPTCP_TOKEN_KUNIT_TEST and MPTCP_TOKEN_KUNIT_TEST config? In this case, we could eventually keep MPTCP_KUNIT_TESTS which will in charge of selecting the two new ones. Up to the KUnit maintainers to decide ;-) Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net