All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: 1830872@bugs.launchpad.net, Richard Henderson <rth@twiddle.net>,
	qemu-arm@nongnu.org, randrianasulu@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load
Date: Mon, 3 Jun 2019 17:01:55 -0500	[thread overview]
Message-ID: <e27d836b-883e-4cfd-69be-8977cc71d809@linaro.org> (raw)
In-Reply-To: <20190603150120.29255-1-alex.bennee@linaro.org>

On 6/3/19 10:01 AM, Alex Bennée wrote:
> When running on 32 bit TCG backends a wide unaligned load ends up
> truncating data before returning to the guest. We specifically have
> the return type as uint64_t to avoid any premature truncation so we
> should use the same for the interim types.
> 
> Hopefully fixes #1830872
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  accel/tcg/cputlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  parent reply	other threads:[~2019-06-03 22:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  9:13 [Qemu-devel] [Bug 1830872] [NEW] AARCH64 to ARMv7 mistranslation in TCG Laszlo Ersek (Red Hat)
2019-05-29 12:08 ` [Qemu-devel] [Bug 1830872] " Philippe Mathieu-Daudé
2019-06-02 10:19 ` Laszlo Ersek (Red Hat)
2019-06-02 13:30   ` Alex Bennée
2019-06-02 13:30     ` Alex Bennée
2019-06-03 11:56     ` Alex Bennée
2019-06-03 11:56       ` Alex Bennée
2019-06-02 14:54 ` Alex Bennée
2019-06-03 15:01 ` [Qemu-devel] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load Alex Bennée
2019-06-03 15:01   ` [Qemu-devel] [Bug 1830872] " Alex Bennée
2019-06-03 15:35   ` [Qemu-devel] " Andrew Randrianasulu
2019-06-03 15:35     ` [Qemu-devel] [Bug 1830872] " Andrew Randrianasulu
2019-06-04  9:43     ` [Qemu-devel] " Alex Bennée
2019-06-04  9:43       ` [Qemu-devel] [Bug 1830872] " Alex Bennée
2019-06-03 18:29   ` Laszlo Ersek (Red Hat)
2019-06-03 18:29     ` [Qemu-devel] " Laszlo Ersek
2019-06-03 22:01   ` Richard Henderson [this message]
2019-06-04  6:52   ` Philippe Mathieu-Daudé
2019-06-04 11:42   ` Igor Mammedov
2019-06-04 11:42     ` [Qemu-devel] [Bug 1830872] " Igor
2019-06-03 15:27 ` [Qemu-devel] [Bug 1830872] Re: AARCH64 to ARMv7 mistranslation in TCG Laszlo Ersek (Red Hat)
2019-06-03 15:45 ` Laszlo Ersek (Red Hat)
2019-06-03 15:51 ` Alex Bennée
2019-06-03 16:53   ` Andrew Randrianasulu
2019-06-03 17:03 ` Andrew Randrianasulu
2019-06-17 18:21 ` Alex Bennée
2019-08-16  5:04 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e27d836b-883e-4cfd-69be-8977cc71d809@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=1830872@bugs.launchpad.net \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=randrianasulu@gmail.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.