From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbdF0KIH (ORCPT ); Tue, 27 Jun 2017 06:08:07 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:58817 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbdF0KIA (ORCPT ); Tue, 27 Jun 2017 06:08:00 -0400 Subject: Re: [Nouveau] [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds To: Colin King , Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org References: <20170627080858.12218-1-colin.king@canonical.com> From: Martin Peres Message-ID: Date: Tue, 27 Jun 2017 13:07:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170627080858.12218-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/17 11:08, Colin King wrote: > From: Colin Ian King > > Array thresolds should be named thresholds, rename it. Also make it static > static const char * const > > Signed-off-by: Colin Ian King Thanks for doing this, Reviewed-by: Martin Peres > --- > drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c > index e93b2410c38b..6449771b9dc6 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c > @@ -83,7 +83,7 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs, > { > struct nvkm_subdev *subdev = &therm->subdev; > bool active; > - const char *thresolds[] = { > + static const char * const thresholds[] = { > "fanboost", "downclock", "critical", "shutdown" > }; > int temperature = therm->func->temp_get(therm); > @@ -94,10 +94,10 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs, > if (dir == NVKM_THERM_THRS_FALLING) > nvkm_info(subdev, > "temperature (%i C) went below the '%s' threshold\n", > - temperature, thresolds[thrs]); > + temperature, thresholds[thrs]); > else > nvkm_info(subdev, "temperature (%i C) hit the '%s' threshold\n", > - temperature, thresolds[thrs]); > + temperature, thresholds[thrs]); > > active = (dir == NVKM_THERM_THRS_RISING); > switch (thrs) { > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: [Nouveau] [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds Date: Tue, 27 Jun 2017 13:07:45 +0300 Message-ID: References: <20170627080858.12218-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170627080858.12218-1-colin.king@canonical.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Colin King , Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: nouveau.vger.kernel.org T24gMjcvMDYvMTcgMTE6MDgsIENvbGluIEtpbmcgd3JvdGU6Cj4gRnJvbTogQ29saW4gSWFuIEtp bmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPiAKPiBBcnJheSB0aHJlc29sZHMgc2hvdWxk IGJlIG5hbWVkIHRocmVzaG9sZHMsIHJlbmFtZSBpdC4gQWxzbyBtYWtlIGl0IHN0YXRpYwo+IHN0 YXRpYyBjb25zdCBjaGFyICogY29uc3QKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2lu ZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgoKVGhhbmtzIGZvciBkb2luZyB0aGlzLAoKUmV2 aWV3ZWQtYnk6IE1hcnRpbiBQZXJlcyA8bWFydGluLnBlcmVzQGZyZWUuZnI+Cgo+IC0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbnZrbS9zdWJkZXYvdGhlcm0vdGVtcC5jIHwgNiArKyst LS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L3RoZXJt L3RlbXAuYyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L3RoZXJtL3RlbXAu Ywo+IGluZGV4IGU5M2IyNDEwYzM4Yi4uNjQ0OTc3MWI5ZGM2IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L3RoZXJtL3RlbXAuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9ub3V2ZWF1L252a20vc3ViZGV2L3RoZXJtL3RlbXAuYwo+IEBAIC04Myw3ICs4 Myw3IEBAIG52a21fdGhlcm1fc2Vuc29yX2V2ZW50KHN0cnVjdCBudmttX3RoZXJtICp0aGVybSwg ZW51bSBudmttX3RoZXJtX3RocnMgdGhycywKPiAgIHsKPiAgIAlzdHJ1Y3QgbnZrbV9zdWJkZXYg KnN1YmRldiA9ICZ0aGVybS0+c3ViZGV2Owo+ICAgCWJvb2wgYWN0aXZlOwo+IC0JY29uc3QgY2hh ciAqdGhyZXNvbGRzW10gPSB7Cj4gKwlzdGF0aWMgY29uc3QgY2hhciAqIGNvbnN0IHRocmVzaG9s ZHNbXSA9IHsKPiAgIAkJImZhbmJvb3N0IiwgImRvd25jbG9jayIsICJjcml0aWNhbCIsICJzaHV0 ZG93biIKPiAgIAl9Owo+ICAgCWludCB0ZW1wZXJhdHVyZSA9IHRoZXJtLT5mdW5jLT50ZW1wX2dl dCh0aGVybSk7Cj4gQEAgLTk0LDEwICs5NCwxMCBAQCBudmttX3RoZXJtX3NlbnNvcl9ldmVudChz dHJ1Y3QgbnZrbV90aGVybSAqdGhlcm0sIGVudW0gbnZrbV90aGVybV90aHJzIHRocnMsCj4gICAJ aWYgKGRpciA9PSBOVktNX1RIRVJNX1RIUlNfRkFMTElORykKPiAgIAkJbnZrbV9pbmZvKHN1YmRl diwKPiAgIAkJCSAgInRlbXBlcmF0dXJlICglaSBDKSB3ZW50IGJlbG93IHRoZSAnJXMnIHRocmVz aG9sZFxuIiwKPiAtCQkJICB0ZW1wZXJhdHVyZSwgdGhyZXNvbGRzW3RocnNdKTsKPiArCQkJICB0 ZW1wZXJhdHVyZSwgdGhyZXNob2xkc1t0aHJzXSk7Cj4gICAJZWxzZQo+ICAgCQludmttX2luZm8o c3ViZGV2LCAidGVtcGVyYXR1cmUgKCVpIEMpIGhpdCB0aGUgJyVzJyB0aHJlc2hvbGRcbiIsCj4g LQkJCSAgdGVtcGVyYXR1cmUsIHRocmVzb2xkc1t0aHJzXSk7Cj4gKwkJCSAgdGVtcGVyYXR1cmUs IHRocmVzaG9sZHNbdGhyc10pOwo+ICAgCj4gICAJYWN0aXZlID0gKGRpciA9PSBOVktNX1RIRVJN X1RIUlNfUklTSU5HKTsKPiAgIAlzd2l0Y2ggKHRocnMpIHsKPiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=