From: Jan Beulich <jbeulich@suse.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
"julien@xen.org" <julien@xen.org>, "wl@xen.org" <wl@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v4 1/2] xen: EXPERT clean-up and introduce UNSUPPORTED
Date: Tue, 26 Jan 2021 16:23:40 +0100 [thread overview]
Message-ID: <e2985686-2e6a-11c1-d46c-894a167266ab@suse.com> (raw)
In-Reply-To: <24592.5760.197643.853055@mariner.uk.xensource.com>
On 26.01.2021 14:17, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH v4 1/2] xen: EXPERT clean-up and introduce UNSUPPORTED"):
>> On 26.01.2021 12:17, Bertrand Marquis wrote:
>>> Maybe something we could explain more clearly in the UNSUPPORTED/EXPERT
>>> config parameters instead ?
>>> We could also make that more clear in the help of such parameters directly.
>>>
>>> I do not see how we could make that more clear directly in the prompt (as
>>> making it too long is not a good solution).
>>
>> My main request is that such tags be added only if there's
>> absolutely no ambiguity. Anything else (requiring longer
>> explanations in many cases) should be expressed in the help
>> text of the option, or in yet other ways (a referral to
>> SUPPORT.md comes to mind).
>
> Is
>
>>>>>> + bool "Harden the branch predictor against aliasing attacks (disabling UNSUPPORTED)" if UNSUPPORTED
>
> too long ?
One more consideration, beyond the "too long" aspect. To me (as a
non-native speaker) this wording might allow inferring (by people
not knowing kconfig sufficiently well) that selecting this option
will turn off UNSUPPORTED. IOW if anything I'd see us use the yet
slightly longer "... (UNSUPPORTED if disabled)" or some such.
Jan
next prev parent reply other threads:[~2021-01-26 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 21:27 [PATCH v4 0/2] introduce UNSUPPORTED Stefano Stabellini
2021-01-25 21:27 ` [PATCH v4 1/2] xen: EXPERT clean-up and " Stefano Stabellini
2021-01-26 9:22 ` Jan Beulich
2021-01-26 11:06 ` Bertrand Marquis
2021-01-26 11:11 ` Jan Beulich
2021-01-26 11:17 ` Bertrand Marquis
2021-01-26 13:08 ` Jan Beulich
2021-01-26 13:17 ` Ian Jackson
2021-01-26 13:19 ` Jan Beulich
2021-01-26 13:20 ` Bertrand Marquis
2021-01-26 15:18 ` Marek Marczykowski-Górecki
2021-01-26 15:23 ` Jan Beulich [this message]
2021-01-26 18:28 ` Stefano Stabellini
2021-01-26 13:51 ` Julien Grall
2021-01-26 14:23 ` Bertrand Marquis
2021-01-26 18:26 ` Stefano Stabellini
2021-01-25 21:27 ` [PATCH v4 2/2] xen: add (EXPERT) to one-line descriptions when appropriate Stefano Stabellini
2021-01-26 9:26 ` Jan Beulich
2021-01-26 18:36 ` Stefano Stabellini
2021-01-26 11:08 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2985686-2e6a-11c1-d46c-894a167266ab@suse.com \
--to=jbeulich@suse.com \
--cc=Bertrand.Marquis@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.