From: Johannes Berg <johannes@sipsolutions.net>
To: anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org
Cc: richard@nod.at
Subject: Re: [PATCHv3 4/5] um: Fix off by one error in IRQ enumeration
Date: Tue, 30 Jul 2019 08:56:53 +0200 [thread overview]
Message-ID: <e29f4e44ac9d671521287d492b96cb8e5295b424.camel@sipsolutions.net> (raw)
In-Reply-To: <20190722073025.20844-4-anton.ivanov@cambridgegreys.com>
On Mon, 2019-07-22 at 08:30 +0100, anton.ivanov@cambridgegreys.com
wrote:
> From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
>
> Fix an off-by-one in IRQ enumeration
>
> Reported by: Dana Johnson <djohns042@gmail.com>
nit: "Reported-by"
> -#define LAST_IRQ (VECTOR_IRQ_SPACE + VECTOR_BASE_IRQ)
> +#define LAST_IRQ (VECTOR_IRQ_SPACE + VECTOR_BASE_IRQ - 1)
Somebody internally at my group just made the same patch, but came to
the cnoclusion that we also need, in arch/um/kernel/irq.c:
- for (i = 1; i < LAST_IRQ; i++)
+ for (i = 1; i <= LAST_IRQ; i++)
in init_IRQ()?
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2019-07-30 6:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 7:30 [PATCHv3 1/5] um: Add legacy tap support and rename existing vector to hybrid anton.ivanov
2019-07-22 7:30 ` [PATCHv3 2/5] um: Added support for unix socket transports and bess transport anton.ivanov
2019-07-22 7:30 ` [PATCHv3 3/5] um: Add checks to mtu parameter parsing anton.ivanov
2019-07-22 7:30 ` [PATCHv3 4/5] um: Fix off by one error in IRQ enumeration anton.ivanov
2019-07-30 6:56 ` Johannes Berg [this message]
2019-07-22 7:30 ` [PATCHv3 5/5] um: Error handling fixes in vector drivers anton.ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29f4e44ac9d671521287d492b96cb8e5295b424.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.