From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB065C63793 for ; Thu, 22 Jul 2021 12:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C461D61248 for ; Thu, 22 Jul 2021 12:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231896AbhGVL7S (ORCPT ); Thu, 22 Jul 2021 07:59:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39457 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231772AbhGVL7R (ORCPT ); Thu, 22 Jul 2021 07:59:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626957592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ykv5wmLf4ZccwydelwmDaJ14hxc/5bcYf6Q0csIyjtg=; b=XS4UeyA7eBuMs3aNP9cIB0HJBkeQVAJyIQOV0qJawmFEVkZftJkQrASRozX8nYblDMN5AS ts0f47rpPRTwWFJQsbnp/aPY0GYnrYcs3jNn2bhiKt6OE8Z2+JnYV9CLoW80NKdJ/tdBds E4gnK2SxT8p5QN8W/E9WmteNlTrUuxc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-d918l_wTNZmGfLz9gz7SAg-1; Thu, 22 Jul 2021 08:39:51 -0400 X-MC-Unique: d918l_wTNZmGfLz9gz7SAg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 762D28B0600; Thu, 22 Jul 2021 12:39:49 +0000 (UTC) Received: from starship (unknown [10.40.192.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB3425C1C2; Thu, 22 Jul 2021 12:39:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH] KVM: x86: Check the right feature bit for MSR_KVM_ASYNC_PF_ACK access From: Maxim Levitsky To: Vitaly Kuznetsov , kvm@vger.kernel.org, Paolo Bonzini Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Oliver Upton , linux-kernel@vger.kernel.org Date: Thu, 22 Jul 2021 15:39:45 +0300 In-Reply-To: <20210722123018.260035-1-vkuznets@redhat.com> References: <20210722123018.260035-1-vkuznets@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-07-22 at 14:30 +0200, Vitaly Kuznetsov wrote: > MSR_KVM_ASYNC_PF_ACK MSR is part of interrupt based asynchronous page fault > interface and not the original (deprecated) KVM_FEATURE_ASYNC_PF. This is > stated in Documentation/virt/kvm/msr.rst. > > Fixes: 66570e966dd9 ("kvm: x86: only provide PV features if enabled in guest's CPUID") > Signed-off-by: Vitaly Kuznetsov > --- > arch/x86/kvm/x86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index d715ae9f9108..88ff7a1af198 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3406,7 +3406,7 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > return 1; > break; > case MSR_KVM_ASYNC_PF_ACK: > - if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF)) > + if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF_INT)) > return 1; > if (data & 0x1) { > vcpu->arch.apf.pageready_pending = false; > @@ -3745,7 +3745,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > msr_info->data = vcpu->arch.apf.msr_int_val; > break; > case MSR_KVM_ASYNC_PF_ACK: > - if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF)) > + if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF_INT)) > return 1; > > msr_info->data = 0; Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky