From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E294C2D0A3 for ; Tue, 3 Nov 2020 14:33:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD1FE22370 for ; Tue, 3 Nov 2020 14:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NitgGtq9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD1FE22370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZxNO-0002Rh-Ut for qemu-devel@archiver.kernel.org; Tue, 03 Nov 2020 09:33:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZxIL-0005Uz-31 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 09:28:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZxIH-0004A3-TJ for qemu-devel@nongnu.org; Tue, 03 Nov 2020 09:28:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604413696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UyId2X/pL5QnqyqpHKMEag2lKQ0RsBKsw1kZgPmpKL0=; b=NitgGtq90+gF7wgm70WUNRVwg8mRX8qrjhMedqqLKpXAKIKymL4MrkaWvhdthbnZB20+aT sUypwvIIBug3CSnxtALwdLICwryKHuYQjt6YrwxD3HZUABQERRnJe9UjjWeLf5CV1Hwj6B eeTDH1E4MJw1KIgzYUHVstgt0/HhL6Q= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-PymYP3xUM6yCAPXB-Nsy_Q-1; Tue, 03 Nov 2020 09:28:15 -0500 X-MC-Unique: PymYP3xUM6yCAPXB-Nsy_Q-1 Received: by mail-wm1-f72.google.com with SMTP id y26so340457wmj.7 for ; Tue, 03 Nov 2020 06:28:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UyId2X/pL5QnqyqpHKMEag2lKQ0RsBKsw1kZgPmpKL0=; b=BJ7QXBByis/PmtYBEEi3K9PUmoZ5m1isBt/13zgOEGgWR7X4lg3Y929gNIfUuKvwwh mfhyJ46pCGILMS6dCdFYpRvOezuiQIj8o2uULTMN4dg53DDUG7BmtRg7lMP0vYcs/CWH 6ThbTy9ojU4EFU2mK9FWjgabe7bqFMDqthIkngtw9X0dcrFsI/nw9kOzxfRthawRm9ni Fbofl1I/1VdohgdoOp35OybAI6kcMRsL7zdMKsyZz7OlQNK7BEYzINVTl24owX0crjc9 CPI15hpqicSTx/pVXCq3f2j7cUh5pJ3J/AX0nuOT7nsOV1lnOE7wQ1Cn2A2Me2fHONt3 R/5w== X-Gm-Message-State: AOAM5312dMm2b2PZ1z25XPu88qnJqA/vXHJiJ/+pCaKqg9hKToGiR1pe tySe+UznZxlpD10TCW0t1XOlNItE2SeSEC/umavsinP/0B3O4n1GvjFUFC8zDvEavUPbdvO9CJD sg+m+wPpIVt3YRGA= X-Received: by 2002:a5d:5387:: with SMTP id d7mr26217457wrv.224.1604413694012; Tue, 03 Nov 2020 06:28:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfsJxm6GFa7Reif3wdVI9pBhLp8oM7vPFkBxNIGQ01AQXtbPSDi3cXNbiYxDfe91BGdyCTJA== X-Received: by 2002:a5d:5387:: with SMTP id d7mr26217442wrv.224.1604413693783; Tue, 03 Nov 2020 06:28:13 -0800 (PST) Received: from [192.168.1.36] (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id 130sm3416121wmd.18.2020.11.03.06.28.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2020 06:28:13 -0800 (PST) Subject: Re: [PATCH-for-5.2 0/4] misc: Trivial format string fixes To: Dov Murik , qemu-devel@nongnu.org References: <20201103112558.2554390-1-philmd@redhat.com> <64132d34-dbd9-03ee-6f11-a6908df025bf@linux.vnet.ibm.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 3 Nov 2020 15:28:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , "Dr. David Alan Gilbert" , qemu-ppc@nongnu.org, Gerd Hoffmann , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/3/20 3:03 PM, Dov Murik wrote: > > On 03/11/2020 15:58, Dov Murik wrote: >> On 03/11/2020 13:25, Philippe Mathieu-Daudé wrote: >>> IIUC qemu-trivial@ doesn't queue patches during freeze, >>> >>> so it might be easier if patches are queued by respective >>> >>> subsystem maintainers. >>> >>> >>> >>> Philippe Mathieu-Daudé (4): >>> >>>    hw/display/cirrus_vga: Remove debugging code commented out >>> >>>    hw/display/cirrus_vga: Fix hexadecimal format string specifier >>> >>>    hw/ppc/spapr_tpm_proxy: Fix hexadecimal format string specifier >>> >>>    migration/ram: Fix hexadecimal format string specifier >>> >>> >>> >>>   hw/display/cirrus_vga.c | 20 +------------------- >>> >>>   migration/ram.c         |  2 +- >>> >>>   hw/ppc/trace-events     |  2 +- >>> >>>   3 files changed, 3 insertions(+), 21 deletions(-) >>> >>> >>> >> >> >> There's at least one more easy fix: >> >> hw/misc/trace-events:106:mos6522_get_next_irq_time(uint16_t latch, >> int64_t d, int64_t delta) "latch=%d counter=0x%"PRId64 " >> delta_next=0x%"PRId64 Indeed. >> >> but I have no idea how to test this. >> >> -Dov >> > > ... and one more in hw/usb/u2f-passthru.c:348 : > >         error_report("%s: Bad written size (req 0x%zu, val 0x%zd)", >                      TYPE_U2F_PASSTHRU, sizeof(host_packet), written); 'written' is signed, so this format looks correct... > > Again, I have no idea how to test/trigger these areas in the code. > > -Dov >