From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 01/10] x86/sysctl: Don't return cpu policy data for compiled-out support (2)
Date: Thu, 27 Feb 2020 16:24:22 +0000 [thread overview]
Message-ID: <e2b0458b-5271-b7cf-1d4f-08256aee6aed@citrix.com> (raw)
In-Reply-To: <e4bbd588-559d-1392-7253-8b512c7a2aef@suse.com>
On 27/02/2020 09:40, Jan Beulich wrote:
> On 27.02.2020 10:33, Andrew Cooper wrote:
>> On 27/02/2020 07:38, Jan Beulich wrote:
>>> On 26.02.2020 21:22, Andrew Cooper wrote:
>>>> Just as with c/s 96dc77b4b1 for XEN_SYSCTL_get_cpu_policy,
>>>> XEN_SYSCTL_get_cpu_featureset needs to become conditional.
>>>>
>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Albeit I'd say "want", not "needs" in the description.
>> It occurs to me that XEN_SYSCTL_get_cpu_featureset is strictly a subset
>> of XEN_SYSCTL_get_cpu_policy, and that now I've adjusted the toolstack
>> onto get_cpu_policy, the sole remaining user is xen-cpuid.
>>
>> get_cpu_policy already has separate default and max indices, whereas
>> get_cpu_featureset was written before the need for this has become obvious.
>>
>> This leads to an asymmetry in xen-cpuid, where the -p (policy) option
>> provides two more sets of information than the featureset listing.
>>
>> Instead, I think I'd like to drop XEN_SYSCTL_get_cpu_featureset and
>> update the sole user to the more complete interface.
> Sounds like a good move to me.
Actually, after having spent almost a day trying to disentangle the
remains of this, I'm going to leave it for now.
It turns out it is still used by the legacy CPUID logic, and I could do
with getting a few other pieces of infrastructure before it is easy to
take out.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-27 16:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 20:22 [Xen-devel] [PATCH 00/10] x86: Default vs Max policies Andrew Cooper
2020-02-26 20:22 ` [Xen-devel] [PATCH 01/10] x86/sysctl: Don't return cpu policy data for compiled-out support (2) Andrew Cooper
2020-02-27 7:38 ` Jan Beulich
2020-02-27 9:33 ` Andrew Cooper
2020-02-27 9:40 ` Jan Beulich
2020-02-27 16:24 ` Andrew Cooper [this message]
2020-02-26 20:22 ` [Xen-devel] [PATCH 02/10] tools/libxc: Simplify xc_get_static_cpu_featuremask() Andrew Cooper
2020-02-27 7:47 ` Jan Beulich
2020-02-27 9:55 ` Andrew Cooper
2020-02-27 16:27 ` Andrew Cooper
2020-02-26 20:22 ` [Xen-devel] [PATCH 03/10] x86/gen-cpuid: Rework internal logic to ease future changes Andrew Cooper
2020-02-27 7:57 ` Jan Beulich
2020-02-27 10:08 ` Andrew Cooper
2020-02-26 20:22 ` [Xen-devel] [PATCH 04/10] x86/gen-cpuid: Create max and default variations of INIT_*_FEATURES Andrew Cooper
2020-02-27 8:02 ` Jan Beulich
2020-02-27 10:29 ` Andrew Cooper
2020-02-27 10:34 ` Jan Beulich
2020-02-26 20:22 ` [Xen-devel] [PATCH 05/10] x86/msr: Compile out unused logic/objects Andrew Cooper
2020-02-27 8:07 ` Jan Beulich
2020-02-27 10:37 ` Andrew Cooper
2020-02-27 11:24 ` Jan Beulich
2020-02-26 20:22 ` [Xen-devel] [PATCH 06/10] x86/msr: Introduce and use default MSR policies Andrew Cooper
2020-02-27 8:11 ` Jan Beulich
2020-02-26 20:22 ` [Xen-devel] [PATCH 07/10] x86/cpuid: Compile out unused logic/objects Andrew Cooper
2020-02-27 8:12 ` Jan Beulich
2020-02-26 20:22 ` [Xen-devel] [PATCH 08/10] x86/cpuid: Introduce and use default CPUID policies Andrew Cooper
2020-02-27 8:19 ` Jan Beulich
2020-02-27 10:55 ` Andrew Cooper
2020-02-27 11:29 ` Jan Beulich
2020-02-26 20:22 ` [Xen-devel] [PATCH 09/10] x86/gen-cpuid: Distinguish default vs max in feature annotations Andrew Cooper
2020-02-27 8:21 ` Jan Beulich
2020-02-26 20:22 ` [Xen-devel] [PATCH 10/10] x86/hvm: Do not enable MPX by default Andrew Cooper
2020-02-27 8:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b0458b-5271-b7cf-1d4f-08256aee6aed@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.