From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] eal: restrict ctrl threads to startup cpu affinity Date: Thu, 14 Feb 2019 09:39:44 +0000 Message-ID: References: <1550074412-31285-1-git-send-email-david.marchand@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, ktraynor@redhat.com, stable@dpdk.org To: David Marchand , dev@dpdk.org Return-path: In-Reply-To: <1550074412-31285-1-git-send-email-david.marchand@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13-Feb-19 4:13 PM, David Marchand wrote: > Spawning the ctrl threads on anything that is not part of the eal > coremask is not that polite to the rest of the system. > > Rather than introduce yet another eal options for this, let's take > the startup cpu affinity as a reference and remove the eal coremask > from it. > If no cpu is left, then we default to the master core. > > The cpuset is computed once at init before the original cpu affinity. > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > Signed-off-by: David Marchand > --- Hi David, Maybe i didn't have enough coffee today and i'm missing something here, but how is this different? Removing the coremask cores from the cpuset will effectively "spawn the ctrl threads on anything that is not part of the EAL coremask" (which is "not that polite to the rest of the system"), unless the application was run with taskset. Is "taskset" the key point here? I.e. by default, we're still "not polite", unless the user asks nicely? :) -- Thanks, Anatoly