Re: [PATCH v2] mtd: spi-nor-ids: add winbond w25q512nw family support

From: "Cédric Le Goater" <clg@kaod.org>
To: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Vignesh R <vigneshr@ti.com>
Cc: Jamie Iles <quic_jiles@quicinc.com>,
	Graeme Gregory <quic_ggregory@quicinc.com>,
	<u-boot@lists.denx.de>
Subject: Re: [PATCH v2] mtd: spi-nor-ids: add winbond w25q512nw family support
Date: Sat, 9 Jul 2022 08:03:12 +0200	[thread overview]
Message-ID: <e2cb80e8-4e12-a81e-ec13-482d009b3c88@kaod.org> (raw)
In-Reply-To: <20220708190319.2730480-1-quic_jaehyoo@quicinc.com>

On 7/8/22 21:03, Jae Hyun Yoo wrote:
> Add Winbond w25q512nwq/n and w25q512nwm support.
> 
> datasheet:
> https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf
> 
> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

> ---
> Changes in v2:
> * Changed name from w25q512nwiq and w25q512nwim to w25q512nwq and w25q512nwm
>    respectively to make them sync with linux code.

Thanks,

C.

> 
>   drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 7050ddc39716..91a3f983a5fa 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -362,6 +362,16 @@ const struct flash_info spi_nor_ids[] = {
>   			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>   			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>   	},
> +	{
> +		INFO("w25q512nwq", 0xef6020, 0, 64 * 1024, 1024,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},
> +	{
> +		INFO("w25q512nwm", 0xef8020, 0, 64 * 1024, 1024,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},
>   	{
>   		INFO("w25q01jv", 0xef4021, 0, 64 * 1024, 2048,
>   			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |