From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkyw8-0004dV-FN for qemu-devel@nongnu.org; Fri, 16 Sep 2016 15:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkyw3-0004fS-EB for qemu-devel@nongnu.org; Fri, 16 Sep 2016 15:36:35 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:63582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkyw3-0004f2-2u for qemu-devel@nongnu.org; Fri, 16 Sep 2016 15:36:31 -0400 References: <20160916111422.109959-1-aleksandar.markovic@rt-rk.com> <20160916111422.109959-8-aleksandar.markovic@rt-rk.com> From: Laurent Vivier Message-ID: Date: Fri, 16 Sep 2016 21:35:55 +0200 MIME-Version: 1.0 In-Reply-To: <20160916111422.109959-8-aleksandar.markovic@rt-rk.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 7/7] linux-user: Add missing Mips syscalls items in strace.list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandar Markovic , qemu-devel@nongnu.org, riku.voipio@iki.fi, peter.maydell@linaro.org, aurelien@aurel32.net, leon.alrae@imgtec.com, petar.jovanovic@imgtec.com, miodrag.dinic@imgtec.com, aleksandar.rikalo@imgtec.com, aleksandar.markovic@imgtec.com Le 16/09/2016 à 13:14, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Without this patch, a number of Mips syscalls will be logged in the following > way (in this examople, this is an invocation of accept4()): > > 86906 Unknown syscall 4334 > > This patch provides standard Qemu's strace output for such cases, like this: > > 95861 accept4(3,1996486000,1996486016,128,0,0) = 5 > > Such output may be further improvad by providing strace-related functions > that handle only particular syscalls, but this is beyond the scope of > this patch. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/strace.list | 114 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 114 insertions(+) Nice work, we should update strace.list each time we add a syscall (and personally I don't, it's bad). How did you choose the list of syscalls to add in this list as some of them are not implemented in syscall.c? [for instance "kcmp", I have the patch for it but I don't think I've already sent it] Laurent