All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
To: Jason Wang <jasowang@redhat.com>, qemu devel <qemu-devel@nongnu.org>
Cc: zhangchen.fnst@cn.fujitsu.com,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	weifuqiang <weifuqiang@huawei.com>,
	"eddie . dong" <eddie.dong@intel.com>,
	bian naimeng <biannm@cn.fujitsu.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH V4 07/12] net/colo.c: Make vnet_hdr_len as packet property
Date: Tue, 23 May 2017 19:59:24 +0800	[thread overview]
Message-ID: <e2d38dc6-f686-202a-be46-e2ef8fb1cee8@cn.fujitsu.com> (raw)
In-Reply-To: <459b7363-e514-7dcc-624d-f302a6e4756c@redhat.com>



On 05/15/2017 04:18 PM, Jason Wang wrote:
>
>
> On 2017年05月15日 16:03, Zhang Chen wrote:
>>
>>
>> On 05/15/2017 12:05 PM, Jason Wang wrote:
>>>
>>>
>>> On 2017年05月12日 09:41, Zhang Chen wrote:
>>>> We can use this property flush and send packet with vnet_hdr_len.
>>>>
>>>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>>>
>>> Then I think it's not necessary to store vnet_hdr_len in 
>>> SocketReadState?
>>
>> Do you means we keep the patch 05/12 in original?
>>
>> Thanks
>> Zhang Chen
>>
>
> I mean we could fetch vnet_hdr_len from the buf directly. Or is there 
> any advantage to store it in SocketReadState?

No, The rs->buf did't have the vnet_hdr_len field.
In the net_fill_rstate(), when case = 2, we override the rs->buf by real 
net packet data,
So, the vnet_hdr_len field and packet_len field didn't be include in the 
last rs->buf.

Thanks
Zhang Chen

>
> Thanks
>
>
>
>

-- 
Thanks
Zhang Chen

  reply	other threads:[~2017-05-23 11:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12  1:41 [Qemu-devel] [PATCH V4 00/12] Add COLO-proxy virtio-net support Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 01/12] net: Add vnet_hdr_len related arguments in NetClientState Zhang Chen
2017-05-13 21:24   ` Philippe Mathieu-Daudé
2017-05-15  3:24     ` Jason Wang
2017-05-15  6:56       ` Zhang Chen
2017-05-15  8:06         ` Jason Wang
2017-05-15  8:14           ` Zhang Chen
2017-05-16  6:49             ` Jason Wang
2017-05-23 12:06               ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 02/12] net/filter-mirror.c: Add new option to enable vnet support for filter-mirror Zhang Chen
2017-05-13  1:49   ` Hailiang Zhang
2017-05-14 14:31     ` Zhang Chen
2017-05-15  3:26   ` Jason Wang
2017-05-15  6:57     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 03/12] net/filter-mirror.c: Make filter_mirror_send support vnet support Zhang Chen
2017-05-15  3:28   ` Jason Wang
2017-05-15  7:34     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 04/12] net/filter-mirror.c: Add new option to enable vnet support for filter-redirector Zhang Chen
2017-05-15  3:31   ` Jason Wang
2017-05-15  7:47     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 05/12] net/net.c: Add vnet_hdr support in SocketReadState Zhang Chen
2017-05-15  4:02   ` Jason Wang
2017-05-15  7:49     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 06/12] net/colo-compare.c: Add new option to enable vnet support for colo-compare Zhang Chen
2017-05-15  4:03   ` Jason Wang
2017-05-15  7:55     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 07/12] net/colo.c: Make vnet_hdr_len as packet property Zhang Chen
2017-05-15  4:05   ` Jason Wang
2017-05-15  8:03     ` Zhang Chen
2017-05-15  8:18       ` Jason Wang
2017-05-23 11:59         ` Zhang Chen [this message]
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 08/12] net/colo-compare.c: Make colo-compare support vnet_hdr_len Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 09/12] net/colo.c: Add vnet packet parse feature in colo-proxy Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 10/12] net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare Zhang Chen
2017-05-15  4:11   ` Jason Wang
2017-05-15  8:04     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 11/12] net/filter-rewriter.c: Add new option to enable vnet support for filter-rewriter Zhang Chen
2017-05-15  4:12   ` Jason Wang
2017-05-15  8:05     ` Zhang Chen
2017-05-12  1:41 ` [Qemu-devel] [PATCH V4 12/12] net/filter-rewriter.c: Make filter-rewriter support vnet_hdr_len Zhang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2d38dc6-f686-202a-be46-e2ef8fb1cee8@cn.fujitsu.com \
    --to=zhangchen.fnst@cn.fujitsu.com \
    --cc=biannm@cn.fujitsu.com \
    --cc=eddie.dong@intel.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weifuqiang@huawei.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.