From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RukCD-00071w-2v for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:30:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RukC1-0001hc-A5 for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:30:53 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:33493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RukC1-0001hJ-0n for qemu-devel@nongnu.org; Tue, 07 Feb 2012 07:30:41 -0500 Received: by pbaa11 with SMTP id a11so7847503pba.4 for ; Tue, 07 Feb 2012 04:30:40 -0800 (PST) From: Ori Mamluk References: <73865e0ce364c40e0eb65ec6b22b819d@mail.gmail.com> <4F31153E.9010205@codemonkey.ws> <4F311839.9030709@redhat.com> In-Reply-To: <4F311839.9030709@redhat.com> MIME-Version: 1.0 Date: Tue, 7 Feb 2012 14:30:37 +0200 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [RFC PATCH] replication agent module List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dlaor@redhat.com Cc: Kevin Wolf , qemu-devel@nongnu.org > In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread. Yes - I mentioned that in the patch mail as one of the open issues. Can you direct me to the lock I need? The function I call from a new thread context is bdrv_aio_readv. -----Original Message----- From: Dor Laor [mailto:dlaor@redhat.com] Sent: Tuesday, February 07, 2012 2:25 PM To: Anthony Liguori Cc: Ori Mamluk; Kevin Wolf; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [RFC PATCH] replication agent module On 02/07/2012 02:12 PM, Anthony Liguori wrote: > Hi, > > On 02/07/2012 04:29 AM, Ori Mamluk wrote: >> Repagent is a new module that allows an external replication system >> to replicate a volume of a Qemu VM. >> >> This RFC patch adds the repagent client module to Qemu. > > Please read http://wiki.qemu.org/Contribute/SubmitAPatch > > In particular, use a tool like git-send-email and split this patch up > into more manageable chunks. > > Is there an Open Source rehub available? As a project policy, adding > external APIs specifically for proprietary software is not something > we're willing to do. > > Regards, > > Anthony Liguori In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread. About image ID for the replication hub, you can use the VM's pid or VM's uuid paired w/ the specific disk uuid Thanks, Dor