* Re: [PATCH 0/3] Add support for sending RFC8335 PROBE messages
[not found] ` <20201113073230.3ecd6f0d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
@ 2020-11-13 20:53 ` Andreas Roeseler
2020-11-13 21:33 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Roeseler @ 2020-11-13 20:53 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, kuznet, yoshfuji, netdev
On Fri, 2020-11-13 at 07:32 -0800, Jakub Kicinski wrote:
> On Thu, 12 Nov 2020 21:02:27 -0800 Andreas Roeseler wrote:
> > The popular utility ping has several severe limitations such as
> > an inability to query specific interfaces on a node and requiring
> > bidirectional connectivity between the probing and the probed
> > interfaces. RFC 8335 attempts to solve these limitations by
> > creating the
> > new utility PROBE which is an ICMP message that makes use of the
> > ICMP
> > Extension Structure outlined in RFC 4884.
> >
> > This patchset adds define statments for the probe ICMP message
> > request
> > and reply types for both IPv4 and IPv6. It also expands the list of
> > supported ICMP messages to accommodate probe messages.
>
> Did you mean to CC netdev?
Thank you for catching that. I'm new to kernel development and I'm still
trying to get my bearings.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] net: add support for sending probe messages
[not found] ` <20201113050234.8165-1-andreas.a.roeseler@gmail.com>
@ 2020-11-13 20:54 ` Andreas Roeseler
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Roeseler @ 2020-11-13 20:54 UTC (permalink / raw)
To: davem; +Cc: kuznet, yoshfuji, kuba, netdev
On Thu, 2020-11-12 at 21:02 -0800, Andreas Roeseler wrote:
> Modifying the ping_supported function to support probe messages
> allows
> users to send probe messages while using the existing framework for
> sending ping messages.
>
> Signed-off-by: Andreas Roeseler <andreas.a.roeseler@gmail.com>
> ---
> net/ipv4/ping.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
> index 248856b301c4..0077ef838fef 100644
> --- a/net/ipv4/ping.c
> +++ b/net/ipv4/ping.c
> @@ -453,7 +453,9 @@ EXPORT_SYMBOL_GPL(ping_bind);
> static inline int ping_supported(int family, int type, int code)
> {
> return (family == AF_INET && type == ICMP_ECHO && code == 0)
> ||
> - (family == AF_INET6 && type == ICMPV6_ECHO_REQUEST &&
> code == 0);
> + (family == AF_INET && type == ICMP_EXT_ECHO && code
> == 0) ||
> + (family == AF_INET6 && type == ICMPV6_ECHO_REQUEST &&
> code == 0) ||
> + (family == AF_INET6 && type == ICMPV6_EXT_ECHO_REQUEST
> && code == 0);
> }
>
> /*
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] icmp: define probe message types
[not found] ` <20201113050241.8218-1-andreas.a.roeseler@gmail.com>
@ 2020-11-13 20:54 ` Andreas Roeseler
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Roeseler @ 2020-11-13 20:54 UTC (permalink / raw)
To: davem; +Cc: kuznet, yoshfuji, kuba, netdev
On Thu, 2020-11-12 at 21:02 -0800, Andreas Roeseler wrote:
> Types of ICMP Extended Echo Request and ICMP Extended Echo Reply are
> defined in sections 2 and 3 of RFC 8335.
>
> Signed-off-by: Andreas Roeseler <andreas.a.roeseler@gmail.com>
> ---
> include/uapi/linux/icmp.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uapi/linux/icmp.h b/include/uapi/linux/icmp.h
> index fb169a50895e..6cabb6acc156 100644
> --- a/include/uapi/linux/icmp.h
> +++ b/include/uapi/linux/icmp.h
> @@ -66,6 +66,10 @@
> #define ICMP_EXC_TTL 0 /* TTL count
> exceeded */
> #define ICMP_EXC_FRAGTIME 1 /* Fragment Reass time
> exceeded */
>
> +/* Codes for EXT_ECHO (Probe). */
> +#define ICMP_EXT_ECHO 42
> +#define ICMP_EXT_ECHOREPLY 43
> +
>
> struct icmphdr {
> __u8 type;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] ICMPv6: define probe message types
[not found] ` <20201113050247.8273-1-andreas.a.roeseler@gmail.com>
@ 2020-11-13 20:54 ` Andreas Roeseler
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Roeseler @ 2020-11-13 20:54 UTC (permalink / raw)
To: davem; +Cc: kuznet, yoshfuji, kuba, netdev
On Thu, 2020-11-12 at 21:02 -0800, Andreas Roeseler wrote:
> From: Andreas Roeseler <aroeseler@g.hmc.edu>
>
> Types of ICMPv6 Extended Echo Request and ICMPv6 Extended Echo Reply
> are
> defined by sections 2 and 3 of RFC 8335.
>
> Signed-off-by: Andreas Roeseler <andreas.a.roeseler@gmail.com>
> ---
> include/uapi/linux/icmpv6.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/linux/icmpv6.h
> b/include/uapi/linux/icmpv6.h
> index c1661febc2dc..183a8b3feb92 100644
> --- a/include/uapi/linux/icmpv6.h
> +++ b/include/uapi/linux/icmpv6.h
> @@ -139,6 +139,12 @@ struct icmp6hdr {
> #define ICMPV6_UNK_NEXTHDR 1
> #define ICMPV6_UNK_OPTION 2
>
> +/*
> + * Codes for EXT_ECHO (Probe)
> + */
> +#define ICMPV6_EXT_ECHO_REQUEST 160
> +#define ICMPV6_EXT_ECHO_REPLY 161
> +
> /*
> * constants for (set|get)sockopt
> */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] Add support for sending RFC8335 PROBE messages
2020-11-13 20:53 ` [PATCH 0/3] Add support for sending RFC8335 PROBE messages Andreas Roeseler
@ 2020-11-13 21:33 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2020-11-13 21:33 UTC (permalink / raw)
To: Andreas Roeseler; +Cc: davem, kuznet, yoshfuji, netdev
On Fri, 13 Nov 2020 12:53:00 -0800 Andreas Roeseler wrote:
> On Fri, 2020-11-13 at 07:32 -0800, Jakub Kicinski wrote:
> > On Thu, 12 Nov 2020 21:02:27 -0800 Andreas Roeseler wrote:
> > > The popular utility ping has several severe limitations such as
> > > an inability to query specific interfaces on a node and requiring
> > > bidirectional connectivity between the probing and the probed
> > > interfaces. RFC 8335 attempts to solve these limitations by
> > > creating the
> > > new utility PROBE which is an ICMP message that makes use of the
> > > ICMP
> > > Extension Structure outlined in RFC 4884.
> > >
> > > This patchset adds define statments for the probe ICMP message
> > > request
> > > and reply types for both IPv4 and IPv6. It also expands the list of
> > > supported ICMP messages to accommodate probe messages.
> >
> > Did you mean to CC netdev?
>
> Thank you for catching that. I'm new to kernel development and I'm still
> trying to get my bearings.
You should repost the series, with the mailing list CCed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-13 21:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1605238003.git.andreas.a.roeseler@gmail.com>
[not found] ` <20201113073230.3ecd6f0d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2020-11-13 20:53 ` [PATCH 0/3] Add support for sending RFC8335 PROBE messages Andreas Roeseler
2020-11-13 21:33 ` Jakub Kicinski
[not found] ` <20201113050234.8165-1-andreas.a.roeseler@gmail.com>
2020-11-13 20:54 ` [PATCH 1/3] net: add support for sending probe messages Andreas Roeseler
[not found] ` <20201113050241.8218-1-andreas.a.roeseler@gmail.com>
2020-11-13 20:54 ` [PATCH 2/3] icmp: define probe message types Andreas Roeseler
[not found] ` <20201113050247.8273-1-andreas.a.roeseler@gmail.com>
2020-11-13 20:54 ` [PATCH 3/3] ICMPv6: " Andreas Roeseler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.