All of lore.kernel.org
 help / color / mirror / Atom feed
From: Melissa Wen <melissa.srw@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: kernel-usp@googlegroups.com, twoerner@gmail.com
Subject: [igt-dev] [PATCH i-g-t v2 1/1] test/kms_cursor_crc: release old pipe_crc before create a new one
Date: Thu, 16 Jul 2020 08:25:21 -0300	[thread overview]
Message-ID: <e2e335dbf2189ea9ece3373364520eca8eb3349b.1594897760.git.melissa.srw@gmail.com> (raw)
In-Reply-To: <cover.1594897760.git.melissa.srw@gmail.com>

When a subtest fails, it skips the cleanup, and its pipe_crc remains allocated.
As a consequence, the following subtest also fails (timeout) when trying to
create a new one. This patch releases any remaining pipe_crc to enable the
creation of a new one for the next subtest.

Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
---
 tests/kms_cursor_crc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 7e6b24cc..bc5d4232 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -422,6 +422,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	igt_display_commit(display);
 
 	/* create the pipe_crc object for this pipe */
+	if (data->pipe_crc)
+		igt_pipe_crc_free(data->pipe_crc);
 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
 					  INTEL_PIPE_CRC_SOURCE_AUTO);
 
-- 
2.27.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-07-16 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 11:24 [igt-dev] [PATCH i-g-t v2 0/1] test/kms_cursor_crc: tie some loose ends in prepare_crtc Melissa Wen
2020-07-16 11:25 ` Melissa Wen [this message]
2020-07-20 15:10   ` [igt-dev] [PATCH i-g-t v2 1/1] test/kms_cursor_crc: release old pipe_crc before create a new one Arkadiusz Hiler
2020-07-16 11:52 ` [igt-dev] ✓ Fi.CI.BAT: success for test/kms_cursor_crc: tie some loose ends in prepare_crtc (rev2) Patchwork
2020-07-16 15:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2e335dbf2189ea9ece3373364520eca8eb3349b.1594897760.git.melissa.srw@gmail.com \
    --to=melissa.srw@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.