All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Sunil Vettukalppurathu <sunilvm@gmail.com>, fio@vger.kernel.org
Subject: Re: random buffer_compress_percentage instead of static
Date: Thu, 24 Jun 2021 18:55:10 -0600	[thread overview]
Message-ID: <e2f3a5c9-88a5-fa17-610e-a107589ef3a6@kernel.dk> (raw)
In-Reply-To: <CAP6uPsW0SF-0BuLkx8aC8X9xuqju4C-+9wknxMP3JiOqB6_QRg@mail.gmail.com>

On 6/24/21 12:38 PM, Sunil Vettukalppurathu wrote:
> Hi,
> 
> Currently we can’t vary % of compressible data from block to block (as
> far as I know). The value provided  for buffer_compress_percentage is
> used for all blocks.
> 
> """
> buffer_compress_percentage=int
> If this is set, then fio will attempt to provide I/O buffer content
> (on WRITEs) that compresses to the specified
> level. Fio does this by providing a mix of random data followed by
> fixed pattern data. """
> 
> As we have a requirement to test with random compression %, we
> modified the code to accept a range of values for
> buffer_compress_percentage instead of one number so that the
> percentage changes from block to block – random value between min and
> max.
> 
> Not sure if  it’s useful for others; if so, will send the patch for review.

Please do, sounds like a useful feature. How is it managed in terms of
options?

-- 
Jens Axboe



      reply	other threads:[~2021-06-25  0:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 18:38 random buffer_compress_percentage instead of static Sunil Vettukalppurathu
2021-06-25  0:55 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2f3a5c9-88a5-fa17-610e-a107589ef3a6@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=sunilvm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.