From: Joe Perches <joe@perches.com>
To: Alex Elder <elder@ieee.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] greybus: Use fallthrough pseudo-keyword
Date: Tue, 28 Jul 2020 17:25:50 -0700 [thread overview]
Message-ID: <e301110c6aa504be56ec73a355d3aa9215fc9633.camel@perches.com> (raw)
In-Reply-To: <63871608-e076-26b0-85df-cff11699c3a3@ieee.org>
On Tue, 2020-07-28 at 17:37 -0500, Alex Elder wrote:
> On 7/27/20 1:32 PM, Gustavo A. R. Silva wrote:
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1].
> >
> > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Thanks for the patch. It looks good, but it raises
> another question I'd like discussion on.
>
> It seems that Johan likes default (or final) cases in
> switch statements without a "break" statement. Viresh
> and Bryan appear to be fond of this too.
>
> It's pedantic, but I don't like that. Am I wrong?
No, you are not wrong.
next prev parent reply other threads:[~2020-07-29 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 18:32 [PATCH][next] greybus: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-28 22:37 ` Alex Elder
2020-07-29 0:25 ` Joe Perches [this message]
2020-07-29 10:51 ` [greybus-dev] " Viresh Kumar
2020-07-29 12:15 ` Alex Elder
2020-08-05 13:14 ` Alex Elder
2020-08-05 16:21 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e301110c6aa504be56ec73a355d3aa9215fc9633.camel@perches.com \
--to=joe@perches.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=gustavoars@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.