From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF5CC48BC2 for ; Mon, 21 Jun 2021 18:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 605B0611BD for ; Mon, 21 Jun 2021 18:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231754AbhFUSbd (ORCPT ); Mon, 21 Jun 2021 14:31:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbhFUSbd (ORCPT ); Mon, 21 Jun 2021 14:31:33 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F6AC061574 for ; Mon, 21 Jun 2021 11:29:18 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id f15so5308379wro.8 for ; Mon, 21 Jun 2021 11:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0h7qTLw7iVbT8QbSsm0zBOuy3gLWBPfMMVwH84B0A6E=; b=caiwhYlEUQbVaBms76Ua1Mcy5TQCvcHwN38R360aXilH1yWBuoBB8JY8yyujL7w+hg VOImO6JkzqlIgksrbB3BQMozaFUGQt9EYsVrMPVnIRtlfx8aVEA/SwmskHMol70MZ76E oKCuZzxhLaJR8vlkVWhkQsFJC2gsxDNuBeGZsVDobXcjHtuqKJQrUsehVro3YvlgMo4H WlW9QIF3GPIyHpV4+IpxTRU/wUX0SCKEKGdahd9sEGndFurOZztjbZQIhcUW9b8HUJZq 0+fdRjvNgsMi//qVrnjuhIiW11BZulbBkDiim3gaUL4TXoZzA1rU5PUMMtOzEzz7uHTP 0fuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0h7qTLw7iVbT8QbSsm0zBOuy3gLWBPfMMVwH84B0A6E=; b=pI6a5CCyvM2hWC+PdJxMFgo6akzC5GwBCTWQwt9sNJ1FYSvHYvJML6rkcivqjbShcQ P9O/BJVx2vc9FAn9wNq0q1EIoF0cUt2Vkd+hEMV0eFtAWI5gUdzuTfDGipOxr1sF4FgP d+XkFtM1g3VtZ06mPDIpcpbJyS2awi0T+Vaslvb/CcZj2YwtEzMvukAt4ErIyXVAF4vE LncIYIImebK2qS9R2Z+qoBqr7Xpn3en+j049fmjUdqlSRsf5c4OacmF5DkOprtIv+Kkh Tk5D8vWtcsh/m399zjbcMKcqHOUOXXjeH9yglFpzNpWKYe3TRk3H57LCY01m83ztayih 3dFA== X-Gm-Message-State: AOAM533WYngM9C2lIU1rX2BP+W5lcho2joCCl+idS5titjP3N/G8c9Zr p8OpYPNzROZCgk8uZ7PUHDz1rK5PKOEL1s9d X-Google-Smtp-Source: ABdhPJwPxfVG4w0Lz2q4SXNxbZfRCeQ5g1BryLvFq3XRveWZT/82P4U5rh+6QPi4nV7uOkjbCWj7eA== X-Received: by 2002:a05:6000:50d:: with SMTP id a13mr29289561wrf.130.1624300156936; Mon, 21 Jun 2021 11:29:16 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:5ebd:8bd9:d549:4211? ([2a01:e34:ed2f:f020:5ebd:8bd9:d549:4211]) by smtp.googlemail.com with ESMTPSA id k2sm18235911wrw.93.2021.06.21.11.29.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 11:29:16 -0700 (PDT) Subject: Re: [PATCH] Fix mt7622.dtsi thermal cpu To: ericwouds@gmail.com, Rob Herring , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210619121927.32699-1-ericwouds@gmail.com> From: Daniel Lezcano Message-ID: Date: Mon, 21 Jun 2021 20:29:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210619121927.32699-1-ericwouds@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/2021 14:19, ericwouds@gmail.com wrote: > From: Eric Woudstra > > Cpu-thermal is set to use all frequencies already at 47 degrees. > Using the CPU at 50 for a minute, the CPU has reached 48 degrees, is > throttled back to lowest setting, making the mt7622 terrribly slow. > Even at this low speed, the CPU does not cool down lower then 47 so > the CPU is stuck at lowest possible frequency until it shut down and > stays off for 15 minutes. > > cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > > This should not be set al every cooling map. It should only be set at > the highest cooling map. Same as in the example: > > https://www.kernel.org/doc/Documentation/devicetree/bindings/ > thermal/thermal.txt line 272 > > But then without the fan and added a third map. > > Now temperature will be regulated at 87 degrees celcius. At temperatures > lower then 87, all frequencies can be used. 47°C is really a too low temperature and this performance drop is normal. I would not remove the passive mitigation but try by increasing the CPU temp to 70°C and by changing the active trip point to 80°C. If it works fine, try 75°C and 85°C. To test, the thermal killer is dhrystone (one thread per cpu). With a 75°C passive trip point, the step wise thermal governor, I think the mitigation will happen smoothly providing better performances, and probably the fan won't fire. > Also see the post: > > http://forum.banana-pi.org/t/bpi-r64-only-10-cpu-speed-at-already-48- > degrees-celcius-speed-not-increasing-anymore/12262 > > Signed-off-by: Eric Woudstra > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 890a942ec..b779c7aa6 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -170,14 +170,14 @@ cpu-crit { > cooling-maps { > map0 { > trip = <&cpu_passive>; > - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + cooling-device = <&cpu0 0 0>, > + <&cpu1 0 0>; > }; > > map1 { > trip = <&cpu_active>; > - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + cooling-device = <&cpu0 0 0>, > + <&cpu1 0 0>; > }; > > map2 { > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7D3C4743C for ; Mon, 21 Jun 2021 18:29:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E38F6120D for ; Mon, 21 Jun 2021 18:29:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E38F6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bg6+lqbBthWCAn2jmeamJ2pTYf0+PjE7t6tS2tuxB4s=; b=jii18yallHdEVRnomLc3x0J5kA fH2tVC5jHLMsenbzyb1ypTOYhO65D6WQDocTn/umpVbpi01tqRLVE7C2xAAo9a5ArLAWutm6kZRbM IsnDXAOlupW2Z+GoYtQXk6bjpu9jkUNBpkk1YDUMHc074j30lVMxhMe4LWpaskeSydqVxxUDTorcd 2BBsmqHA/C2OzHad98FZ5KpA0lEPony3uAuiag017thf+5Ale8bbSjHhnAoDc/T6wTrZAV+cibWd8 tnjsgHUDzkPriazwUobbOPIcEr1RYQ9eZbWX6wJfvJsLNyY86cGVEeDXZsmOdZYMkIvOUDAprMRvE mXAzNIYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvOg2-004bFP-CK; Mon, 21 Jun 2021 18:29:42 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvOfe-004b9Q-UN for linux-mediatek@lists.infradead.org; Mon, 21 Jun 2021 18:29:20 +0000 Received: by mail-wr1-x433.google.com with SMTP id n7so20765841wri.3 for ; Mon, 21 Jun 2021 11:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0h7qTLw7iVbT8QbSsm0zBOuy3gLWBPfMMVwH84B0A6E=; b=caiwhYlEUQbVaBms76Ua1Mcy5TQCvcHwN38R360aXilH1yWBuoBB8JY8yyujL7w+hg VOImO6JkzqlIgksrbB3BQMozaFUGQt9EYsVrMPVnIRtlfx8aVEA/SwmskHMol70MZ76E oKCuZzxhLaJR8vlkVWhkQsFJC2gsxDNuBeGZsVDobXcjHtuqKJQrUsehVro3YvlgMo4H WlW9QIF3GPIyHpV4+IpxTRU/wUX0SCKEKGdahd9sEGndFurOZztjbZQIhcUW9b8HUJZq 0+fdRjvNgsMi//qVrnjuhIiW11BZulbBkDiim3gaUL4TXoZzA1rU5PUMMtOzEzz7uHTP 0fuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0h7qTLw7iVbT8QbSsm0zBOuy3gLWBPfMMVwH84B0A6E=; b=RQRMw0KKt756+tBQpdjmnSilLQyAlCrnxaLcTCiiVNqi7qIJMPMIkJ+fi5EvHBA2rO h1A0NH0qYL0QMdXvpcMw0/rcPBYycBnQH56IdGHhbgmZbeccaTyfT933V4Bqqg59R1lF DGpF8G7gjejFVscLANjJ8J+0aPvulzqH671BxSI+0SKXnXcfusIR53ZOM6G7zQ1sJf3W XiB44QgtlPwGc8KqCGjJqn+0QMamuMu1oY9QEsLWAnYdLUsZ7otpJM+Qf6FA916him+z DjWYS1Pse/8u61SO4z8rl0bikvliswzkL9FHiFPJ7Dxbn8somzaDGD/lr8Qz0KLDHYAy GUDg== X-Gm-Message-State: AOAM531CF1A4D+ZGRTU/Nih6jMQ5rC3O573F424qubfqDc8RI2YKUbGH XjA9GF4Um/0gb+eKmloin7HBkg== X-Google-Smtp-Source: ABdhPJwPxfVG4w0Lz2q4SXNxbZfRCeQ5g1BryLvFq3XRveWZT/82P4U5rh+6QPi4nV7uOkjbCWj7eA== X-Received: by 2002:a05:6000:50d:: with SMTP id a13mr29289561wrf.130.1624300156936; Mon, 21 Jun 2021 11:29:16 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:5ebd:8bd9:d549:4211? ([2a01:e34:ed2f:f020:5ebd:8bd9:d549:4211]) by smtp.googlemail.com with ESMTPSA id k2sm18235911wrw.93.2021.06.21.11.29.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 11:29:16 -0700 (PDT) Subject: Re: [PATCH] Fix mt7622.dtsi thermal cpu To: ericwouds@gmail.com, Rob Herring , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210619121927.32699-1-ericwouds@gmail.com> From: Daniel Lezcano Message-ID: Date: Mon, 21 Jun 2021 20:29:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210619121927.32699-1-ericwouds@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_112919_057435_89B04C41 X-CRM114-Status: GOOD ( 25.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gMTkvMDYvMjAyMSAxNDoxOSwgZXJpY3dvdWRzQGdtYWlsLmNvbSB3cm90ZToKPiBGcm9tOiBF cmljIFdvdWRzdHJhIDxlcmljd291ZHNAZ21haWwuY29tPgo+IAo+IENwdS10aGVybWFsIGlzIHNl dCB0byB1c2UgYWxsIGZyZXF1ZW5jaWVzIGFscmVhZHkgYXQgNDcgZGVncmVlcy4gCj4gVXNpbmcg dGhlIENQVSBhdCA1MCBmb3IgYSBtaW51dGUsIHRoZSBDUFUgaGFzIHJlYWNoZWQgNDggZGVncmVl cywgaXMgCj4gdGhyb3R0bGVkIGJhY2sgdG8gbG93ZXN0IHNldHRpbmcsIG1ha2luZyB0aGUgbXQ3 NjIyIHRlcnJyaWJseSBzbG93LiAKPiBFdmVuIGF0IHRoaXMgbG93IHNwZWVkLCB0aGUgQ1BVIGRv ZXMgbm90IGNvb2wgZG93biBsb3dlciB0aGVuIDQ3IHNvCj4gdGhlIENQVSBpcyBzdHVjayBhdCBs b3dlc3QgcG9zc2libGUgZnJlcXVlbmN5IHVudGlsIGl0IHNodXQgZG93biBhbmQKPiBzdGF5cyBv ZmYgZm9yIDE1IG1pbnV0ZXMuCj4gCj4gY29vbGluZy1kZXZpY2UgPSA8JmNwdTAgVEhFUk1BTF9O T19MSU1JVCBUSEVSTUFMX05PX0xJTUlUPiwKPiAgICAgICAgICAgICAgICAgIDwmY3B1MSBUSEVS TUFMX05PX0xJTUlUIFRIRVJNQUxfTk9fTElNSVQ+Owo+IAo+IFRoaXMgc2hvdWxkIG5vdCBiZSBz ZXQgYWwgZXZlcnkgY29vbGluZyBtYXAuIEl0IHNob3VsZCBvbmx5IGJlIHNldCBhdAo+IHRoZSBo aWdoZXN0IGNvb2xpbmcgbWFwLiBTYW1lIGFzIGluIHRoZSBleGFtcGxlOgo+IAo+IGh0dHBzOi8v d3d3Lmtlcm5lbC5vcmcvZG9jL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy8KPiB0 aGVybWFsL3RoZXJtYWwudHh0ICBsaW5lIDI3Mgo+IAo+IEJ1dCB0aGVuIHdpdGhvdXQgdGhlIGZh biBhbmQgYWRkZWQgYSB0aGlyZCBtYXAuCj4gCj4gTm93IHRlbXBlcmF0dXJlIHdpbGwgYmUgcmVn dWxhdGVkIGF0IDg3IGRlZ3JlZXMgY2VsY2l1cy4gQXQgdGVtcGVyYXR1cmVzCj4gbG93ZXIgdGhl biA4NywgYWxsIGZyZXF1ZW5jaWVzIGNhbiBiZSB1c2VkLgoKNDfCsEMgaXMgcmVhbGx5IGEgdG9v IGxvdyB0ZW1wZXJhdHVyZSBhbmQgdGhpcyBwZXJmb3JtYW5jZSBkcm9wIGlzIG5vcm1hbC4KCkkg d291bGQgbm90IHJlbW92ZSB0aGUgcGFzc2l2ZSBtaXRpZ2F0aW9uIGJ1dCB0cnkgYnkgaW5jcmVh c2luZyB0aGUgQ1BVCnRlbXAgdG8gNzDCsEMgYW5kIGJ5IGNoYW5naW5nIHRoZSBhY3RpdmUgdHJp cCBwb2ludCB0byA4MMKwQy4gSWYgaXQgd29ya3MKZmluZSwgdHJ5IDc1wrBDIGFuZCA4NcKwQy4K ClRvIHRlc3QsIHRoZSB0aGVybWFsIGtpbGxlciBpcyBkaHJ5c3RvbmUgKG9uZSB0aHJlYWQgcGVy IGNwdSkuCgpXaXRoIGEgNzXCsEMgcGFzc2l2ZSB0cmlwIHBvaW50LCB0aGUgc3RlcCB3aXNlIHRo ZXJtYWwgZ292ZXJub3IsIEkgdGhpbmsKdGhlIG1pdGlnYXRpb24gd2lsbCBoYXBwZW4gc21vb3Ro bHkgcHJvdmlkaW5nIGJldHRlciBwZXJmb3JtYW5jZXMsIGFuZApwcm9iYWJseSB0aGUgZmFuIHdv bid0IGZpcmUuCgo+IEFsc28gc2VlIHRoZSBwb3N0Ogo+IAo+IGh0dHA6Ly9mb3J1bS5iYW5hbmEt cGkub3JnL3QvYnBpLXI2NC1vbmx5LTEwLWNwdS1zcGVlZC1hdC1hbHJlYWR5LTQ4LQo+IGRlZ3Jl ZXMtY2VsY2l1cy1zcGVlZC1ub3QtaW5jcmVhc2luZy1hbnltb3JlLzEyMjYyCj4gCj4gU2lnbmVk LW9mZi1ieTogRXJpYyBXb3Vkc3RyYSA8ZXJpY3dvdWRzQGdtYWlsLmNvbT4KPiAtLS0KPiAgYXJj aC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDc2MjIuZHRzaSB8IDggKysrKy0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDc2MjIuZHRzaSBiL2FyY2gvYXJt NjQvYm9vdC9kdHMvbWVkaWF0ZWsvbXQ3NjIyLmR0c2kKPiBpbmRleCA4OTBhOTQyZWMuLmI3Nzlj N2FhNiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21lZGlhdGVrL210NzYyMi5k dHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDc2MjIuZHRzaQo+IEBA IC0xNzAsMTQgKzE3MCwxNCBAQCBjcHUtY3JpdCB7Cj4gIAkJCWNvb2xpbmctbWFwcyB7Cj4gIAkJ CQltYXAwIHsKPiAgCQkJCQl0cmlwID0gPCZjcHVfcGFzc2l2ZT47Cj4gLQkJCQkJY29vbGluZy1k ZXZpY2UgPSA8JmNwdTAgVEhFUk1BTF9OT19MSU1JVCBUSEVSTUFMX05PX0xJTUlUPiwKPiAtCQkJ CQkJCSA8JmNwdTEgVEhFUk1BTF9OT19MSU1JVCBUSEVSTUFMX05PX0xJTUlUPjsKPiArCQkJCQlj b29saW5nLWRldmljZSA9IDwmY3B1MCAwIDA+LAo+ICsJCQkJCQkJIDwmY3B1MSAwIDA+Owo+ICAJ CQkJfTsKPiAgCj4gIAkJCQltYXAxIHsKPiAgCQkJCQl0cmlwID0gPCZjcHVfYWN0aXZlPjsKPiAt CQkJCQljb29saW5nLWRldmljZSA9IDwmY3B1MCBUSEVSTUFMX05PX0xJTUlUIFRIRVJNQUxfTk9f TElNSVQ+LAo+IC0JCQkJCQkJIDwmY3B1MSBUSEVSTUFMX05PX0xJTUlUIFRIRVJNQUxfTk9fTElN SVQ+Owo+ICsJCQkJCWNvb2xpbmctZGV2aWNlID0gPCZjcHUwIDAgMD4sCj4gKwkJCQkJCQkgPCZj cHUxIDAgMD47Cj4gIAkJCQl9Owo+ICAKPiAgCQkJCW1hcDIgewo+IAoKCi0tIAo8aHR0cDovL3d3 dy5saW5hcm8ub3JnLz4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFS TSBTb0NzCgpGb2xsb3cgTGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJvb2suY29tL3BhZ2VzL0xp bmFybz4gRmFjZWJvb2sgfAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4gVHdpdHRl ciB8CjxodHRwOi8vd3d3LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBCbG9nCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWls aW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B24C4743C for ; Mon, 21 Jun 2021 18:31:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C436A611BD for ; Mon, 21 Jun 2021 18:31:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C436A611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=nsZJ30y+Yd/3mM2i2pBeBjTv2bqn4xXoQzhSjinjmug=; b=zbjqfyZ/iBfviIpDsRu9kXIH0G j40UYD1mhTXnF8uYt6xtlhwBSox9rgKcLDFg9GYS524SD034V6uiL6yair7uBg8OcXLSjKhzX3QWv qoLCeiWv55od2tr1qcrLyHf0FXE9MMIPBG35lVLIqCveakrvaEkoAGE9SBBHWQT29BfjZY7RDQh1K 6Fj5SMgWk8khb4sa3CHL4+zduOMLIdeqtJIK3vOCWKLsyxfX50zgwBsciKBGiTOqD7dFuyHNUpYAH DBTwclrzZbIyAsYo0acSqWKDIXz3chSX9rj4U3FNtMggypanKchJK08br7XWVUZ4BsaS05WRUchB7 LlbwaUQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvOfk-004bBM-OC; Mon, 21 Jun 2021 18:29:25 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvOfe-004b9R-UV for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 18:29:20 +0000 Received: by mail-wr1-x430.google.com with SMTP id d11so18377963wrm.0 for ; Mon, 21 Jun 2021 11:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0h7qTLw7iVbT8QbSsm0zBOuy3gLWBPfMMVwH84B0A6E=; b=caiwhYlEUQbVaBms76Ua1Mcy5TQCvcHwN38R360aXilH1yWBuoBB8JY8yyujL7w+hg VOImO6JkzqlIgksrbB3BQMozaFUGQt9EYsVrMPVnIRtlfx8aVEA/SwmskHMol70MZ76E oKCuZzxhLaJR8vlkVWhkQsFJC2gsxDNuBeGZsVDobXcjHtuqKJQrUsehVro3YvlgMo4H WlW9QIF3GPIyHpV4+IpxTRU/wUX0SCKEKGdahd9sEGndFurOZztjbZQIhcUW9b8HUJZq 0+fdRjvNgsMi//qVrnjuhIiW11BZulbBkDiim3gaUL4TXoZzA1rU5PUMMtOzEzz7uHTP 0fuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0h7qTLw7iVbT8QbSsm0zBOuy3gLWBPfMMVwH84B0A6E=; b=DGzu/TmlXk4QT99JVvs1Hx1OXuDyBrLKB5J53FsdhUaMvvN927Cdbe8Z7kZp1Gp6Vd sb5JSbzETxO16AYGqJqUShr2tLCuvfkxXF/OXlKjbTzareGyFiDa8tHLgszBJ5C1Jv9z 4el79CDCKF+ATFREaYaoBJdKm+boD4DPX1MggXQhBu2qb5ldjW5VXlhPHFMNTccp67K/ bcv4o+gmFkJx4qahz97ahrHcQWad7mXFukN7XmGOv4yq1jeO+3psCtWLhvkMrzD3aj9D KtkQwR0DT4xfUKKeuhhBCgBkhAFimmxTKuEAaq521b59gf/VPXbaoRtOYyHJUmVZG5fS SIyQ== X-Gm-Message-State: AOAM531Za9G4S8hyQ11wu5RT7ChU5a54b0DYXc7yyFT+TM99ueiDbJkc y7OPs9AZ1qqsAJCdwDEJIO0lwg== X-Google-Smtp-Source: ABdhPJwPxfVG4w0Lz2q4SXNxbZfRCeQ5g1BryLvFq3XRveWZT/82P4U5rh+6QPi4nV7uOkjbCWj7eA== X-Received: by 2002:a05:6000:50d:: with SMTP id a13mr29289561wrf.130.1624300156936; Mon, 21 Jun 2021 11:29:16 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:5ebd:8bd9:d549:4211? ([2a01:e34:ed2f:f020:5ebd:8bd9:d549:4211]) by smtp.googlemail.com with ESMTPSA id k2sm18235911wrw.93.2021.06.21.11.29.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 11:29:16 -0700 (PDT) Subject: Re: [PATCH] Fix mt7622.dtsi thermal cpu To: ericwouds@gmail.com, Rob Herring , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210619121927.32699-1-ericwouds@gmail.com> From: Daniel Lezcano Message-ID: Date: Mon, 21 Jun 2021 20:29:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210619121927.32699-1-ericwouds@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_112919_050522_6C74FCE1 X-CRM114-Status: GOOD ( 26.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTkvMDYvMjAyMSAxNDoxOSwgZXJpY3dvdWRzQGdtYWlsLmNvbSB3cm90ZToKPiBGcm9tOiBF cmljIFdvdWRzdHJhIDxlcmljd291ZHNAZ21haWwuY29tPgo+IAo+IENwdS10aGVybWFsIGlzIHNl dCB0byB1c2UgYWxsIGZyZXF1ZW5jaWVzIGFscmVhZHkgYXQgNDcgZGVncmVlcy4gCj4gVXNpbmcg dGhlIENQVSBhdCA1MCBmb3IgYSBtaW51dGUsIHRoZSBDUFUgaGFzIHJlYWNoZWQgNDggZGVncmVl cywgaXMgCj4gdGhyb3R0bGVkIGJhY2sgdG8gbG93ZXN0IHNldHRpbmcsIG1ha2luZyB0aGUgbXQ3 NjIyIHRlcnJyaWJseSBzbG93LiAKPiBFdmVuIGF0IHRoaXMgbG93IHNwZWVkLCB0aGUgQ1BVIGRv ZXMgbm90IGNvb2wgZG93biBsb3dlciB0aGVuIDQ3IHNvCj4gdGhlIENQVSBpcyBzdHVjayBhdCBs b3dlc3QgcG9zc2libGUgZnJlcXVlbmN5IHVudGlsIGl0IHNodXQgZG93biBhbmQKPiBzdGF5cyBv ZmYgZm9yIDE1IG1pbnV0ZXMuCj4gCj4gY29vbGluZy1kZXZpY2UgPSA8JmNwdTAgVEhFUk1BTF9O T19MSU1JVCBUSEVSTUFMX05PX0xJTUlUPiwKPiAgICAgICAgICAgICAgICAgIDwmY3B1MSBUSEVS TUFMX05PX0xJTUlUIFRIRVJNQUxfTk9fTElNSVQ+Owo+IAo+IFRoaXMgc2hvdWxkIG5vdCBiZSBz ZXQgYWwgZXZlcnkgY29vbGluZyBtYXAuIEl0IHNob3VsZCBvbmx5IGJlIHNldCBhdAo+IHRoZSBo aWdoZXN0IGNvb2xpbmcgbWFwLiBTYW1lIGFzIGluIHRoZSBleGFtcGxlOgo+IAo+IGh0dHBzOi8v d3d3Lmtlcm5lbC5vcmcvZG9jL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy8KPiB0 aGVybWFsL3RoZXJtYWwudHh0ICBsaW5lIDI3Mgo+IAo+IEJ1dCB0aGVuIHdpdGhvdXQgdGhlIGZh biBhbmQgYWRkZWQgYSB0aGlyZCBtYXAuCj4gCj4gTm93IHRlbXBlcmF0dXJlIHdpbGwgYmUgcmVn dWxhdGVkIGF0IDg3IGRlZ3JlZXMgY2VsY2l1cy4gQXQgdGVtcGVyYXR1cmVzCj4gbG93ZXIgdGhl biA4NywgYWxsIGZyZXF1ZW5jaWVzIGNhbiBiZSB1c2VkLgoKNDfCsEMgaXMgcmVhbGx5IGEgdG9v IGxvdyB0ZW1wZXJhdHVyZSBhbmQgdGhpcyBwZXJmb3JtYW5jZSBkcm9wIGlzIG5vcm1hbC4KCkkg d291bGQgbm90IHJlbW92ZSB0aGUgcGFzc2l2ZSBtaXRpZ2F0aW9uIGJ1dCB0cnkgYnkgaW5jcmVh c2luZyB0aGUgQ1BVCnRlbXAgdG8gNzDCsEMgYW5kIGJ5IGNoYW5naW5nIHRoZSBhY3RpdmUgdHJp cCBwb2ludCB0byA4MMKwQy4gSWYgaXQgd29ya3MKZmluZSwgdHJ5IDc1wrBDIGFuZCA4NcKwQy4K ClRvIHRlc3QsIHRoZSB0aGVybWFsIGtpbGxlciBpcyBkaHJ5c3RvbmUgKG9uZSB0aHJlYWQgcGVy IGNwdSkuCgpXaXRoIGEgNzXCsEMgcGFzc2l2ZSB0cmlwIHBvaW50LCB0aGUgc3RlcCB3aXNlIHRo ZXJtYWwgZ292ZXJub3IsIEkgdGhpbmsKdGhlIG1pdGlnYXRpb24gd2lsbCBoYXBwZW4gc21vb3Ro bHkgcHJvdmlkaW5nIGJldHRlciBwZXJmb3JtYW5jZXMsIGFuZApwcm9iYWJseSB0aGUgZmFuIHdv bid0IGZpcmUuCgo+IEFsc28gc2VlIHRoZSBwb3N0Ogo+IAo+IGh0dHA6Ly9mb3J1bS5iYW5hbmEt cGkub3JnL3QvYnBpLXI2NC1vbmx5LTEwLWNwdS1zcGVlZC1hdC1hbHJlYWR5LTQ4LQo+IGRlZ3Jl ZXMtY2VsY2l1cy1zcGVlZC1ub3QtaW5jcmVhc2luZy1hbnltb3JlLzEyMjYyCj4gCj4gU2lnbmVk LW9mZi1ieTogRXJpYyBXb3Vkc3RyYSA8ZXJpY3dvdWRzQGdtYWlsLmNvbT4KPiAtLS0KPiAgYXJj aC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDc2MjIuZHRzaSB8IDggKysrKy0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDc2MjIuZHRzaSBiL2FyY2gvYXJt NjQvYm9vdC9kdHMvbWVkaWF0ZWsvbXQ3NjIyLmR0c2kKPiBpbmRleCA4OTBhOTQyZWMuLmI3Nzlj N2FhNiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL21lZGlhdGVrL210NzYyMi5k dHNpCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9tZWRpYXRlay9tdDc2MjIuZHRzaQo+IEBA IC0xNzAsMTQgKzE3MCwxNCBAQCBjcHUtY3JpdCB7Cj4gIAkJCWNvb2xpbmctbWFwcyB7Cj4gIAkJ CQltYXAwIHsKPiAgCQkJCQl0cmlwID0gPCZjcHVfcGFzc2l2ZT47Cj4gLQkJCQkJY29vbGluZy1k ZXZpY2UgPSA8JmNwdTAgVEhFUk1BTF9OT19MSU1JVCBUSEVSTUFMX05PX0xJTUlUPiwKPiAtCQkJ CQkJCSA8JmNwdTEgVEhFUk1BTF9OT19MSU1JVCBUSEVSTUFMX05PX0xJTUlUPjsKPiArCQkJCQlj b29saW5nLWRldmljZSA9IDwmY3B1MCAwIDA+LAo+ICsJCQkJCQkJIDwmY3B1MSAwIDA+Owo+ICAJ CQkJfTsKPiAgCj4gIAkJCQltYXAxIHsKPiAgCQkJCQl0cmlwID0gPCZjcHVfYWN0aXZlPjsKPiAt CQkJCQljb29saW5nLWRldmljZSA9IDwmY3B1MCBUSEVSTUFMX05PX0xJTUlUIFRIRVJNQUxfTk9f TElNSVQ+LAo+IC0JCQkJCQkJIDwmY3B1MSBUSEVSTUFMX05PX0xJTUlUIFRIRVJNQUxfTk9fTElN SVQ+Owo+ICsJCQkJCWNvb2xpbmctZGV2aWNlID0gPCZjcHUwIDAgMD4sCj4gKwkJCQkJCQkgPCZj cHUxIDAgMD47Cj4gIAkJCQl9Owo+ICAKPiAgCQkJCW1hcDIgewo+IAoKCi0tIAo8aHR0cDovL3d3 dy5saW5hcm8ub3JnLz4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFS TSBTb0NzCgpGb2xsb3cgTGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJvb2suY29tL3BhZ2VzL0xp bmFybz4gRmFjZWJvb2sgfAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4gVHdpdHRl ciB8CjxodHRwOi8vd3d3LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBCbG9nCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==