All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: t5318-commit-graph.sh breaks travis gettext poison job
Date: Fri, 1 Jun 2018 13:16:09 -0400	[thread overview]
Message-ID: <e3181d02-34cc-fbfb-367b-1d9172930c10@gmail.com> (raw)
In-Reply-To: <CACsJy8CRgkyjcpK3FPaF7mrAuEFjGOShNjBZgjgrshg365T3Rw@mail.gmail.com>

On 6/1/2018 12:17 PM, Duy Nguyen wrote:
> In case you're not checking travis, [1] reports
>
> Test Summary Report
> -------------------
> t5318-commit-graph.sh                            (Wstat: 256 Tests: 62
> Failed: 2)
>    Failed tests:  61-62
>    Non-zero exit status: 1
>
> This usually means you're grepping an i18n string
>
> [1] https://travis-ci.org/git/git/jobs/386532326
>

Thanks, Duy. I believe this is related to the place Szeder pointed out 
[1] with the one translatable string in verify_commit_graph().

I've fixed this in my local branch, and plan to push v4 when review of 
v3 is complete.

Thanks,
-Stolee

[1] 
https://public-inbox.org/git/20180530123529.32090-1-szeder.dev@gmail.com/
     Re: [PATCH v3 16/20] commit-graph: verify contents match checksum

      reply	other threads:[~2018-06-01 17:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 16:17 t5318-commit-graph.sh breaks travis gettext poison job Duy Nguyen
2018-06-01 17:16 ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3181d02-34cc-fbfb-367b-1d9172930c10@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.