From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B879C433F5 for ; Mon, 21 Mar 2022 19:41:23 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.293185.497968 (Exim 4.92) (envelope-from ) id 1nWNtv-0005Jn-KD; Mon, 21 Mar 2022 19:41:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 293185.497968; Mon, 21 Mar 2022 19:41:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWNtv-0005Jg-GU; Mon, 21 Mar 2022 19:41:11 +0000 Received: by outflank-mailman (input) for mailman id 293185; Mon, 21 Mar 2022 19:41:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWNtu-0005JW-P2 for xen-devel@lists.xenproject.org; Mon, 21 Mar 2022 19:41:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWNtm-00064U-U9; Mon, 21 Mar 2022 19:41:02 +0000 Received: from [54.239.6.185] (helo=[192.168.25.135]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nWNtm-0006j3-Nj; Mon, 21 Mar 2022 19:41:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Lwb+Ud3rxoFVzhlAe7JZt98Dev9ugj1ZkrtGoWn9cMQ=; b=B5mEm0pWKYIJOFDtRjuINKOqaR GTsAkqNYp3liMtJma56GpwcLO7YlUNPeMm5eIJelflhXuDfdjSlsjDuOFDZDHfmNg8mCpZdpC3v1c jTU+HYlNneGdOVurWt5aHN85DPIunqe5ITt55Ouysuiye3+HPM667iO7sILcCyCLpjjI=; Message-ID: Date: Mon, 21 Mar 2022 19:41:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] xen/arm: Add i.MX8QM platform support To: Peng Fan , "Peng Fan (OSS)" , "sstabellini@kernel.org" , "Volodymyr_Babchuk@epam.com" , "bertrand.marquis@arm.com" Cc: "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "jbeulich@suse.com" , "wl@xen.org" , "xen-devel@lists.xenproject.org" , "van.freenix@gmail.com" References: <20220228010711.11566-1-peng.fan@oss.nxp.com> <20220228010711.11566-4-peng.fan@oss.nxp.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Peng, On 18/03/2022 05:24, Peng Fan wrote: >> Subject: Re: [PATCH 3/3] xen/arm: Add i.MX8QM platform support >> On 28/02/2022 01:07, Peng Fan (OSS) wrote: >>> +static const char * const imx8qm_dt_compat[] __initconst = { >>> + "fsl,imx8qm", >>> + NULL >>> +}; >>> + >>> +PLATFORM_START(imx8qm, "i.MX 8") >>> + .compatible = imx8qm_dt_compat, >>> +PLATFORM_END >> >> We are only adding new platform definition when quirks are necessary. Do >> you need specific quirks for the i.MX8QM? >> >> A somewhat related question, is this series enough to boot Xen upstream on >> the board? > > Boot xen upstream, no need specific quirk. That's great to hear! Then this file should not be necessary at all. Please drop it. Cheers, -- Julien Grall