All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH 3/4] mm/memory: convert do_shared_fault() to folios
Date: Mon, 3 Jul 2023 19:18:57 -0700	[thread overview]
Message-ID: <e32f52b1-a983-d569-4645-a6eee2ccd78b@oracle.com> (raw)
In-Reply-To: <ZKNaVJCDH7ac8SCu@casper.infradead.org>

On 7/3/23 4:31 PM, Matthew Wilcox wrote:
> On Sun, Jul 02, 2023 at 10:58:49PM -0700, Sidhartha Kumar wrote:
>> Saves three implicit calls to compound_head().
>>
>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>> ---
>>   mm/memory.c | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index 93480e846ace6..33bf13431974c 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -4594,6 +4594,7 @@ static vm_fault_t do_shared_fault(struct vm_fault *vmf)
>>   {
>>   	struct vm_area_struct *vma = vmf->vma;
>>   	vm_fault_t ret, tmp;
>> +	struct folio *folio = page_folio(vmf->page);
> 
> You can't call page_folio() until after __do_fault().  Did you test this
> series?

I thought it would be straightforward enough without testing but I 
didn't realize the initialization in __do_fault(). I will test and 
incorporate the other suggestions for a v2.

Thanks
> 
>>   	ret = __do_fault(vmf);
>>   	if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))


  reply	other threads:[~2023-07-04  2:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03  5:58 [PATCH 1/4] mm/memory: convert do_page_mkwrite() to use folios Sidhartha Kumar
2023-07-03  5:58 ` [PATCH 2/4] mm/memory: convert wp_page_shared() " Sidhartha Kumar
2023-07-03  9:29   ` zhangpeng (AS)
2023-07-03 23:29   ` Matthew Wilcox
2023-07-03  5:58 ` [PATCH 3/4] mm/memory: convert do_shared_fault() to folios Sidhartha Kumar
2023-07-03  9:29   ` zhangpeng (AS)
2023-07-03 22:05   ` SeongJae Park
2023-07-04  2:25     ` Sidhartha Kumar
2023-07-03 23:31   ` Matthew Wilcox
2023-07-04  2:18     ` Sidhartha Kumar [this message]
2023-07-03  5:58 ` [PATCH 4/4] mm/memory: convert do_read_fault() to use folios Sidhartha Kumar
2023-07-03  9:29   ` zhangpeng (AS)
2023-07-03 23:32   ` Matthew Wilcox
2023-07-03  9:29 ` [PATCH 1/4] mm/memory: convert do_page_mkwrite() " zhangpeng (AS)
2023-07-03 23:25 ` Matthew Wilcox
2023-07-04 19:35 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e32f52b1-a983-d569-4645-a6eee2ccd78b@oracle.com \
    --to=sidhartha.kumar@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.