From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE73C433DB for ; Tue, 16 Mar 2021 10:31:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96DB165026 for ; Tue, 16 Mar 2021 10:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236691AbhCPKbQ (ORCPT ); Tue, 16 Mar 2021 06:31:16 -0400 Received: from smtp124.ord1c.emailsrvr.com ([108.166.43.124]:34367 "EHLO smtp124.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236599AbhCPKas (ORCPT ); Tue, 16 Mar 2021 06:30:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1615890645; bh=HKRipzT9Y4Y7AD4RUtA9VrCLd8S8c4Q7++26hm0spEw=; h=Subject:To:From:Date:From; b=WgWzVeUpqrSjo13ZutIqGnZXQ5rmm3R7o09WbmaFKzalD5jkK++RmXpD5m1kG9lPR cN9NuZfJ/20i+iXTaj7BmgSt13a4I4s3+NPdesKXMOu8jBwmAcYbfMY4/V7NqdBgDS 8kSR3WUztKlBiEf+WNe1t+Z8jy/TLxwsbRa6s8zg= X-Auth-ID: abbotti@mev.co.uk Received: by smtp16.relay.ord1c.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id EA9DBC0172; Tue, 16 Mar 2021 06:30:44 -0400 (EDT) Subject: Re: [PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn To: Tong Zhang , H Hartley Sweeten , Greg Kroah-Hartman , "Alexander A. Klimov" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <393f3925-9dbf-72e5-4d9b-2e213a6a71cb@mev.co.uk> <20210315195914.4801-1-ztong0001@gmail.com> From: Ian Abbott Organization: MEV Ltd. Message-ID: Date: Tue, 16 Mar 2021 10:30:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210315195914.4801-1-ztong0001@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Classification-ID: 1c471611-caf7-4948-a24b-76b433eb8e78-1-1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/2021 19:59, Tong Zhang wrote: > request_irq() wont accept a name which contains slash so we need to > repalce it with something else -- otherwise it will trigger a warning > and the entry in /proc/irq/ will not be created > since the .name might be used by userspace and we don't want to break > userspace, so we are changing the parameters passed to request_irq() > > [ 1.630764] name 'pci-das1602/16' > [ 1.630950] WARNING: CPU: 0 PID: 181 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0 > [ 1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0 > [ 1.639441] Call Trace: > [ 1.639976] proc_mkdir+0x18/0x20 > [ 1.641946] request_threaded_irq+0xfe/0x160 > [ 1.642186] cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas] > > Suggested-by: Ian Abbott > Signed-off-by: Tong Zhang > --- > v2: revert changes to .name field so that we dont break userspace > > drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c > index d740c4782775..2f20bd56ec6c 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas.c > @@ -1281,7 +1281,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev, > devpriv->amcc + AMCC_OP_REG_INTCSR); > > ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED, > - dev->board_name, dev); > + "cb_pcidas", dev); > if (ret) { > dev_dbg(dev->class_dev, "unable to allocate irq %d\n", > pcidev->irq); > Looks good. Reviewed-by: Ian Abbott -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10822C433DB for ; Tue, 16 Mar 2021 10:30:51 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9358265026 for ; Tue, 16 Mar 2021 10:30:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9358265026 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mev.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5AFFF43028; Tue, 16 Mar 2021 10:30:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XJype382sIze; Tue, 16 Mar 2021 10:30:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 4322743029; Tue, 16 Mar 2021 10:30:49 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 538AD1BF23B for ; Tue, 16 Mar 2021 10:30:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 49EC983134 for ; Tue, 16 Mar 2021 10:30:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=mev.co.uk Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gYlvP98pqA4a for ; Tue, 16 Mar 2021 10:30:46 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from smtp120.ord1c.emailsrvr.com (smtp120.ord1c.emailsrvr.com [108.166.43.120]) by smtp1.osuosl.org (Postfix) with ESMTPS id 95B5383AB9 for ; Tue, 16 Mar 2021 10:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1615890645; bh=HKRipzT9Y4Y7AD4RUtA9VrCLd8S8c4Q7++26hm0spEw=; h=Subject:To:From:Date:From; b=WgWzVeUpqrSjo13ZutIqGnZXQ5rmm3R7o09WbmaFKzalD5jkK++RmXpD5m1kG9lPR cN9NuZfJ/20i+iXTaj7BmgSt13a4I4s3+NPdesKXMOu8jBwmAcYbfMY4/V7NqdBgDS 8kSR3WUztKlBiEf+WNe1t+Z8jy/TLxwsbRa6s8zg= X-Auth-ID: abbotti@mev.co.uk Received: by smtp16.relay.ord1c.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id EA9DBC0172; Tue, 16 Mar 2021 06:30:44 -0400 (EDT) Subject: Re: [PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn To: Tong Zhang , H Hartley Sweeten , Greg Kroah-Hartman , "Alexander A. Klimov" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <393f3925-9dbf-72e5-4d9b-2e213a6a71cb@mev.co.uk> <20210315195914.4801-1-ztong0001@gmail.com> From: Ian Abbott Organization: MEV Ltd. Message-ID: Date: Tue, 16 Mar 2021 10:30:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210315195914.4801-1-ztong0001@gmail.com> Content-Language: en-GB X-Classification-ID: 1c471611-caf7-4948-a24b-76b433eb8e78-1-1 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 15/03/2021 19:59, Tong Zhang wrote: > request_irq() wont accept a name which contains slash so we need to > repalce it with something else -- otherwise it will trigger a warning > and the entry in /proc/irq/ will not be created > since the .name might be used by userspace and we don't want to break > userspace, so we are changing the parameters passed to request_irq() > > [ 1.630764] name 'pci-das1602/16' > [ 1.630950] WARNING: CPU: 0 PID: 181 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0 > [ 1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0 > [ 1.639441] Call Trace: > [ 1.639976] proc_mkdir+0x18/0x20 > [ 1.641946] request_threaded_irq+0xfe/0x160 > [ 1.642186] cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas] > > Suggested-by: Ian Abbott > Signed-off-by: Tong Zhang > --- > v2: revert changes to .name field so that we dont break userspace > > drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c > index d740c4782775..2f20bd56ec6c 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas.c > @@ -1281,7 +1281,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev, > devpriv->amcc + AMCC_OP_REG_INTCSR); > > ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED, > - dev->board_name, dev); > + "cb_pcidas", dev); > if (ret) { > dev_dbg(dev->class_dev, "unable to allocate irq %d\n", > pcidev->irq); > Looks good. Reviewed-by: Ian Abbott -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=- _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel