From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E789C7E for ; Sun, 25 Sep 2022 07:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664090269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FnuW0+nquE7jeCs1wGd25t/HgD5sAtMc07QK9kih2sQ=; b=B97KTn2dpYAt61kIInCLOK/2Ro6Wst4uMijGFSzgHYRdcZYdeHN2Z3ugLtJoUKxafz8yNC sWsj/xIEwaV1yrv9Q1SsmiCxhVHRLyjrG7MDBtCipNp9CsQ1df0T63dAJdIXFk2HpFvimj SNz8dinnXFQVzc5AwMsgibAO84z47E8= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-196-7nFoMco5NfiSWhiUbHz0GQ-1; Sun, 25 Sep 2022 03:17:48 -0400 X-MC-Unique: 7nFoMco5NfiSWhiUbHz0GQ-1 Received: by mail-qt1-f198.google.com with SMTP id fz10-20020a05622a5a8a00b0035ce18717daso2685921qtb.11 for ; Sun, 25 Sep 2022 00:17:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=FnuW0+nquE7jeCs1wGd25t/HgD5sAtMc07QK9kih2sQ=; b=5LgL+c7xuNIuFoh6Vb7GFEGEM1bMAYN0OqHH3fQu0O7WwXWBIDidgTmAlc9/e6UPli eCc/eGYt6HybZS/DNCjcc/OgTuZFIpqZ4lTF1gHScqCZylg5xQqNu6B2u1RV6U5wqNY+ n/GhO9h2HlJpEZI79KGTetURfR7YUTav2sgYh1Yy2z2rdq1K4IS/08lFPQ/bteAwpznL AtvnCBIDCh57MhroyEIOG7x4Zif7YLtdfcdzgOziUkIj/9991N/tXvyM89kZYIqF1Ym4 g688H+n18RWfMd3XdSe49GBUw1HiOqycQHGxjXY5UVl+T/yuNwdINpkSIDTIHZLmKhPY p/Wg== X-Gm-Message-State: ACrzQf2BO7drkAfemPglEkynQBZ2hLGA5TylQLduC+Vl4moTgD5TxA4d d0mdTx8tzijG4LOi1tvkmYiig9BSOnlTxbGuRw4QvutH6cIDBpMvi6vN6NfCEi6Tsoa+/sbxqHP pjWAVJm3OnzVfdQ== X-Received: by 2002:a05:620a:c8f:b0:6cb:e329:b5b9 with SMTP id q15-20020a05620a0c8f00b006cbe329b5b9mr10667188qki.95.1664090268096; Sun, 25 Sep 2022 00:17:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4u6YF4dJIrwAN1QRZGgvTOpwH6qKYsc23O//LxYiiudu83+P6fv+LpA21i63RBBqqlayo//g== X-Received: by 2002:a05:620a:c8f:b0:6cb:e329:b5b9 with SMTP id q15-20020a05620a0c8f00b006cbe329b5b9mr10667159qki.95.1664090267816; Sun, 25 Sep 2022 00:17:47 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-97-96.dyn.eolo.it. [146.241.97.96]) by smtp.gmail.com with ESMTPSA id bp30-20020a05620a459e00b006c479acd82fsm10375465qkb.7.2022.09.25.00.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 00:17:47 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size From: Paolo Abeni To: Kees Cook , Vlastimil Babka Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, "Ruhl, Michael J" , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Greg Kroah-Hartman , Nick Desaulniers , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , Christian =?ISO-8859-1?Q?K=F6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Marco Elver , Miguel Ojeda , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Date: Sun, 25 Sep 2022 09:17:40 +0200 In-Reply-To: <20220923202822.2667581-5-keescook@chromium.org> References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-5-keescook@chromium.org> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Fri, 2022-09-23 at 13:28 -0700, Kees Cook wrote: > All callers of APIs that allowed a 0-sized frag_size appear to be > passing actual size information already AFAICS, not yet: drivers/net/ethernet/qlogic/qed/qed_ll2.c: skb = build_skb(buffer->data, 0); // -> __build_skb(..., 0)  // -> __build_skb_around() drivers/net/ethernet/broadcom/bnx2.c: skb = build_skb(data, 0); I guess some more drivers have calls leading to  __build_skb_around(..., 0) there are several call path to checks... > , so this use of ksize() can > be removed. However, just in case there is something still depending > on this behavior, issue a WARN and fall back to as before to ksize() > which means we'll also potentially get KASAN warnings. > > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > net/core/skbuff.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 0b30fbdbd0d0..84ca89c781cd 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -195,7 +195,11 @@ static void __build_skb_around(struct sk_buff *skb, void *data, > unsigned int frag_size) > { > struct skb_shared_info *shinfo; > - unsigned int size = frag_size ? : ksize(data); > + unsigned int size = frag_size; > + > + /* All callers should be setting frag size now? */ > + if (WARN_ON_ONCE(size == 0)) > + size = ksize(data); At some point in the future, I guess we could even drop this check, right? Thanks! Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA6DAC04A95 for ; Sun, 25 Sep 2022 07:18:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0953210E034; Sun, 25 Sep 2022 07:17:58 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6FA410E034 for ; Sun, 25 Sep 2022 07:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664090271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FnuW0+nquE7jeCs1wGd25t/HgD5sAtMc07QK9kih2sQ=; b=eL8jdSv/xP8oQepr+ntx2m95s3kpRqYEG83jh0sUhsB8ISjPX3cuUhXz5KU2U5SiWu/1lt 5EfU7CMW4DX1uNXw2GdpY42DTZk6rGlJhM99J+wCGjV9F7JY5Zzu+e1ax4sfHE2vAKSqp3 U8AnrRIOHIz2hv2hhrx5t56Po0ftAbk= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-124-ba8vyfjxO3-gpv5wBoy4xQ-1; Sun, 25 Sep 2022 03:17:48 -0400 X-MC-Unique: ba8vyfjxO3-gpv5wBoy4xQ-1 Received: by mail-qt1-f200.google.com with SMTP id g21-20020ac87d15000000b0035bb6f08778so2701731qtb.2 for ; Sun, 25 Sep 2022 00:17:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=FnuW0+nquE7jeCs1wGd25t/HgD5sAtMc07QK9kih2sQ=; b=zp9e+c1I+ebpQgBkZALeK73OguFFUD1AB4CzEgefPXpDqRSpTsPyDxpqxnYw3WIz57 QaAYH+Xgtdn4setOamOTI/9ysgZCHEEnS2mzCm3DsQwvh+SAQR9cNfeQ+i+YRJj6o7aW ciSBgGS7EEYEbuFO/OEbt0J7ErCyrkK+HHPIkbYuCzdNq0ClQBchgNmrzw2kDSRmzfO7 ID1/V1cqoq5HeWZYL+gKkloP5IbZYqU8vpr09yYjtI95wujocEYyrwFRwYbMemQpcXLY kKPAJSwNxpuJBI1196y7WGuoAyTEyq0V31KEWRQEvom5fSHHlMAW+7HT92/nLf97Hhz1 HHdw== X-Gm-Message-State: ACrzQf25bON+Uv+9uP+sOVqtsJsJqKX7OqtTRtyS08Z0RYRDghDS0+a3 lwDZaIktmA1KhVR9G4RtG9Sdn0pwBkSPizHtqPQEnOBfyyAJUyikye6ov+xneljbfZvmtHAmdel WrMLKCAy4SS7b197oaAkaaSchEhmi X-Received: by 2002:a05:620a:c8f:b0:6cb:e329:b5b9 with SMTP id q15-20020a05620a0c8f00b006cbe329b5b9mr10667199qki.95.1664090268102; Sun, 25 Sep 2022 00:17:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4u6YF4dJIrwAN1QRZGgvTOpwH6qKYsc23O//LxYiiudu83+P6fv+LpA21i63RBBqqlayo//g== X-Received: by 2002:a05:620a:c8f:b0:6cb:e329:b5b9 with SMTP id q15-20020a05620a0c8f00b006cbe329b5b9mr10667159qki.95.1664090267816; Sun, 25 Sep 2022 00:17:47 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-97-96.dyn.eolo.it. [146.241.97.96]) by smtp.gmail.com with ESMTPSA id bp30-20020a05620a459e00b006c479acd82fsm10375465qkb.7.2022.09.25.00.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 00:17:47 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size From: Paolo Abeni To: Kees Cook , Vlastimil Babka Date: Sun, 25 Sep 2022 09:17:40 +0200 In-Reply-To: <20220923202822.2667581-5-keescook@chromium.org> References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-5-keescook@chromium.org> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, dri-devel@lists.freedesktop.org, "Ruhl, Michael J" , Eric Dumazet , linux-hardening@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Sumit Semwal , dev@openvswitch.org, x86@kernel.org, Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, David Rientjes , Miguel Ojeda , Yonghong Song , linux-media@vger.kernel.org, Marco Elver , Josef Bacik , linaro-mm-sig@lists.linaro.org, Jakub Kicinski , David Sterba , Joonsoo Kim , Alex Elder , linux-mm@kvack.org, Greg Kroah-Hartman , Nick Desaulniers , linux-kernel@vger.kernel.org, "David S. Miller" , Pekka Enberg , Daniel Micay , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Christian =?ISO-8859-1?Q?K=F6nig?= , linux-btrfs@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 2022-09-23 at 13:28 -0700, Kees Cook wrote: > All callers of APIs that allowed a 0-sized frag_size appear to be > passing actual size information already AFAICS, not yet: drivers/net/ethernet/qlogic/qed/qed_ll2.c: skb = build_skb(buffer->data, 0); // -> __build_skb(..., 0)  // -> __build_skb_around() drivers/net/ethernet/broadcom/bnx2.c: skb = build_skb(data, 0); I guess some more drivers have calls leading to  __build_skb_around(..., 0) there are several call path to checks... > , so this use of ksize() can > be removed. However, just in case there is something still depending > on this behavior, issue a WARN and fall back to as before to ksize() > which means we'll also potentially get KASAN warnings. > > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > net/core/skbuff.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 0b30fbdbd0d0..84ca89c781cd 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -195,7 +195,11 @@ static void __build_skb_around(struct sk_buff *skb, void *data, > unsigned int frag_size) > { > struct skb_shared_info *shinfo; > - unsigned int size = frag_size ? : ksize(data); > + unsigned int size = frag_size; > + > + /* All callers should be setting frag size now? */ > + if (WARN_ON_ONCE(size == 0)) > + size = ksize(data); At some point in the future, I guess we could even drop this check, right? Thanks! Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 774E0C04A95 for ; Sun, 25 Sep 2022 07:17:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1495560B10; Sun, 25 Sep 2022 07:17:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1495560B10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1664090276; bh=PNOcwoV4HE7e3fXUjZd4heQgoYQkX5yAQoeMrFVR2Ao=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=GFuq31mwjcv9LajKH8oGqRQ0HOt1ZJXGV3Y2baUmpW2VyeAe3yI+AW2iujpfW7OAI byZ0zE2oAIbaxt77QM8zeipZ5+qww28gDxM9wnF+YxHJNTcvigdJO4nWu03tHdDKwP Z4pXe5eCvO0PBFJUaxzWOsvuDzvDbSJl3/9fP9eSNqL1hUqQ6oynWUjImNANsksWYY zn4ayXoJLvpfEDT93QlB0k9DN0+V5x2MwCEOs4O6dAswgWHfraAeQveZoqi7TrT+4y lRzNS02o6FZJerTztHwsNov0YIa1hLIpP1sXeTXWif0JXQq/jirCKjCcCfmN2adWYk jR+07jn6u9exA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RrzN8zj-n8Em; Sun, 25 Sep 2022 07:17:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 0B82360761; Sun, 25 Sep 2022 07:17:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0B82360761 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id C9D9B1BF5DC for ; Sun, 25 Sep 2022 07:17:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9A4D383F16 for ; Sun, 25 Sep 2022 07:17:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9A4D383F16 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mrj9BD5rNWCi for ; Sun, 25 Sep 2022 07:17:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9AFED83F11 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9AFED83F11 for ; Sun, 25 Sep 2022 07:17:51 +0000 (UTC) Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-301-mnBVV0PwO9WfvQq0WDzGoQ-1; Sun, 25 Sep 2022 03:17:48 -0400 X-MC-Unique: mnBVV0PwO9WfvQq0WDzGoQ-1 Received: by mail-qv1-f72.google.com with SMTP id e19-20020ad44433000000b004aaa7d00846so2434921qvt.0 for ; Sun, 25 Sep 2022 00:17:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=FnuW0+nquE7jeCs1wGd25t/HgD5sAtMc07QK9kih2sQ=; b=KAkn8PpH8bzZHuq39pMj7ddJgT0pRYblyunGOGBrp/TOcCYwPqtN5EEaSUDCMlT3eo pN5UzYqOdNwDOxRKBu09X2J0La37TdTFFeqSL1L9nfosKWpz1nR9UnxLlZ6rOUQfwlEg 42apMNrVY5RgQpxIWtO9+HFJnG2ZBP7p1R1mwoUoinCK3Yni0dygo1bLMm8ZWZR3luhT fucfRoAyyVKPh87FpZDTieu2dDypVYDdOmaDUEyk7J9pN1sqoOolL8qWj0YJ3Illkozg nsTofAGQCDQX1RfYvBB4uq8CV6DntuaeOk1ENem0WvKozPh8a+yDcRj7BL4bV3kALPU/ GCKw== X-Gm-Message-State: ACrzQf3oy0WC8lxInQ+buIBM2kBDzUTxOG7l6Eag32QDnmKHfov85Jy+ 5uLdUARsfaUFYIBd/GXOsqlCsgZbGcVz60bdoFbKq5+RbyN4XlklS7HRD93wx+tG+vrBZpvaJ01 VgTfYSnYVgn3yLwzPDEtwU8zsgd8Wrg== X-Received: by 2002:a05:620a:c8f:b0:6cb:e329:b5b9 with SMTP id q15-20020a05620a0c8f00b006cbe329b5b9mr10667169qki.95.1664090268094; Sun, 25 Sep 2022 00:17:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4u6YF4dJIrwAN1QRZGgvTOpwH6qKYsc23O//LxYiiudu83+P6fv+LpA21i63RBBqqlayo//g== X-Received: by 2002:a05:620a:c8f:b0:6cb:e329:b5b9 with SMTP id q15-20020a05620a0c8f00b006cbe329b5b9mr10667159qki.95.1664090267816; Sun, 25 Sep 2022 00:17:47 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-97-96.dyn.eolo.it. [146.241.97.96]) by smtp.gmail.com with ESMTPSA id bp30-20020a05620a459e00b006c479acd82fsm10375465qkb.7.2022.09.25.00.17.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 00:17:47 -0700 (PDT) Message-ID: From: Paolo Abeni To: Kees Cook , Vlastimil Babka Date: Sun, 25 Sep 2022 09:17:40 +0200 In-Reply-To: <20220923202822.2667581-5-keescook@chromium.org> References: <20220923202822.2667581-1-keescook@chromium.org> <20220923202822.2667581-5-keescook@chromium.org> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664090270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FnuW0+nquE7jeCs1wGd25t/HgD5sAtMc07QK9kih2sQ=; b=SZBL0yllgncMHQJjYqneGvfhQm2AeybNL8PYw1Bfent43/fRlxWvUxkC/D/nmTltqWC4Ni 22qTmVCLexiT0Ag0Ho1YAYPfMzOY+P42y+y33CKftoPcY/OThEMaUdzmmOltw3hbApVM83 asdnwLDr1xKa8tvz4sXNyRRhsXEeWiE= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SZBL0yll Subject: Re: [Intel-wired-lan] [PATCH v2 04/16] skbuff: Phase out ksize() fallback for frag_size X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, dri-devel@lists.freedesktop.org, "Ruhl, Michael J" , Eric Dumazet , linux-hardening@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Sumit Semwal , dev@openvswitch.org, x86@kernel.org, intel-wired-lan@lists.osuosl.org, David Rientjes , Miguel Ojeda , Yonghong Song , linux-media@vger.kernel.org, Marco Elver , Josef Bacik , linaro-mm-sig@lists.linaro.org, Jakub Kicinski , David Sterba , Joonsoo Kim , Alex Elder , linux-mm@kvack.org, Greg Kroah-Hartman , Nick Desaulniers , linux-kernel@vger.kernel.org, "David S. Miller" , Pekka Enberg , Daniel Micay , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Christian =?ISO-8859-1?Q?K=F6nig?= , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gRnJpLCAyMDIyLTA5LTIzIGF0IDEzOjI4IC0wNzAwLCBLZWVzIENvb2sgd3JvdGU6Cj4gQWxs IGNhbGxlcnMgb2YgQVBJcyB0aGF0IGFsbG93ZWQgYSAwLXNpemVkIGZyYWdfc2l6ZSBhcHBlYXIg dG8gYmUKPiBwYXNzaW5nIGFjdHVhbCBzaXplIGluZm9ybWF0aW9uIGFscmVhZHkKCkFGQUlDUywg bm90IHlldDoKCmRyaXZlcnMvbmV0L2V0aGVybmV0L3Fsb2dpYy9xZWQvcWVkX2xsMi5jOgoJc2ti ID0gYnVpbGRfc2tiKGJ1ZmZlci0+ZGF0YSwgMCk7IC8vIC0+IF9fYnVpbGRfc2tiKC4uLiwgMCnC oAoJCS8vIC0+ICBfX2J1aWxkX3NrYl9hcm91bmQoKQoKZHJpdmVycy9uZXQvZXRoZXJuZXQvYnJv YWRjb20vYm54Mi5jOgoJc2tiID0gYnVpbGRfc2tiKGRhdGEsIDApOwoKSSBndWVzcyBzb21lIG1v cmUgZHJpdmVycyBoYXZlIGNhbGxzIGxlYWRpbmcgdG/CoAoKCV9fYnVpbGRfc2tiX2Fyb3VuZCgu Li4sICAwKQoKdGhlcmUgYXJlIHNldmVyYWwgY2FsbCBwYXRoIHRvIGNoZWNrcy4uLgoKCj4gLCBz byB0aGlzIHVzZSBvZiBrc2l6ZSgpIGNhbgo+IGJlIHJlbW92ZWQuIEhvd2V2ZXIsIGp1c3QgaW4g Y2FzZSB0aGVyZSBpcyBzb21ldGhpbmcgc3RpbGwgZGVwZW5kaW5nCj4gb24gdGhpcyBiZWhhdmlv ciwgaXNzdWUgYSBXQVJOIGFuZCBmYWxsIGJhY2sgdG8gYXMgYmVmb3JlIHRvIGtzaXplKCkKPiB3 aGljaCBtZWFucyB3ZSdsbCBhbHNvIHBvdGVudGlhbGx5IGdldCBLQVNBTiB3YXJuaW5ncy4KPiAK PiBDYzogIkRhdmlkIFMuIE1pbGxlciIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+Cj4gQ2M6IEVyaWMg RHVtYXpldCA8ZWR1bWF6ZXRAZ29vZ2xlLmNvbT4KPiBDYzogSmFrdWIgS2ljaW5za2kgPGt1YmFA a2VybmVsLm9yZz4KPiBDYzogUGFvbG8gQWJlbmkgPHBhYmVuaUByZWRoYXQuY29tPgo+IENjOiBu ZXRkZXZAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogS2VlcyBDb29rIDxrZWVzY29v a0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIG5ldC9jb3JlL3NrYnVmZi5jIHwgMTggKysrKysrKysr Ky0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9uZXQvY29yZS9za2J1ZmYuYyBiL25ldC9jb3JlL3NrYnVm Zi5jCj4gaW5kZXggMGIzMGZiZGJkMGQwLi44NGNhODljNzgxY2QgMTAwNjQ0Cj4gLS0tIGEvbmV0 L2NvcmUvc2tidWZmLmMKPiArKysgYi9uZXQvY29yZS9za2J1ZmYuYwo+IEBAIC0xOTUsNyArMTk1 LDExIEBAIHN0YXRpYyB2b2lkIF9fYnVpbGRfc2tiX2Fyb3VuZChzdHJ1Y3Qgc2tfYnVmZiAqc2ti LCB2b2lkICpkYXRhLAo+ICAJCQkgICAgICAgdW5zaWduZWQgaW50IGZyYWdfc2l6ZSkKPiAgewo+ ICAJc3RydWN0IHNrYl9zaGFyZWRfaW5mbyAqc2hpbmZvOwo+IC0JdW5zaWduZWQgaW50IHNpemUg PSBmcmFnX3NpemUgPyA6IGtzaXplKGRhdGEpOwo+ICsJdW5zaWduZWQgaW50IHNpemUgPSBmcmFn X3NpemU7Cj4gKwo+ICsJLyogQWxsIGNhbGxlcnMgc2hvdWxkIGJlIHNldHRpbmcgZnJhZyBzaXpl IG5vdz8gKi8KPiArCWlmIChXQVJOX09OX09OQ0Uoc2l6ZSA9PSAwKSkKPiArCQlzaXplID0ga3Np emUoZGF0YSk7CgpBdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUsIEkgZ3Vlc3Mgd2UgY291bGQg ZXZlbiBkcm9wIHRoaXMgY2hlY2ssCnJpZ2h0PwoKVGhhbmtzIQoKUGFvbG8KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWls aW5nIGxpc3QKSW50ZWwtd2lyZWQtbGFuQG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wu b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtd2lyZWQtbGFuCg==