From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FEFC433DB for ; Mon, 29 Mar 2021 10:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78074617C9 for ; Mon, 29 Mar 2021 10:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232245AbhC2KNz (ORCPT ); Mon, 29 Mar 2021 06:13:55 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:48251 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232171AbhC2KNg (ORCPT ); Mon, 29 Mar 2021 06:13:36 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12TA7tlR024122; Mon, 29 Mar 2021 12:13:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=5lhL+1yJCWVc0eL98c9m1itsZeuzV5uyY3nD88yw/xo=; b=NYwgPqidQtt/Ob4UBk9fTXGvYjH0uWvxGx+ScD87cnTztJDNJn2+6THwhsPYKSwWQkig BUFlnV1fZTI78YXLYbupwhFV/bLOjtnZZRyKnoKZfvrONUcLZxwkUxl6Nq12gwHTbzGL kPCbNpP87+Qf+Si6H58UZDk6HpTzoiMT0fXc7Y8M1+jEaK9FNiHv2+Wglp+ZeNaI8YZx byG0iE3+mCYFZflO4JThAdx9ADAfir6K6ufncosBVw8p1m5f/MNsmtIL8UBra+S/MkXs XEgB0q9QpDlweSdNP0ZsEvyHRQ7WWtD6Gkysi5391vVcyT5hl8bICEIoPgQLR5lu8hq/ RQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37jy133gwb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Mar 2021 12:13:19 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B87A5100034; Mon, 29 Mar 2021 12:13:18 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 763CA25D006; Mon, 29 Mar 2021 12:13:18 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Mar 2021 12:13:17 +0200 Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support To: dillon min CC: Rob Herring , Ahmad Fatoum , Maxime Coquelin , Alexandre Torgue , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , , Linux ARM , Linux Kernel Mailing List , , Vladimir Murzin , References: <1615530274-31422-1-git-send-email-dillon.minfei@gmail.com> <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> From: Alexandre TORGUE Message-ID: Date: Mon, 29 Mar 2021 12:13:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-29_05:2021-03-26,2021-03-29 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/21 10:07 AM, dillon min wrote: > On Mon, Mar 29, 2021 at 4:00 PM Alexandre TORGUE > wrote: >> >> Hi Dillon >> >> On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote: >>> From: dillon min >>> >>> This patch adds STM32H750 pinctrl and GPIO support >>> since stm32h750 has the same pin alternate functions >>> with stm32h743, so just reuse the stm32h743's pinctrl >>> driver >>> >>> Signed-off-by: dillon min >>> --- >>> v2: >>> - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they >>> have same pin alternate functions >>> - add STM32H750 to Kconfig description >>> >>> drivers/pinctrl/stm32/Kconfig | 2 +- >>> drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++ >>> 2 files changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig >>> index f36f29113370..fb1ffc94c57f 100644 >>> --- a/drivers/pinctrl/stm32/Kconfig >>> +++ b/drivers/pinctrl/stm32/Kconfig >>> @@ -35,7 +35,7 @@ config PINCTRL_STM32F769 >>> select PINCTRL_STM32 >>> >>> config PINCTRL_STM32H743 >>> - bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 >>> + bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743 >>> depends on OF && HAS_IOMEM >>> default MACH_STM32H743 >>> select PINCTRL_STM32 >>> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c >>> index ffe7b5271506..700206c7bc11 100644 >>> --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c >>> +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c >>> @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = { >>> .compatible = "st,stm32h743-pinctrl", >>> .data = &stm32h743_match_data, >>> }, >>> + { .compatible = "st,stm32h750-pinctrl", >>> + .data = &stm32h743_match_data, >>> + }, >> >> If you use exactly the same driver (i.e. same ball out and AF mux) then >> you don't have to create a new compatible for that. Just use the same >> than h743.(so you don't have to factorize DT files). > Okay, yes they are the total same ball out and AF mux. I will delete > it in the next submission. > Just a kindly reminder , the newest version of this patchset is [PATCH v6]. Yes I'm late :) > > Thanks. >> >> Regards >> Alex >> >>> { } >>> }; >>> >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F57C433C1 for ; Mon, 29 Mar 2021 21:38:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B44B661959 for ; Mon, 29 Mar 2021 21:38:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B44B661959 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fDAktuj8QuToBk5+IgLN9vvu/iq8MhSiZWw9t3WQ9C0=; b=hl3/JyXtJcLQaZxqEyqDDX4Wy DuHaJiO6ajjz8L2jFbZnNexBJ7EbavTktt4ziS+4EJPia8+RUEBaZfiyVUhYMv/16qjUrB1//7JfI EGTwOmfM4aW+wIgCx6cwziXmisPYT1rcudH34BQnAXo7fbkO48TsAce8aEe1HgbOtuHl3U7f2YwEi oVeu7ThZhNg0oaj6ZqYoLb6Mgb+luw5HEOfM8UiWgKUk89NVvMRqxAS3C37ucqBR8no7vb3MA1Wec RM1NXocLr7RRkntrTJ+KMaZYnqdOUcyeZhtMDp94czfBVapFXC3mRaL4Sp8irdVNoz8wC7vABTjRz gZUqhT+Tw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQzXY-001U9w-BP; Mon, 29 Mar 2021 21:35:16 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQotl-000ZU4-Dd for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 10:13:31 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12TA7tlR024122; Mon, 29 Mar 2021 12:13:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=5lhL+1yJCWVc0eL98c9m1itsZeuzV5uyY3nD88yw/xo=; b=NYwgPqidQtt/Ob4UBk9fTXGvYjH0uWvxGx+ScD87cnTztJDNJn2+6THwhsPYKSwWQkig BUFlnV1fZTI78YXLYbupwhFV/bLOjtnZZRyKnoKZfvrONUcLZxwkUxl6Nq12gwHTbzGL kPCbNpP87+Qf+Si6H58UZDk6HpTzoiMT0fXc7Y8M1+jEaK9FNiHv2+Wglp+ZeNaI8YZx byG0iE3+mCYFZflO4JThAdx9ADAfir6K6ufncosBVw8p1m5f/MNsmtIL8UBra+S/MkXs XEgB0q9QpDlweSdNP0ZsEvyHRQ7WWtD6Gkysi5391vVcyT5hl8bICEIoPgQLR5lu8hq/ RQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37jy133gwb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Mar 2021 12:13:19 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B87A5100034; Mon, 29 Mar 2021 12:13:18 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 763CA25D006; Mon, 29 Mar 2021 12:13:18 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 29 Mar 2021 12:13:17 +0200 Subject: Re: [PATCH v2 8/8] pinctrl: stm32: Add STM32H750 MCU pinctrl support To: dillon min CC: Rob Herring , Ahmad Fatoum , Maxime Coquelin , Alexandre Torgue , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , , Linux ARM , Linux Kernel Mailing List , , Vladimir Murzin , References: <1615530274-31422-1-git-send-email-dillon.minfei@gmail.com> <1615530274-31422-9-git-send-email-dillon.minfei@gmail.com> From: Alexandre TORGUE Message-ID: Date: Mon, 29 Mar 2021 12:13:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG1NODE3.st.com (10.75.127.3) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-29_05:2021-03-26, 2021-03-29 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_111329_586282_FF219C46 X-CRM114-Status: GOOD ( 25.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/29/21 10:07 AM, dillon min wrote: > On Mon, Mar 29, 2021 at 4:00 PM Alexandre TORGUE > wrote: >> >> Hi Dillon >> >> On 3/12/21 7:24 AM, dillon.minfei@gmail.com wrote: >>> From: dillon min >>> >>> This patch adds STM32H750 pinctrl and GPIO support >>> since stm32h750 has the same pin alternate functions >>> with stm32h743, so just reuse the stm32h743's pinctrl >>> driver >>> >>> Signed-off-by: dillon min >>> --- >>> v2: >>> - add compatible string st,stm32h750-pinctrl to pinctl-stm32h743.c as they >>> have same pin alternate functions >>> - add STM32H750 to Kconfig description >>> >>> drivers/pinctrl/stm32/Kconfig | 2 +- >>> drivers/pinctrl/stm32/pinctrl-stm32h743.c | 3 +++ >>> 2 files changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig >>> index f36f29113370..fb1ffc94c57f 100644 >>> --- a/drivers/pinctrl/stm32/Kconfig >>> +++ b/drivers/pinctrl/stm32/Kconfig >>> @@ -35,7 +35,7 @@ config PINCTRL_STM32F769 >>> select PINCTRL_STM32 >>> >>> config PINCTRL_STM32H743 >>> - bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 >>> + bool "STMicroelectronics STM32H743/STM32H750 pin control" if COMPILE_TEST && !MACH_STM32H743 >>> depends on OF && HAS_IOMEM >>> default MACH_STM32H743 >>> select PINCTRL_STM32 >>> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32h743.c b/drivers/pinctrl/stm32/pinctrl-stm32h743.c >>> index ffe7b5271506..700206c7bc11 100644 >>> --- a/drivers/pinctrl/stm32/pinctrl-stm32h743.c >>> +++ b/drivers/pinctrl/stm32/pinctrl-stm32h743.c >>> @@ -1966,6 +1966,9 @@ static const struct of_device_id stm32h743_pctrl_match[] = { >>> .compatible = "st,stm32h743-pinctrl", >>> .data = &stm32h743_match_data, >>> }, >>> + { .compatible = "st,stm32h750-pinctrl", >>> + .data = &stm32h743_match_data, >>> + }, >> >> If you use exactly the same driver (i.e. same ball out and AF mux) then >> you don't have to create a new compatible for that. Just use the same >> than h743.(so you don't have to factorize DT files). > Okay, yes they are the total same ball out and AF mux. I will delete > it in the next submission. > Just a kindly reminder , the newest version of this patchset is [PATCH v6]. Yes I'm late :) > > Thanks. >> >> Regards >> Alex >> >>> { } >>> }; >>> >>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel