From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F77ECE588 for ; Wed, 16 Oct 2019 07:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C81B2082C for ; Wed, 16 Oct 2019 07:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="y76gKMwR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391126AbfJPHqO (ORCPT ); Wed, 16 Oct 2019 03:46:14 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:56012 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbfJPHqN (ORCPT ); Wed, 16 Oct 2019 03:46:13 -0400 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 9015F5C2224; Wed, 16 Oct 2019 09:46:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1571211970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24LCcIRDu1mOgkMkgGbPXpwZUoN/vIELrMh+T/KtHRI=; b=y76gKMwRvWz3dUVPz5sfzwIrm2IoRP/QsBdk95pM2mzHN+u6A1RB6KiE/5ks5VUitgYDsm U1WdMT0OUhCpGuBkCkKbXerYUbMLXN9S6ijIK3o7VURhVfs57STDY+8EB9vBWT7Z8sJwtZ KrJcikDXTkE63QmPw6oOQ2X0oLL7fhg= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 16 Oct 2019 09:46:10 +0200 From: Stefan Agner To: Thierry Reding Cc: Russell King , arm@kernel.org, Arnd Bergmann , Olof Johansson , Guenter Roeck , Wolfram Sang , Catalin Marinas , Lorenzo Pieralisi , Stefano Stabellini , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] drivers: firmware: psci: Register with kernel restart handler In-Reply-To: <20191015145147.1106247-4-thierry.reding@gmail.com> References: <20191015145147.1106247-1-thierry.reding@gmail.com> <20191015145147.1106247-4-thierry.reding@gmail.com> Message-ID: X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-10-15 16:51, Thierry Reding wrote: > From: Guenter Roeck > > Register with kernel restart handler instead of setting arm_pm_restart > directly. This enables support for replacing the PSCI restart handler > with a different handler if necessary for a specific board. > > Select a priority of 129 to indicate a higher than default priority, but > keep it as low as possible since PSCI reset is known to fail on some > boards. > > Acked-by: Arnd Bergmann > Reviewed-by: Wolfram Sang > Tested-by: Wolfram Sang > Signed-off-by: Guenter Roeck > Acked-by: Lorenzo Pieralisi > Signed-off-by: Thierry Reding Looks good to me! And helps also in my case, a board which has a broken PSCI reset capability. Reviewed-by: Stefan Agner -- Stefan > --- > drivers/firmware/psci/psci.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 84f4ff351c62..a41c6ba043a2 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -250,7 +250,8 @@ static int get_set_conduit_method(struct device_node *np) > return 0; > } > > -static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > +static int psci_sys_reset(struct notifier_block *nb, unsigned long action, > + void *data) > { > if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) && > psci_system_reset2_supported) { > @@ -263,8 +264,15 @@ static void psci_sys_reset(enum reboot_mode > reboot_mode, const char *cmd) > } else { > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0); > } > + > + return NOTIFY_DONE; > } > > +static struct notifier_block psci_sys_reset_nb = { > + .notifier_call = psci_sys_reset, > + .priority = 129, > +}; > + > static void psci_sys_poweroff(void) > { > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_OFF, 0, 0, 0); > @@ -431,7 +439,7 @@ static void __init psci_0_2_set_functions(void) > > psci_ops.migrate_info_type = psci_migrate_info_type; > > - arm_pm_restart = psci_sys_reset; > + register_restart_handler(&psci_sys_reset_nb); > > pm_power_off = psci_sys_poweroff; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D7FC4360C for ; Wed, 16 Oct 2019 07:46:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C99262082C for ; Wed, 16 Oct 2019 07:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NWhd2a2a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="y76gKMwR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C99262082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To: Subject:To:From:Date:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DR2mihRWfmk/C1/dA8vr2MANdCIBELzBTLFi6D4pEqc=; b=NWhd2a2aXyZQ/T fcOM6MbSq9GidPNd4Ptbn0gVkGTLykE3xE80Ib76JVYyn954RB7wnmLaDOIkugM5ED9iPisUfJLIJ u5kwl4Ce7tTu4xELnNFMQ0ucI7+K7lZZ+cB0IJr2nwrS0e7F53P0DB6eRCKB5LOMBTKQtV+kE9LId 1vMORCvnb3StObZPl/IBRSFBQ/DhKAGCodmzAATYq6Z7Dynoefi65MQfkG3pe+rZes/0BnHJ7zp0N kMpo0tCj3H0/C1u/K1wliJvHPDEPDoncEjXVcJfD/Xa5/BxFzdz70FHTGPUHk/3BnP6/GbKzbf9+i yuvhfO2IerAjVOpK79dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKe0i-0001ZU-Q7; Wed, 16 Oct 2019 07:46:20 +0000 Received: from mail.kmu-office.ch ([2a02:418:6a02::a2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKe0f-0001YR-73 for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 07:46:19 +0000 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 9015F5C2224; Wed, 16 Oct 2019 09:46:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1571211970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24LCcIRDu1mOgkMkgGbPXpwZUoN/vIELrMh+T/KtHRI=; b=y76gKMwRvWz3dUVPz5sfzwIrm2IoRP/QsBdk95pM2mzHN+u6A1RB6KiE/5ks5VUitgYDsm U1WdMT0OUhCpGuBkCkKbXerYUbMLXN9S6ijIK3o7VURhVfs57STDY+8EB9vBWT7Z8sJwtZ KrJcikDXTkE63QmPw6oOQ2X0oLL7fhg= MIME-Version: 1.0 Date: Wed, 16 Oct 2019 09:46:10 +0200 From: Stefan Agner To: Thierry Reding Subject: Re: [PATCH 3/6] drivers: firmware: psci: Register with kernel restart handler In-Reply-To: <20191015145147.1106247-4-thierry.reding@gmail.com> References: <20191015145147.1106247-1-thierry.reding@gmail.com> <20191015145147.1106247-4-thierry.reding@gmail.com> Message-ID: X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_004617_551489_7C5AECFC X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Arnd Bergmann , Stefano Stabellini , Catalin Marinas , Russell King , linux-kernel@vger.kernel.org, Wolfram Sang , arm@kernel.org, linux-arm-kernel@lists.infradead.org, Olof Johansson , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-10-15 16:51, Thierry Reding wrote: > From: Guenter Roeck > > Register with kernel restart handler instead of setting arm_pm_restart > directly. This enables support for replacing the PSCI restart handler > with a different handler if necessary for a specific board. > > Select a priority of 129 to indicate a higher than default priority, but > keep it as low as possible since PSCI reset is known to fail on some > boards. > > Acked-by: Arnd Bergmann > Reviewed-by: Wolfram Sang > Tested-by: Wolfram Sang > Signed-off-by: Guenter Roeck > Acked-by: Lorenzo Pieralisi > Signed-off-by: Thierry Reding Looks good to me! And helps also in my case, a board which has a broken PSCI reset capability. Reviewed-by: Stefan Agner -- Stefan > --- > drivers/firmware/psci/psci.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 84f4ff351c62..a41c6ba043a2 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -250,7 +250,8 @@ static int get_set_conduit_method(struct device_node *np) > return 0; > } > > -static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > +static int psci_sys_reset(struct notifier_block *nb, unsigned long action, > + void *data) > { > if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) && > psci_system_reset2_supported) { > @@ -263,8 +264,15 @@ static void psci_sys_reset(enum reboot_mode > reboot_mode, const char *cmd) > } else { > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0); > } > + > + return NOTIFY_DONE; > } > > +static struct notifier_block psci_sys_reset_nb = { > + .notifier_call = psci_sys_reset, > + .priority = 129, > +}; > + > static void psci_sys_poweroff(void) > { > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_OFF, 0, 0, 0); > @@ -431,7 +439,7 @@ static void __init psci_0_2_set_functions(void) > > psci_ops.migrate_info_type = psci_migrate_info_type; > > - arm_pm_restart = psci_sys_reset; > + register_restart_handler(&psci_sys_reset_nb); > > pm_power_off = psci_sys_poweroff; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel