From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7141C18E5B for ; Tue, 10 Mar 2020 12:54:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4D7824692 for ; Tue, 10 Mar 2020 12:54:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kyUnAlSe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4D7824692 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x9UkIOz0vEGIHMuW4lspmoqfMEQQaix+MVkV3obXJ4I=; b=kyUnAlSed3hot0kul7m+SD3AQ hwDuVFRquHT1JnXJoaa4hQbF+g2IX1eCeFmSjbNwjktZF/PD4k/GbSj5nvg1qPWeXt0xfOJ3hEnOH Y42LvGD9TEXtclkR2Wsr0Ra6cxQjbeC2t17MwPXPt6pyrhGFI0wa0vnwCx25XBGO/IYHIW41Ekybd KOAc1ILYAABL7B/sVhRRgmBplkL1J1ztivOMp1XeNR3O93uzmnfM5lD9L6JezVcqLyQUtItX5Y5G5 FHJlm+c8+W/cX57u6PGzw3xDojG/uQzUmljQF5kGoeIrGL+7PwWMvHlP9Xi5uk7sQvmTRuWyjBp2H xP3DwseMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBeP6-0005Xe-Jh; Tue, 10 Mar 2020 12:54:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBeNq-0004Es-V0 for linux-arm-kernel@lists.infradead.org; Tue, 10 Mar 2020 12:53:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D5B830E; Tue, 10 Mar 2020 05:53:18 -0700 (PDT) Received: from [10.162.16.120] (a075563-lin.blr.arm.com [10.162.16.120]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4B3D3F6CF; Tue, 10 Mar 2020 05:53:14 -0700 (PDT) Subject: Re: [PATCH v6 07/18] arm64: cpufeature: Move cpu capability helpers inside C file To: Vincenzo Frascino , linux-arm-kernel@lists.infradead.org References: <1583476525-13505-1-git-send-email-amit.kachhap@arm.com> <1583476525-13505-8-git-send-email-amit.kachhap@arm.com> From: Amit Kachhap Message-ID: Date: Tue, 10 Mar 2020 18:23:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200310_055319_148493_255F657C X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Catalin Marinas , Kristina Martsenko , Dave Martin , Mark Brown , James Morse , Ramana Radhakrishnan , Will Deacon , Ard Biesheuvel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vincenzo, On 3/10/20 5:50 PM, Vincenzo Frascino wrote: > Hi Amit, > > On 3/6/20 6:35 AM, Amit Daniel Kachhap wrote: > > [...] > >> >> -static inline bool >> -cpucap_late_cpu_optional(const struct arm64_cpu_capabilities *cap) >> -{ >> - return !!(cap->type & ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU); >> -} >> - >> -static inline bool >> -cpucap_late_cpu_permitted(const struct arm64_cpu_capabilities *cap) >> -{ >> - return !!(cap->type & ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU); >> -} >> - >> /* >> * Generic helper for handling capabilties with multiple (match,enable) pairs >> * of call backs, sharing the same capability bit. >> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >> index b12e386..865dce6 100644 >> --- a/arch/arm64/kernel/cpufeature.c >> +++ b/arch/arm64/kernel/cpufeature.c >> @@ -1363,6 +1363,19 @@ static bool can_use_gic_priorities(const struct arm64_cpu_capabilities *entry, >> } >> #endif >> >> +/* Internal helper functions to match cpu capability type */ >> +static bool >> +cpucap_late_cpu_optional(const struct arm64_cpu_capabilities *cap) >> +{ >> + return !!(cap->type & ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU); >> +} >> + >> +static bool >> +cpucap_late_cpu_permitted(const struct arm64_cpu_capabilities *cap) >> +{ >> + return !!(cap->type & ARM64_CPUCAP_PERMITTED_FOR_LATE_CPU); >> +} >> + >> static const struct arm64_cpu_capabilities arm64_features[] = { >> { >> .desc = "GIC system register CPU interface", >> > > Seems that the signature of the functions above is changed during the migration. > In particular you dropped "inline". Is there any specific reason? Earlier Catalin pointed me here [1]. I guess its not a hot-path function. [1]: https://www.spinics.net/lists/arm-kernel/msg789696.html Cheers, Amit > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel