From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2818DC433DB for ; Wed, 23 Dec 2020 03:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D36DF223E8 for ; Wed, 23 Dec 2020 03:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbgLWDiH (ORCPT ); Tue, 22 Dec 2020 22:38:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgLWDiG (ORCPT ); Tue, 22 Dec 2020 22:38:06 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749DBC0613D6 for ; Tue, 22 Dec 2020 19:37:26 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id 11so9604976pfu.4 for ; Tue, 22 Dec 2020 19:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LuJaSbVapuF1xE4c0AaAdxE/WvHPBsVQQdMUsaXqhfE=; b=FAMg0YDv6wy5gFci9qPmyQjcSul42HXIsFUkS+010t9Ycefb++aqK8Poc4Nq3Nmuc3 kEtS52ZVO1njFByrEDowe46cV71dNua4319OnFEpoPMdE/S3qmkzIw/QF4vdM21IDTsi 8uhWrzosTH4kW4LjEGBmHvRzuXwCGMw4FhCw+aRCaMEACSAHb96JbcLw0pQycERMxm8u TV8Kx9MBIH9BWJ+HlGp6tv57rUFMXpdE7vhly6YPxAzHywQSQ+Z4f5iNRc8BXPOj5YUN +HM+89Odz/GOQ7MHmdPRwZ0ZvT7bCIAJ32bGcpLdeCeUqgg/fea63vQPkVwB5fQpOKvo aicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LuJaSbVapuF1xE4c0AaAdxE/WvHPBsVQQdMUsaXqhfE=; b=dNNZrHeNZCIYjUzPMAiVkGzDAT9TZomQeus3l740ft8aBv2s/AflsUXdNDkxs16zha 9EVhL8b9zJdNYfIcpuzJRg22rr0Ex4dNfg3mkdFN303d2leCA6jvFGXeo7jVh0eyHLN5 4AbWwGemhQVyHLH4D0bnnFAYwTkUCK0a4HldnrdovXvJLAXUDb5/o+gqCGY6kNfmcojL 2x6H6NiF2nPYavajty7N3q4BcF8NbIgjriDfxIV7JP0+slXKzHdhoZEqRSO5/Yo4MPA2 AjmHtvpbBrRcp49gR5+M2rHtrE2wL7HlsE9UKNGsxxgZIbY2dMSvZmGssHcHx0/2gT2s nL6w== X-Gm-Message-State: AOAM532GMwmh+0skgBFiix17awae0zcq2M1tyQkSoFw5J3RHVftFupJ2 uiNB+mBygZ5TZ8RMWn+pKI+7mkZdYcg= X-Google-Smtp-Source: ABdhPJyQCYnLmNHNbiGK55qMGv0bN1WMu0fPT7KEY6oIYRW7+FttAnEy4BUjAvA+PsC4D7K6ocqnuQ== X-Received: by 2002:aa7:9d81:0:b029:19d:ca64:3c62 with SMTP id f1-20020aa79d810000b029019dca643c62mr364266pfq.16.1608694645437; Tue, 22 Dec 2020 19:37:25 -0800 (PST) Received: from [10.230.29.166] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z11sm20522360pjn.5.2020.12.22.19.37.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 19:37:24 -0800 (PST) Subject: Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt To: Jim Quinlan , Sudeep Holla , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE Mes..." , open list References: <20201222145603.40192-1-jim2101024@gmail.com> <20201222145603.40192-3-jim2101024@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 22 Dec 2020 19:37:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201222145603.40192-3-jim2101024@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2020 6:56 AM, Jim Quinlan wrote: > The SMC/HVC SCMI transport is modified to allow the completion of an SCMI > message to be indicated by an interrupt rather than the return of the smc > call. This accommodates the existing behavior of the BrcmSTB SCMI > "platform" whose SW is already out in the field and cannot be changed. > > Signed-off-by: Jim Quinlan This looks good to me, just one question below: [snip] > @@ -111,6 +145,8 @@ static int smc_send_message(struct scmi_chan_info *cinfo, > shmem_tx_prepare(scmi_info->shmem, xfer); > > arm_smccc_1_1_invoke(scmi_info->func_id, 0, 0, 0, 0, 0, 0, 0, &res); > + if (scmi_info->irq) > + wait_for_completion(&scmi_info->tx_complete); Do we need this to have a preceding call to reinit_completion()? It does not look like this is going to make any practical difference but there are drivers doing that for correctness. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04B7C433E0 for ; Wed, 23 Dec 2020 03:38:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64A23223E0 for ; Wed, 23 Dec 2020 03:38:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64A23223E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U57k6xyWhrFutG6s9QF4CEN9MTdCo52qTDQwQ48qKyU=; b=vJW4DXYGwbjacnGzhY+1FWt7W QFmcE9zuEBokguVJR+KLU9/qbSlAPngeoQqwYie4mt4ACob31+9NGaX15QJsXIvAcWopUMFJTJzmG 7Oj9Ob4Ro/WSaaALS5hkptQ0qai8gzkaTmSuSu42Dun87Ll/3NG/2iKLxSp4NPcGRWL7CCEkCSHDb znsRR+/8cKwiQ2g8OLKppHho9+905Mygo+LT6XtFZchRRqXURhUo7GyE7O5de5uhiBxrTfIgfyaMX UEtdafYgJFTkMEtfabdyU6qHOpb/Vh8M1QjwHrc+vHubPGKLz2aBjt45fImTFOe71mZRUY23hTyhl wRAJdZ9ng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kruxw-0000kp-8J; Wed, 23 Dec 2020 03:37:32 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kruxt-0000kC-NK for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 03:37:30 +0000 Received: by mail-pf1-x433.google.com with SMTP id w6so9629213pfu.1 for ; Tue, 22 Dec 2020 19:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LuJaSbVapuF1xE4c0AaAdxE/WvHPBsVQQdMUsaXqhfE=; b=FAMg0YDv6wy5gFci9qPmyQjcSul42HXIsFUkS+010t9Ycefb++aqK8Poc4Nq3Nmuc3 kEtS52ZVO1njFByrEDowe46cV71dNua4319OnFEpoPMdE/S3qmkzIw/QF4vdM21IDTsi 8uhWrzosTH4kW4LjEGBmHvRzuXwCGMw4FhCw+aRCaMEACSAHb96JbcLw0pQycERMxm8u TV8Kx9MBIH9BWJ+HlGp6tv57rUFMXpdE7vhly6YPxAzHywQSQ+Z4f5iNRc8BXPOj5YUN +HM+89Odz/GOQ7MHmdPRwZ0ZvT7bCIAJ32bGcpLdeCeUqgg/fea63vQPkVwB5fQpOKvo aicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LuJaSbVapuF1xE4c0AaAdxE/WvHPBsVQQdMUsaXqhfE=; b=PAHU1t1c51cG7+fpyzUEJhqcgvAXr9mgPI1MTeaFszCwjqpe/gEHCoI9iPbfkqK8ok hAj/NNsBDL19sev48IBMV4ZCAeKI/gwYguFQyrvTUk2Zpwf7g2JlFsulQopincPOdXq4 HTlGl1m3QQxDs9IO4MJY5jf7VJI08dXV202qIXmjnySb3wx+jYjCN3LtJiRBjutfBbwn n5g0CRXE9O+w2fctjPKDtH4VEsYottpsfweIaipq2ks9gU2YV7tYvyLArj9xupOOReW/ uKOBqi9IwJ/AYgKDqBOwWo7Tuf4vk2nRX2/RtllMwaReUQw9aAicr02MDLKsGWGk62G9 QVSA== X-Gm-Message-State: AOAM531a3DLbwbou0RudZCnQX2EbV5BQbowuGw3IPnB9Qw1dyNvg0jDI E7xuhNo/lzZxn3YkE1usaMqDOYqNdI8= X-Google-Smtp-Source: ABdhPJyQCYnLmNHNbiGK55qMGv0bN1WMu0fPT7KEY6oIYRW7+FttAnEy4BUjAvA+PsC4D7K6ocqnuQ== X-Received: by 2002:aa7:9d81:0:b029:19d:ca64:3c62 with SMTP id f1-20020aa79d810000b029019dca643c62mr364266pfq.16.1608694645437; Tue, 22 Dec 2020 19:37:25 -0800 (PST) Received: from [10.230.29.166] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z11sm20522360pjn.5.2020.12.22.19.37.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 19:37:24 -0800 (PST) Subject: Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt To: Jim Quinlan , Sudeep Holla , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com References: <20201222145603.40192-1-jim2101024@gmail.com> <20201222145603.40192-3-jim2101024@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 22 Dec 2020 19:37:22 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201222145603.40192-3-jim2101024@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_223729_802229_6E199A45 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: open list , "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE Mes..." Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/22/2020 6:56 AM, Jim Quinlan wrote: > The SMC/HVC SCMI transport is modified to allow the completion of an SCMI > message to be indicated by an interrupt rather than the return of the smc > call. This accommodates the existing behavior of the BrcmSTB SCMI > "platform" whose SW is already out in the field and cannot be changed. > > Signed-off-by: Jim Quinlan This looks good to me, just one question below: [snip] > @@ -111,6 +145,8 @@ static int smc_send_message(struct scmi_chan_info *cinfo, > shmem_tx_prepare(scmi_info->shmem, xfer); > > arm_smccc_1_1_invoke(scmi_info->func_id, 0, 0, 0, 0, 0, 0, 0, &res); > + if (scmi_info->irq) > + wait_for_completion(&scmi_info->tx_complete); Do we need this to have a preceding call to reinit_completion()? It does not look like this is going to make any practical difference but there are drivers doing that for correctness. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel