From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88836C43334 for ; Wed, 15 Jun 2022 15:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LAre1Fp+q8T2xAUNPs2Srv7zDuglwPEOK2lCWQ24jKE=; b=w6jWBxyCI4W36A hMURXrWDKZtGPpL4gNegYgOuIo5Yq7PI6MwgqfHOtR4P74+OPsPmecn2Ld1OkHontaG5Oig+jgnqx f8mYf1h+Irwn41XD4YnvjZ7ndevkpo6CjVene3Xtw1/s84Pwh46NoO+5qNRmooZdusl3qEOBeyfTj ioNnfFT9cvTfunlKSdgM1RAhmXmeC4oeLEsP7aXxRpBVR4ZhbaOQb+zn10StOHHf+bKv3qygKvtfS ibupKNuQSu6aS+YL89rK4XZqGoPFjGQMPAPlLFETKdIL9sPXqnkXSmpKawG6UQlucweoQF7gwg1i4 /dcbv+WCrZtAQMyhUXJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1UdG-00F7yt-Ax; Wed, 15 Jun 2022 15:08:34 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1UdD-00F7ya-LQ for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 15:08:33 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 00E4E844B3; Wed, 15 Jun 2022 17:08:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1655305709; bh=xJ9Bnj8hQMcY3Pi/CKTkeJd6dgyr4pBbf2Yh0qzuMW4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UgIApErQCWrgqwUsmR6bPRONC7RSR79wI+vHeWM/vwYkW9IIH161cDGpiYRFsubcN /GhnFAcOdw8SS/gluwzFzQCte6tdmDg2gN0XpVfbZxGH/pJc0k1wn9gSrl3/QmauuE O+nYAjP67jRzY0fX8Bkx+C68eKmU3umBO6sHJHu8O3IlDWtceODsOhOynNfUrQybXk sHUnrz/T3sBGv170uofnVGMICMR3X0fLu25Ud1UQQ8WDYweUM2abH0pME9NIhIlUBT P05NhN+BID4IB3pt0wYPKY14aw1dezo1SLtjPjMSnHc4TuQobus/cBnCKNTXooZtJr KzjeYFgppfvXA== Message-ID: Date: Wed, 15 Jun 2022 17:08:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Content-Language: en-US To: Abel Vesa Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jacky Bai , Laurent Pinchart , Lucas Stach , Michael Turquette , Shawn Guo , Stephen Boyd , linux-imx@nxp.com References: <20220504204144.442193-1-marex@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_080831_982036_3402E4DD X-CRM114-Status: GOOD ( 10.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/15/22 16:30, Abel Vesa wrote: [...] >> +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev) >> +{ >> + struct clk_imx8mp_audiomix_priv *priv; >> + struct device *dev = &pdev->dev; >> + struct resource *res; >> + void __iomem *base; >> + struct clk_hw *hw; >> + int i; >> + >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> + if (!priv) >> + return -ENOMEM; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + base = devm_ioremap_resource(dev, res); >> + if (IS_ERR(base)) >> + return PTR_ERR(base); >> + > > Hmm, the audiomix blk-ctl driver uses the PD for this device. > That is not going to work. What is not going to work. Can you elaborate on your concerns ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel