From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euEdP-00046M-Pd for qemu-devel@nongnu.org; Fri, 09 Mar 2018 04:48:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euEdM-0001nr-II for qemu-devel@nongnu.org; Fri, 09 Mar 2018 04:48:19 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50954 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1euEdM-0001nk-C4 for qemu-devel@nongnu.org; Fri, 09 Mar 2018 04:48:16 -0500 References: <20180308083231.20180-1-kraxel@redhat.com> <20180309065247.xzribx4zjgx5bnj5@sirius.home.kraxel.org> <20180309075054.e4bpa4wsl2wak57w@sirius.home.kraxel.org> <20180309091533.uj3qpyjnczugfivh@sirius.home.kraxel.org> <20180309094403.gcsspbs4lzozx2zl@sirius.home.kraxel.org> From: Thomas Huth Message-ID: Date: Fri, 9 Mar 2018 10:48:13 +0100 MIME-Version: 1.0 In-Reply-To: <20180309094403.gcsspbs4lzozx2zl@sirius.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Peter Maydell , QEMU Developers On 09.03.2018 10:44, Gerd Hoffmann wrote: > On Fri, Mar 09, 2018 at 10:15:33AM +0100, Gerd Hoffmann wrote: >> On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote: >>> On 09.03.2018 08:50, Gerd Hoffmann wrote: >>>> Hi, >>>> >>>>> Maybe I should move the code to a separate source file so it can be >>>>> built with different compiler flags, without needing #pragma? I don't >>>>> feel like building all gtk code with -Wno-deprecated-declarations ... >>>> >>>> Hmm, that idea doesn't fly, seems per-object cflags don't work for >>>> object files which get linked into a module. >>>> >>>> Other ideas anyone? >>> >>> Maybe simply remove the '#pragma GCC diagnostic ignored >>> "-Wunused-but-set-variable"' from the configure test and change >>> util/coroutine-ucontext.c: >> >> I'll try. Will probably have the effect that freebsd builds with >> -Werror then (which is now turned off by configure due to missing >> pragma support), which might trigger more issues ... > > Well, guessed almost right. -Werror is enabled on linux only, so > freebsd builds do not fail. But clang builds on linux fail, due to a > bunch of warnings (now errors) about unaligned access to struct members. Ugh, this is getting messy ... could you maybe turn them back into warnings again with -Wno-error=... when compiling with clang? Thomas